You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "yunfengzhou-hub (via GitHub)" <gi...@apache.org> on 2023/04/23 10:53:19 UTC

[GitHub] [flink] yunfengzhou-hub opened a new pull request, #22462: [FLINK-31752] Fix SourceOperator numRecordsOut duplicate bug

yunfengzhou-hub opened a new pull request, #22462:
URL: https://github.com/apache/flink/pull/22462

   ## What is the purpose of the change
   
   This pull request fixes the bug that the metric numRecordsOut is increased twice in `SourceOperatorStreamTask` and in `ChainingOutput`, which was introduced in #21579.
   
   
   ## Brief change log
   
   - Removes the process to increase numRecordsOut in `SourceOperatorStreamTask`.
   - Modifies `SourceMetricsITCase` to verify the correctness of this metric on SourceOperator.
   
   
   ## Verifying this change
   
   The correctness of the changes in this pull request is covered by the test class `SourceMetricsITCase`.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): yes
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] yunfengzhou-hub commented on pull request #22462: [FLINK-31752] Fix SourceOperator numRecordsOut duplicate bug

Posted by "yunfengzhou-hub (via GitHub)" <gi...@apache.org>.
yunfengzhou-hub commented on PR #22462:
URL: https://github.com/apache/flink/pull/22462#issuecomment-1519033020

   Hi @lindong28, could you please take a look at this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] lindong28 merged pull request #22462: [FLINK-31752] Fix SourceOperator numRecordsOut duplicate bug

Posted by "lindong28 (via GitHub)" <gi...@apache.org>.
lindong28 merged PR #22462:
URL: https://github.com/apache/flink/pull/22462


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #22462: [FLINK-31752] Fix SourceOperator numRecordsOut duplicate bug

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #22462:
URL: https://github.com/apache/flink/pull/22462#issuecomment-1519034402

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "cb7a43d3ce87e86b35251136476ff1337cdb433f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "cb7a43d3ce87e86b35251136476ff1337cdb433f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * cb7a43d3ce87e86b35251136476ff1337cdb433f UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] lindong28 commented on pull request #22462: [FLINK-31752] Fix SourceOperator numRecordsOut duplicate bug

Posted by "lindong28 (via GitHub)" <gi...@apache.org>.
lindong28 commented on PR #22462:
URL: https://github.com/apache/flink/pull/22462#issuecomment-1519099419

   Thanks for the PR. LGTM.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org