[GitHub] [activemq-artemis] brusdev commented on a diff in pull request #4410: ARTEMIS-4213 doc update added some Broker Properties reference and added s…

["brusdev (via GitHub)" <gi...@apache.org>]

brusdev commented on code in PR #4410:
URL: https://github.com/apache/activemq-artemis/pull/4410#discussion_r1144562643


##########
docs/user-manual/en/configuration-index.md:
##########
@@ -118,6 +118,9 @@ Enable debug logging for `org.apache.activemq.artemis.core.config.impl.Configura
 
 There are a growing number of examples of what can be explicitly configured in this way in the [unit test](https://github.com/apache/activemq-artemis/blob/065bfe14f532858f2c2a20b0afb1a226b08ce013/artemis-server/src/test/java/org/apache/activemq/artemis/core/config/impl/ConfigurationImplTest.java#L675).
 
+For an incomplete list of some of the properties that are available and have been tested see [Broker Properties Reference](#broker-properties-reference)

Review Comment:
   ```suggestion
   For a partial list of some of the supported properties that have been tested see [Broker Properties Reference](#broker-properties-reference)
   ```



##########
docs/user-manual/en/configuration-index.md:
##########
@@ -481,3 +484,285 @@ Name | Description | Default
 [password](amqp-broker-connections.md#amqp-server-connections) | Broker authentication password (optional) | n/a
 [reconnect-attempts](amqp-broker-connections.md#amqp-server-connections) | How many attempts should be made to reconnect after failure. | -1 (infinite)
 [auto-start](amqp-broker-connections.md#amqp-server-connections) | Broker connection starts automatically with broker | true
+
+
+## Broker Properties Reference

Review Comment:
   This list could become stale, could we generate it from the sources?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org