You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "feiniaofeiafei (via GitHub)" <gi...@apache.org> on 2024/03/29 05:11:30 UTC
[PR] [Fix](nereids) forward the user define variables to master [doris]
feiniaofeiafei opened a new pull request, #33013:
URL: https://github.com/apache/doris/pull/33013
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](nereids) forward the user define variables to master [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #33013:
URL: https://github.com/apache/doris/pull/33013#issuecomment-2031492954
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](nereids) forward the user define variables to master [doris]
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow merged PR #33013:
URL: https://github.com/apache/doris/pull/33013
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](nereids) forward the user define variables to master [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #33013:
URL: https://github.com/apache/doris/pull/33013#issuecomment-2026915595
<details>
<summary>TPC-DS: <b>Total hot run time: 181094 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6d396690e32be7de671df8122505f00c3882f433, data reload: false
query1 897 1117 363 363
query2 6466 1908 1919 1908
query3 6661 216 231 216
query4 25108 21322 21294 21294
query5 4235 399 409 399
query6 266 186 183 183
query7 4609 302 285 285
query8 228 190 182 182
query9 8424 2295 2279 2279
query10 531 234 246 234
query11 14907 14335 14263 14263
query12 142 90 97 90
query13 1644 372 383 372
query14 10148 6788 6898 6788
query15 203 174 184 174
query16 6761 268 276 268
query17 1525 597 569 569
query18 1374 295 284 284
query19 198 160 158 158
query20 92 90 88 88
query21 205 126 132 126
query22 4948 4832 4804 4804
query23 33434 32788 32838 32788
query24 12229 2840 2874 2840
query25 644 393 386 386
query26 1696 156 155 155
query27 3275 323 329 323
query28 6915 1843 1843 1843
query29 924 619 603 603
query30 297 148 149 148
query31 964 727 722 722
query32 87 56 56 56
query33 705 254 248 248
query34 1128 486 502 486
query35 878 677 702 677
query36 1070 876 917 876
query37 216 70 69 69
query38 3528 3418 3420 3418
query39 1611 1528 1546 1528
query40 287 129 128 128
query41 51 49 47 47
query42 106 98 99 98
query43 506 452 447 447
query44 1219 737 728 728
query45 272 253 278 253
query46 1074 691 691 691
query47 1958 1871 1827 1827
query48 393 314 293 293
query49 1169 385 378 378
query50 781 392 390 390
query51 6709 6619 6647 6619
query52 103 99 88 88
query53 347 283 281 281
query54 299 248 238 238
query55 87 83 85 83
query56 249 235 236 235
query57 1236 1133 1118 1118
query58 228 218 208 208
query59 2823 2759 2499 2499
query60 264 249 247 247
query61 115 114 127 114
query62 653 442 436 436
query63 308 285 280 280
query64 6827 4038 4142 4038
query65 3231 3057 3068 3057
query66 1454 353 327 327
query67 15726 14944 15055 14944
query68 7481 544 537 537
query69 570 326 325 325
query70 1270 1132 1207 1132
query71 507 272 275 272
query72 6591 2604 2475 2475
query73 741 334 332 332
query74 7026 6447 6295 6295
query75 3635 2322 2297 2297
query76 4980 908 993 908
query77 600 256 262 256
query78 10825 10158 10196 10158
query79 11458 557 520 520
query80 1874 418 415 415
query81 530 221 216 216
query82 668 91 94 91
query83 223 168 177 168
query84 264 85 84 84
query85 1403 270 257 257
query86 384 306 296 296
query87 3878 3549 3581 3549
query88 5783 2407 2402 2402
query89 508 390 375 375
query90 1980 180 183 180
query91 129 101 102 101
query92 62 50 49 49
query93 6822 521 504 504
query94 1258 184 184 184
query95 412 316 318 316
query96 601 276 266 266
query97 2689 2492 2501 2492
query98 238 226 213 213
query99 1146 874 844 844
Total cold run time: 304184 ms
Total hot run time: 181094 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](nereids) forward the user define variables to master [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #33013:
URL: https://github.com/apache/doris/pull/33013#issuecomment-2026901689
<details>
<summary>TPC-H: <b>Total hot run time: 38550 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6d396690e32be7de671df8122505f00c3882f433, data reload: false
------ Round 1 ----------------------------------
q1 17645 4411 4283 4283
q2 2105 199 183 183
q3 10542 1246 1195 1195
q4 10639 816 846 816
q5 7469 2760 2780 2760
q6 215 129 131 129
q7 1044 649 586 586
q8 9232 2051 2036 2036
q9 7411 6578 6569 6569
q10 8525 3514 3523 3514
q11 467 238 231 231
q12 387 226 213 213
q13 18829 2964 2964 2964
q14 266 250 235 235
q15 531 474 457 457
q16 523 382 386 382
q17 981 615 589 589
q18 7471 6905 6575 6575
q19 7722 1466 1412 1412
q20 655 320 314 314
q21 3480 2801 2815 2801
q22 367 320 306 306
Total cold run time: 116506 ms
Total hot run time: 38550 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4360 4213 4212 4212
q2 385 273 270 270
q3 2973 2692 2732 2692
q4 1945 1559 1584 1559
q5 5283 5253 5296 5253
q6 211 121 125 121
q7 2276 1869 1835 1835
q8 3215 3288 3279 3279
q9 8599 8547 8583 8547
q10 3842 3624 3618 3618
q11 583 484 474 474
q12 742 586 616 586
q13 17614 2932 2983 2932
q14 302 267 270 267
q15 506 484 472 472
q16 495 433 420 420
q17 1792 1429 1440 1429
q18 7715 7346 7349 7346
q19 1632 1490 1503 1490
q20 1963 1731 1749 1731
q21 4935 4732 4806 4732
q22 539 456 478 456
Total cold run time: 71907 ms
Total hot run time: 53721 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](nereids) forward the user define variables to master [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #33013:
URL: https://github.com/apache/doris/pull/33013#issuecomment-2031565919
<details>
<summary>ClickBench: <b>Total hot run time: 30.86 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6f4bd644bb35015d2cc3ce71bc55355026665b0c, data reload: false
query1 0.04 0.04 0.03
query2 0.08 0.04 0.04
query3 0.24 0.04 0.04
query4 1.68 0.07 0.07
query5 0.48 0.49 0.49
query6 1.15 0.65 0.65
query7 0.02 0.01 0.02
query8 0.05 0.04 0.04
query9 0.58 0.51 0.52
query10 0.56 0.58 0.56
query11 0.15 0.11 0.11
query12 0.14 0.12 0.12
query13 0.60 0.60 0.60
query14 0.77 0.78 0.79
query15 0.85 0.83 0.84
query16 0.35 0.36 0.36
query17 0.99 1.03 0.97
query18 0.25 0.24 0.27
query19 1.87 1.76 1.68
query20 0.02 0.01 0.01
query21 15.42 0.74 0.69
query22 3.28 5.38 2.45
query23 17.63 1.40 1.20
query24 1.41 0.37 0.21
query25 0.14 0.10 0.09
query26 0.28 0.18 0.20
query27 0.08 0.09 0.09
query28 13.52 0.96 0.94
query29 12.59 3.36 3.52
query30 0.26 0.05 0.08
query31 2.85 0.38 0.38
query32 3.26 0.47 0.47
query33 2.86 2.87 2.83
query34 15.51 4.32 4.32
query35 4.36 4.34 4.34
query36 0.66 0.47 0.47
query37 0.18 0.17 0.16
query38 0.16 0.15 0.16
query39 0.04 0.04 0.04
query40 0.21 0.16 0.16
query41 0.10 0.05 0.05
query42 0.06 0.05 0.05
query43 0.04 0.04 0.04
Total cold run time: 105.77 s
Total hot run time: 30.86 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](nereids) forward the user define variables to master [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #33013:
URL: https://github.com/apache/doris/pull/33013#issuecomment-2026660434
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](nereids) forward the user define variables to master [doris]
Posted by "feiniaofeiafei (via GitHub)" <gi...@apache.org>.
feiniaofeiafei commented on PR #33013:
URL: https://github.com/apache/doris/pull/33013#issuecomment-2031271720
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](nereids) forward the user define variables to master [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #33013:
URL: https://github.com/apache/doris/pull/33013#issuecomment-2031397102
<details>
<summary>TPC-H: <b>Total hot run time: 39057 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5ef532e18aad6ff784051aff88069d02896ebec9, data reload: false
------ Round 1 ----------------------------------
q1 17688 4175 4188 4175
q2 2015 186 186 186
q3 10482 1279 1436 1279
q4 10207 904 988 904
q5 7484 2977 2959 2959
q6 219 132 132 132
q7 1099 611 648 611
q8 9405 2060 2063 2060
q9 6691 6255 6185 6185
q10 8473 3564 3544 3544
q11 432 242 234 234
q12 379 221 213 213
q13 17781 2872 2907 2872
q14 283 245 247 245
q15 533 488 484 484
q16 494 403 386 386
q17 975 909 907 907
q18 7403 6504 6415 6415
q19 1600 1548 1537 1537
q20 588 327 306 306
q21 3642 3210 3122 3122
q22 368 301 312 301
Total cold run time: 108241 ms
Total hot run time: 39057 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4184 4054 4083 4054
q2 328 212 220 212
q3 3005 2967 2943 2943
q4 1880 1889 1810 1810
q5 5247 5234 5222 5222
q6 203 124 121 121
q7 2216 1799 1825 1799
q8 3217 3296 3307 3296
q9 8503 8483 8476 8476
q10 3774 4009 4021 4009
q11 551 475 456 456
q12 760 580 619 580
q13 15971 3167 3118 3118
q14 312 268 292 268
q15 529 484 483 483
q16 499 435 445 435
q17 1756 1737 1703 1703
q18 8187 7902 7689 7689
q19 1751 1718 1752 1718
q20 1960 1765 1807 1765
q21 5286 4968 4920 4920
q22 503 429 447 429
Total cold run time: 70622 ms
Total hot run time: 55506 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](nereids) forward the user define variables to master [doris]
Posted by "feiniaofeiafei (via GitHub)" <gi...@apache.org>.
feiniaofeiafei commented on PR #33013:
URL: https://github.com/apache/doris/pull/33013#issuecomment-2026660496
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](nereids) forward the user define variables to master [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #33013:
URL: https://github.com/apache/doris/pull/33013#issuecomment-2026730366
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](nereids) forward the user define variables to master [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #33013:
URL: https://github.com/apache/doris/pull/33013#issuecomment-2031572765
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 6f4bd644bb35015d2cc3ce71bc55355026665b0c with default session variables
Stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
Stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
Insert into select: 15.6 seconds inserted 10000000 Rows, about 641K ops/s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](nereids) forward the user define variables to master [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #33013:
URL: https://github.com/apache/doris/pull/33013#issuecomment-2031555364
<details>
<summary>TPC-DS: <b>Total hot run time: 181957 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6f4bd644bb35015d2cc3ce71bc55355026665b0c, data reload: false
query1 1221 1132 1128 1128
query2 6497 1879 1863 1863
query3 6661 213 218 213
query4 23428 21566 21375 21375
query5 4196 400 414 400
query6 274 192 184 184
query7 4599 309 300 300
query8 234 179 189 179
query9 8461 2272 2280 2272
query10 580 264 271 264
query11 15019 14642 14398 14398
query12 146 100 96 96
query13 1652 388 377 377
query14 8729 6837 6837 6837
query15 219 191 193 191
query16 7118 300 272 272
query17 979 604 581 581
query18 1897 306 283 283
query19 211 167 166 166
query20 102 95 99 95
query21 205 124 124 124
query22 5013 4791 4837 4791
query23 33576 32922 32505 32505
query24 12571 3163 3114 3114
query25 686 381 416 381
query26 1907 170 163 163
query27 3003 325 326 325
query28 6774 1850 1828 1828
query29 1332 578 571 571
query30 303 164 169 164
query31 999 702 727 702
query32 99 62 63 62
query33 702 253 240 240
query34 1050 482 493 482
query35 853 689 703 689
query36 994 867 854 854
query37 275 77 82 77
query38 3486 3459 3384 3384
query39 1579 1520 1576 1520
query40 310 132 133 132
query41 46 43 46 43
query42 107 109 101 101
query43 437 396 401 396
query44 1098 716 700 700
query45 272 263 258 258
query46 1087 832 780 780
query47 1923 1809 1818 1809
query48 381 310 305 305
query49 1150 366 353 353
query50 802 397 404 397
query51 6786 6760 6797 6760
query52 112 98 104 98
query53 370 291 292 291
query54 315 247 238 238
query55 87 82 86 82
query56 254 226 231 226
query57 1225 1154 1132 1132
query58 257 241 229 229
query59 2471 2285 2406 2285
query60 281 251 258 251
query61 111 106 108 106
query62 702 453 448 448
query63 316 281 280 280
query64 6437 3048 3370 3048
query65 3101 3008 3036 3008
query66 1460 341 335 335
query67 15667 14947 15279 14947
query68 5075 574 589 574
query69 471 328 331 328
query70 1131 1104 1130 1104
query71 421 285 279 279
query72 6305 2748 2557 2557
query73 737 335 326 326
query74 6886 6457 6485 6457
query75 2968 2264 2305 2264
query76 3292 1062 1210 1062
query77 387 258 246 246
query78 10851 10158 10024 10024
query79 8755 529 539 529
query80 1749 425 417 417
query81 520 237 236 236
query82 1341 109 106 106
query83 309 166 161 161
query84 270 92 88 88
query85 1628 285 278 278
query86 467 284 276 276
query87 3715 3530 3494 3494
query88 4382 2343 2344 2343
query89 587 371 386 371
query90 1998 175 186 175
query91 133 109 106 106
query92 62 53 55 53
query93 6576 538 521 521
query94 1210 193 198 193
query95 1096 1095 1097 1095
query96 617 275 273 273
query97 2666 2496 2518 2496
query98 237 217 209 209
query99 1398 828 845 828
Total cold run time: 293435 ms
Total hot run time: 181957 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](nereids) forward the user define variables to master [doris]
Posted by "feiniaofeiafei (via GitHub)" <gi...@apache.org>.
feiniaofeiafei commented on PR #33013:
URL: https://github.com/apache/doris/pull/33013#issuecomment-2026839970
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](nereids) forward the user define variables to master [doris]
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on code in PR #33013:
URL: https://github.com/apache/doris/pull/33013#discussion_r1546026228
##########
gensrc/thrift/FrontendService.thrift:
##########
@@ -495,6 +495,11 @@ struct TFeResult {
1001: optional bool noAuth
}
+struct TTypeAndLiteral {
+ 1: required Types.TPrimitiveType type
+ 2: required string value
Review Comment:
do not use required, use optional
##########
gensrc/thrift/FrontendService.thrift:
##########
@@ -495,6 +495,11 @@ struct TFeResult {
1001: optional bool noAuth
}
+struct TTypeAndLiteral {
+ 1: required Types.TPrimitiveType type
+ 2: required string value
Review Comment:
why value is string? i think we should use TExprNode
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](nereids) forward the user define variables to master [doris]
Posted by "feiniaofeiafei (via GitHub)" <gi...@apache.org>.
feiniaofeiafei commented on PR #33013:
URL: https://github.com/apache/doris/pull/33013#issuecomment-2031481905
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](nereids) forward the user define variables to master [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #33013:
URL: https://github.com/apache/doris/pull/33013#issuecomment-2031428986
<details>
<summary>ClickBench: <b>Total hot run time: 31.19 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 5ef532e18aad6ff784051aff88069d02896ebec9, data reload: false
query1 0.04 0.04 0.03
query2 0.08 0.04 0.04
query3 0.23 0.04 0.05
query4 1.68 0.06 0.07
query5 0.48 0.48 0.47
query6 1.16 0.65 0.64
query7 0.02 0.01 0.01
query8 0.04 0.04 0.04
query9 0.54 0.51 0.50
query10 0.57 0.58 0.56
query11 0.14 0.10 0.11
query12 0.13 0.12 0.12
query13 0.61 0.60 0.59
query14 0.76 0.78 0.79
query15 0.86 0.85 0.83
query16 0.35 0.35 0.35
query17 0.96 0.98 0.97
query18 0.25 0.26 0.26
query19 1.82 1.70 1.73
query20 0.02 0.01 0.01
query21 15.40 0.75 0.67
query22 2.89 5.25 2.74
query23 17.66 1.25 1.16
query24 1.37 0.39 0.27
query25 0.14 0.10 0.09
query26 0.28 0.18 0.18
query27 0.08 0.08 0.08
query28 13.41 0.94 0.94
query29 12.53 3.38 3.46
query30 0.25 0.06 0.05
query31 2.86 0.40 0.39
query32 3.29 0.48 0.48
query33 2.84 2.86 2.91
query34 15.49 4.33 4.32
query35 4.36 4.35 4.35
query36 0.67 0.48 0.47
query37 0.21 0.18 0.18
query38 0.16 0.17 0.15
query39 0.05 0.04 0.04
query40 0.18 0.15 0.16
query41 0.10 0.05 0.05
query42 0.06 0.06 0.05
query43 0.05 0.04 0.04
Total cold run time: 105.07 s
Total hot run time: 31.19 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](nereids) forward the user define variables to master [doris]
Posted by "feiniaofeiafei (via GitHub)" <gi...@apache.org>.
feiniaofeiafei commented on PR #33013:
URL: https://github.com/apache/doris/pull/33013#issuecomment-2026723855
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](nereids) forward the user define variables to master [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #33013:
URL: https://github.com/apache/doris/pull/33013#issuecomment-2026664593
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](nereids) forward the user define variables to master [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #33013:
URL: https://github.com/apache/doris/pull/33013#issuecomment-2026740395
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](nereids) forward the user define variables to master [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #33013:
URL: https://github.com/apache/doris/pull/33013#issuecomment-2026922493
<details>
<summary>ClickBench: <b>Total hot run time: 29.46 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6d396690e32be7de671df8122505f00c3882f433, data reload: false
query1 0.04 0.03 0.04
query2 0.08 0.04 0.03
query3 0.22 0.05 0.05
query4 1.67 0.08 0.09
query5 0.50 0.49 0.51
query6 1.15 0.65 0.65
query7 0.02 0.01 0.01
query8 0.05 0.04 0.04
query9 0.53 0.51 0.50
query10 0.56 0.54 0.55
query11 0.15 0.10 0.12
query12 0.14 0.12 0.11
query13 0.60 0.58 0.59
query14 0.77 0.78 0.79
query15 0.82 0.81 0.80
query16 0.36 0.37 0.38
query17 0.93 1.02 0.95
query18 0.23 0.24 0.24
query19 1.87 1.72 1.73
query20 0.02 0.01 0.01
query21 15.58 0.66 0.64
query22 2.69 2.64 1.57
query23 17.30 0.84 0.89
query24 1.20 0.28 0.23
query25 0.09 0.08 0.08
query26 0.23 0.16 0.16
query27 0.08 0.08 0.09
query28 13.89 0.96 0.95
query29 12.53 3.20 3.22
query30 0.27 0.08 0.08
query31 2.83 0.39 0.36
query32 3.34 0.45 0.47
query33 2.78 2.87 2.82
query34 16.68 4.40 4.41
query35 4.47 4.47 4.52
query36 0.59 0.47 0.47
query37 0.17 0.15 0.16
query38 0.15 0.14 0.14
query39 0.04 0.04 0.03
query40 0.17 0.14 0.14
query41 0.09 0.04 0.04
query42 0.06 0.05 0.04
query43 0.05 0.04 0.04
Total cold run time: 105.99 s
Total hot run time: 29.46 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](nereids) forward the user define variables to master [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #33013:
URL: https://github.com/apache/doris/pull/33013#issuecomment-2026925930
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 6d396690e32be7de671df8122505f00c3882f433 with default session variables
Stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc: 58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select: 13.9 seconds inserted 10000000 Rows, about 719K ops/s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](nereids) forward the user define variables to master [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #33013:
URL: https://github.com/apache/doris/pull/33013#issuecomment-2031280563
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](nereids) forward the user define variables to master [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #33013:
URL: https://github.com/apache/doris/pull/33013#issuecomment-2026845780
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](nereids) forward the user define variables to master [doris]
Posted by "feiniaofeiafei (via GitHub)" <gi...@apache.org>.
feiniaofeiafei commented on PR #33013:
URL: https://github.com/apache/doris/pull/33013#issuecomment-2026733279
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](nereids) forward the user define variables to master [doris]
Posted by "924060929 (via GitHub)" <gi...@apache.org>.
924060929 commented on code in PR #33013:
URL: https://github.com/apache/doris/pull/33013#discussion_r1548881100
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/LiteralExpr.java:
##########
@@ -479,4 +481,22 @@ public boolean isZero() {
}
return isZero;
}
+
+ public static LiteralExpr getLiteralExprFromThrift(TExprNode node) throws AnalysisException {
+ TExprNodeType type = node.node_type;
+ switch (type) {
+ case NULL_LITERAL: return new NullLiteral();
+ case BOOL_LITERAL: return new BoolLiteral(node.bool_literal.value);
+ case INT_LITERAL: return new IntLiteral(node.int_literal.value);
+ case LARGE_INT_LITERAL: return new LargeIntLiteral(node.large_int_literal.value);
+ case FLOAT_LITERAL: return new FloatLiteral(node.float_literal.value);
+ case DECIMAL_LITERAL: return new DecimalLiteral(node.decimal_literal.value);
+ case STRING_LITERAL: return new StringLiteral(node.string_literal.value);
+ case JSON_LITERAL: return new JsonLiteral(node.json_literal.value);
+ case DATE_LITERAL: return new DateLiteral(node.date_literal.value);
+ case IPV4_LITERAL: return new IPv4Literal(node.ipv4_literal.value);
+ case IPV6_LITERAL: return new IPv6Literal(node.ipv6_literal.value);
+ default: throw new AnalysisException("Wrong type from thrift;");
Review Comment:
maybe we should skip deserialize this literal?
##########
fe/fe-core/src/main/java/org/apache/doris/qe/ConnectProcessor.java:
##########
@@ -654,4 +663,18 @@ public TMasterOpResult proxyExecute(TMasterOpRequest request) {
public void processOnce() throws IOException, NotImplementedException {
throw new NotImplementedException("Not Impl processOnce");
}
+
+ private Map<String, LiteralExpr> userVariableFromThrift(Map<String, TExprNode> thriftMap) throws TException {
+ try {
+ Map<String, LiteralExpr> userVariables = Maps.newHashMap();
+ for (Map.Entry<String, TExprNode> entry : thriftMap.entrySet()) {
+ TExprNode tExprNode = entry.getValue();
+ LiteralExpr literalExpr = LiteralExpr.getLiteralExprFromThrift(tExprNode);
+ userVariables.put(entry.getKey(), literalExpr);
+ }
+ return userVariables;
+ } catch (AnalysisException e) {
+ throw new TException(e.getMessage());
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](nereids) forward the user define variables to master [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #33013:
URL: https://github.com/apache/doris/pull/33013#issuecomment-2031418814
<details>
<summary>TPC-DS: <b>Total hot run time: 182819 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5ef532e18aad6ff784051aff88069d02896ebec9, data reload: false
query1 1212 1109 1115 1109
query2 6202 1828 1838 1828
query3 6651 211 211 211
query4 23737 21571 21554 21554
query5 4146 391 403 391
query6 277 181 175 175
query7 4605 292 300 292
query8 223 181 174 174
query9 8452 2276 2266 2266
query10 438 244 265 244
query11 15218 14594 14447 14447
query12 142 98 96 96
query13 1629 383 379 379
query14 8625 6946 6969 6946
query15 209 174 185 174
query16 7096 284 277 277
query17 980 594 580 580
query18 1870 284 302 284
query19 219 167 161 161
query20 101 91 93 91
query21 195 137 135 135
query22 4943 4830 4812 4812
query23 33449 32774 32791 32774
query24 13247 3254 3263 3254
query25 720 445 442 442
query26 1983 178 169 169
query27 3143 375 385 375
query28 6966 1911 1903 1903
query29 1329 623 626 623
query30 339 184 171 171
query31 1064 751 740 740
query32 100 76 67 67
query33 704 246 257 246
query34 1136 521 522 521
query35 858 717 734 717
query36 1030 860 898 860
query37 282 83 79 79
query38 3788 3619 3617 3617
query39 1649 1614 1605 1605
query40 257 151 154 151
query41 48 48 54 48
query42 118 114 110 110
query43 446 404 423 404
query44 1095 713 735 713
query45 286 250 270 250
query46 1108 866 820 820
query47 1994 1893 1894 1893
query48 403 319 309 309
query49 973 383 377 377
query50 856 412 406 406
query51 6974 6878 6869 6869
query52 115 99 100 99
query53 376 301 303 301
query54 308 246 240 240
query55 87 82 74 74
query56 242 236 231 231
query57 1236 1198 1167 1167
query58 256 238 220 220
query59 2689 2563 2510 2510
query60 247 239 230 230
query61 91 89 91 89
query62 651 465 457 457
query63 309 279 285 279
query64 5817 3116 3095 3095
query65 3036 3014 3031 3014
query66 1293 329 316 316
query67 15368 15100 14842 14842
query68 9041 580 596 580
query69 564 332 327 327
query70 1298 1093 1091 1091
query71 505 274 269 269
query72 6211 2564 2413 2413
query73 1307 322 322 322
query74 6733 6412 6322 6322
query75 3745 2299 2260 2260
query76 5538 1126 1228 1126
query77 558 249 239 239
query78 10915 10181 10139 10139
query79 12395 520 536 520
query80 1706 418 411 411
query81 519 248 238 238
query82 410 106 104 104
query83 210 160 159 159
query84 264 91 87 87
query85 1013 320 287 287
query86 363 287 266 266
query87 3646 3457 3481 3457
query88 4190 2350 2344 2344
query89 566 374 367 367
query90 2102 176 183 176
query91 130 105 103 103
query92 62 52 51 51
query93 6689 531 527 527
query94 1349 195 194 194
query95 453 339 331 331
query96 600 282 275 275
query97 2663 2488 2505 2488
query98 224 217 212 212
query99 1213 831 837 831
Total cold run time: 302818 ms
Total hot run time: 182819 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](nereids) forward the user define variables to master [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #33013:
URL: https://github.com/apache/doris/pull/33013#issuecomment-2031436823
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 5ef532e18aad6ff784051aff88069d02896ebec9 with default session variables
Stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
Stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
Insert into select: 16.5 seconds inserted 10000000 Rows, about 606K ops/s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](nereids) forward the user define variables to master [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #33013:
URL: https://github.com/apache/doris/pull/33013#issuecomment-2031490921
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](nereids) forward the user define variables to master [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #33013:
URL: https://github.com/apache/doris/pull/33013#issuecomment-2031490798
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](nereids) forward the user define variables to master [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #33013:
URL: https://github.com/apache/doris/pull/33013#issuecomment-2031528489
<details>
<summary>TPC-H: <b>Total hot run time: 39515 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6f4bd644bb35015d2cc3ce71bc55355026665b0c, data reload: false
------ Round 1 ----------------------------------
q1 18858 4264 4225 4225
q2 2641 198 198 198
q3 11088 1230 1401 1230
q4 10209 878 1036 878
q5 7480 2955 2942 2942
q6 229 135 133 133
q7 1111 656 609 609
q8 9423 2043 2045 2043
q9 7417 6804 6753 6753
q10 8482 3527 3512 3512
q11 430 243 243 243
q12 386 224 219 219
q13 17788 2876 2931 2876
q14 271 246 239 239
q15 528 489 470 470
q16 516 389 381 381
q17 964 918 927 918
q18 7300 6553 6400 6400
q19 1616 1535 1529 1529
q20 587 322 303 303
q21 3529 3128 3111 3111
q22 367 303 317 303
Total cold run time: 111220 ms
Total hot run time: 39515 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4053 4081 4058 4058
q2 329 223 223 223
q3 2953 2959 2940 2940
q4 1897 1852 1843 1843
q5 5200 5207 5206 5206
q6 205 122 122 122
q7 2238 1816 1814 1814
q8 3200 3281 3285 3281
q9 9048 9011 8993 8993
q10 3746 3805 3828 3805
q11 526 452 454 452
q12 708 565 561 561
q13 14241 2911 2879 2879
q14 296 247 268 247
q15 510 464 469 464
q16 474 401 423 401
q17 1728 1704 1692 1692
q18 7616 7204 7276 7204
q19 1633 1629 1635 1629
q20 1954 1727 1703 1703
q21 5073 4692 4773 4692
q22 517 419 421 419
Total cold run time: 68145 ms
Total hot run time: 54628 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org