You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by rodrigo meneses <rm...@pivotal.io> on 2014/10/13 22:47:07 UTC

Review Request 26659: Allow different stack have different predefined site properties

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26659/
-----------------------------------------------------------

Review request for Ambari, jun aoki and Vitthal Gogate.


Repository: ambari


Description
-------

Allow different stack have different predefined site properties


Diffs
-----

  ambari-web/app/data/BIGTOP/site_properties.js PRE-CREATION 
  ambari-web/app/utils/config.js 4b26608 
  ambari-web/test/utils/config_test.js 528be46 

Diff: https://reviews.apache.org/r/26659/diff/


Testing
-------

1. Built ambari rpm
2. deploy BIGTOP stack 


Thanks,

rodrigo meneses


Re: Review Request 26659: Allow different stack have different predefined site properties

Posted by Saman Alvi <sa...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26659/#review56555
-----------------------------------------------------------

Ship it!


Ship It!

- Saman Alvi


On Oct. 13, 2014, 8:47 p.m., rodrigo meneses wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26659/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2014, 8:47 p.m.)
> 
> 
> Review request for Ambari, jun aoki and Vitthal Gogate.
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Allow different stack have different predefined site properties
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/data/BIGTOP/site_properties.js PRE-CREATION 
>   ambari-web/app/utils/config.js 4b26608 
>   ambari-web/test/utils/config_test.js 528be46 
> 
> Diff: https://reviews.apache.org/r/26659/diff/
> 
> 
> Testing
> -------
> 
> 1. Built ambari rpm
> 2. deploy BIGTOP stack 
> 
> 
> Thanks,
> 
> rodrigo meneses
> 
>


Re: Review Request 26659: Allow different stack have different predefined site properties

Posted by rodrigo meneses <rm...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26659/
-----------------------------------------------------------

(Updated Oct. 15, 2014, 8:47 p.m.)


Review request for Ambari, jun aoki and Vitthal Gogate.


Changes
-------

Adding link to JIRA ticket with a final solution to this requirement


Bugs: AMBARI-7800
    https://issues.apache.org/jira/browse/AMBARI-7800


Repository: ambari


Description
-------

Allow different stack have different predefined site properties


Diffs
-----

  ambari-web/app/data/BIGTOP/site_properties.js PRE-CREATION 
  ambari-web/app/utils/config.js 4b26608 
  ambari-web/test/utils/config_test.js 528be46 

Diff: https://reviews.apache.org/r/26659/diff/


Testing
-------

1. Built ambari rpm
2. deploy BIGTOP stack 


Thanks,

rodrigo meneses


Re: Review Request 26659: Allow different stack have different predefined site properties

Posted by Mingjiang Shi <ms...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26659/#review56641
-----------------------------------------------------------

Ship it!


Ship It!

- Mingjiang Shi


On Oct. 13, 2014, 8:47 p.m., rodrigo meneses wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26659/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2014, 8:47 p.m.)
> 
> 
> Review request for Ambari, jun aoki and Vitthal Gogate.
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Allow different stack have different predefined site properties
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/data/BIGTOP/site_properties.js PRE-CREATION 
>   ambari-web/app/utils/config.js 4b26608 
>   ambari-web/test/utils/config_test.js 528be46 
> 
> Diff: https://reviews.apache.org/r/26659/diff/
> 
> 
> Testing
> -------
> 
> 1. Built ambari rpm
> 2. deploy BIGTOP stack 
> 
> 
> Thanks,
> 
> rodrigo meneses
> 
>


Re: Review Request 26659: Allow different stack have different predefined site properties

Posted by Ivan Wang <yi...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26659/#review56554
-----------------------------------------------------------

Ship it!


Ship It!

- Ivan Wang


On Oct. 13, 2014, 8:47 p.m., rodrigo meneses wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26659/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2014, 8:47 p.m.)
> 
> 
> Review request for Ambari, jun aoki and Vitthal Gogate.
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Allow different stack have different predefined site properties
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/data/BIGTOP/site_properties.js PRE-CREATION 
>   ambari-web/app/utils/config.js 4b26608 
>   ambari-web/test/utils/config_test.js 528be46 
> 
> Diff: https://reviews.apache.org/r/26659/diff/
> 
> 
> Testing
> -------
> 
> 1. Built ambari rpm
> 2. deploy BIGTOP stack 
> 
> 
> Thanks,
> 
> rodrigo meneses
> 
>