You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2020/08/16 00:57:09 UTC
[GitHub] [logging-log4j2] sullis opened a new pull request #401: run CI build for pull requests
sullis opened a new pull request #401:
URL: https://github.com/apache/logging-log4j2/pull/401
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] sullis commented on pull request #401: run CI build for pull requests
Posted by GitBox <gi...@apache.org>.
sullis commented on pull request #401:
URL: https://github.com/apache/logging-log4j2/pull/401#issuecomment-678815563
> Is this PR only being built then because of the config update here?
>
Yes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] jvz commented on pull request #401: run CI build for pull requests
Posted by GitBox <gi...@apache.org>.
jvz commented on pull request #401:
URL: https://github.com/apache/logging-log4j2/pull/401#issuecomment-683333181
I noticed one potential issue here which I'm not sure how to configure: PRs that are created from branches on origin (e.g., how Dependabot is configured) end up being built twice due to being pushed to a branch and a PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] jvz merged pull request #401: run CI build for pull requests
Posted by GitBox <gi...@apache.org>.
jvz merged pull request #401:
URL: https://github.com/apache/logging-log4j2/pull/401
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] jvz commented on pull request #401: run CI build for pull requests
Posted by GitBox <gi...@apache.org>.
jvz commented on pull request #401:
URL: https://github.com/apache/logging-log4j2/pull/401#issuecomment-678719464
PRs already seem to be built by default without that config setting though?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] sullis edited a comment on pull request #401: run CI build for pull requests
Posted by GitBox <gi...@apache.org>.
sullis edited a comment on pull request #401:
URL: https://github.com/apache/logging-log4j2/pull/401#issuecomment-678791217
> PRs already seem to be built by default without that config setting though?
PR 400 ( https://github.com/apache/logging-log4j2/pull/400 ) did not trigger a build.
PR 401 (this PR) triggered a build only because I added 'pull_request' to maven.yml
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] sullis commented on pull request #401: run CI build for pull requests
Posted by GitBox <gi...@apache.org>.
sullis commented on pull request #401:
URL: https://github.com/apache/logging-log4j2/pull/401#issuecomment-678791217
> PRs already seem to be built by default without that config setting though?
PR 400 ( https://github.com/apache/logging-log4j2/pull/400 ) did not trigger a build.
PR 401 (this PR) triggered a build only because I added 'pull_request' to the yaml file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] jvz commented on pull request #401: run CI build for pull requests
Posted by GitBox <gi...@apache.org>.
jvz commented on pull request #401:
URL: https://github.com/apache/logging-log4j2/pull/401#issuecomment-678800065
Is this PR only being built then because of the config update here?
BTW, our workflow is broken at the moment anyways. Hopefully we can figure it out soon, but something seems to have changed in the setup java action which isn't using the same environment variables anymore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] jvz commented on pull request #401: run CI build for pull requests
Posted by GitBox <gi...@apache.org>.
jvz commented on pull request #401:
URL: https://github.com/apache/logging-log4j2/pull/401#issuecomment-678810486
In the meantime, I've enabled Jenkins builds for PRs from collaborators at least.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org