You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Andrii Tkach <at...@hortonworks.com> on 2016/12/05 15:55:22 UTC
Review Request 54379: Host Ordered upgrade should not show as an
Upgrade option in UI
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54379/
-----------------------------------------------------------
Review request for Ambari and Aleksandr Kovalenko.
Bugs: AMBARI-19085
https://issues.apache.org/jira/browse/AMBARI-19085
Repository: ambari
Description
-------
HOU (Host Ordered Upgrade) should never be shown as an option in the UI. I was able to see this by:
Start an RU
Downgrade
Click the Upgrade button
The experimental option for enabledWizardForHostOrderedUpgrade should only be used for showing the "Upgrade Banner" clickable link, not as an option for upgrade.
For now, HOU are an API-only option.
Diffs
-----
ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js 35756cd
ambari-web/app/templates/main/admin/stack_upgrade/upgrade_options.hbs 18fcfcf
Diff: https://reviews.apache.org/r/54379/diff/
Testing
-------
19917 tests complete (27 seconds)
155 tests pending
Thanks,
Andrii Tkach
Re: Review Request 54379: Host Ordered upgrade should not show as an
Upgrade option in UI
Posted by Aleksandr Kovalenko <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54379/#review158003
-----------------------------------------------------------
Ship it!
Ship It!
- Aleksandr Kovalenko
On \u0414\u0435\u043a. 5, 2016, 3:55 \u043f.\u043f., Andrii Tkach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54379/
> -----------------------------------------------------------
>
> (Updated \u0414\u0435\u043a. 5, 2016, 3:55 \u043f.\u043f.)
>
>
> Review request for Ambari and Aleksandr Kovalenko.
>
>
> Bugs: AMBARI-19085
> https://issues.apache.org/jira/browse/AMBARI-19085
>
>
> Repository: ambari
>
>
> Description
> -------
>
> HOU (Host Ordered Upgrade) should never be shown as an option in the UI. I was able to see this by:
> Start an RU
> Downgrade
> Click the Upgrade button
> The experimental option for enabledWizardForHostOrderedUpgrade should only be used for showing the "Upgrade Banner" clickable link, not as an option for upgrade.
> For now, HOU are an API-only option.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js 35756cd
> ambari-web/app/templates/main/admin/stack_upgrade/upgrade_options.hbs 18fcfcf
>
> Diff: https://reviews.apache.org/r/54379/diff/
>
>
> Testing
> -------
>
> 19917 tests complete (27 seconds)
> 155 tests pending
>
>
> Thanks,
>
> Andrii Tkach
>
>
Re: Review Request 54379: Host Ordered upgrade should not show as an
Upgrade option in UI
Posted by Aleksandr Kovalenko <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54379/#review158138
-----------------------------------------------------------
Ship it!
Ship It!
- Aleksandr Kovalenko
On \u0414\u0435\u043a. 6, 2016, 10:22 \u0434.\u043f., Andrii Tkach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54379/
> -----------------------------------------------------------
>
> (Updated \u0414\u0435\u043a. 6, 2016, 10:22 \u0434.\u043f.)
>
>
> Review request for Ambari and Aleksandr Kovalenko.
>
>
> Bugs: AMBARI-19085
> https://issues.apache.org/jira/browse/AMBARI-19085
>
>
> Repository: ambari
>
>
> Description
> -------
>
> HOU (Host Ordered Upgrade) should never be shown as an option in the UI. I was able to see this by:
> Start an RU
> Downgrade
> Click the Upgrade button
> The experimental option for enabledWizardForHostOrderedUpgrade should only be used for showing the "Upgrade Banner" clickable link, not as an option for upgrade.
> For now, HOU are an API-only option.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js 35756cd
> ambari-web/app/templates/main/admin/stack_upgrade/upgrade_options.hbs 18fcfcf
> ambari-web/app/views/main/admin/stack_upgrade/upgrade_wizard_view.js e54a0fa
> ambari-web/test/views/main/admin/stack_upgrade/upgrade_wizard_view_test.js 5630a8c
>
> Diff: https://reviews.apache.org/r/54379/diff/
>
>
> Testing
> -------
>
> 19917 tests complete (27 seconds)
> 155 tests pending
>
>
> Thanks,
>
> Andrii Tkach
>
>
Re: Review Request 54379: Host Ordered upgrade should not show as an
Upgrade option in UI
Posted by Andrii Tkach <at...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54379/
-----------------------------------------------------------
(Updated Dec. 6, 2016, 10:22 a.m.)
Review request for Ambari and Aleksandr Kovalenko.
Bugs: AMBARI-19085
https://issues.apache.org/jira/browse/AMBARI-19085
Repository: ambari
Description
-------
HOU (Host Ordered Upgrade) should never be shown as an option in the UI. I was able to see this by:
Start an RU
Downgrade
Click the Upgrade button
The experimental option for enabledWizardForHostOrderedUpgrade should only be used for showing the "Upgrade Banner" clickable link, not as an option for upgrade.
For now, HOU are an API-only option.
Diffs (updated)
-----
ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js 35756cd
ambari-web/app/templates/main/admin/stack_upgrade/upgrade_options.hbs 18fcfcf
ambari-web/app/views/main/admin/stack_upgrade/upgrade_wizard_view.js e54a0fa
ambari-web/test/views/main/admin/stack_upgrade/upgrade_wizard_view_test.js 5630a8c
Diff: https://reviews.apache.org/r/54379/diff/
Testing
-------
19917 tests complete (27 seconds)
155 tests pending
Thanks,
Andrii Tkach