You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ju...@apache.org on 2008/10/09 23:45:54 UTC

svn commit: r703271 - /incubator/pdfbox/trunk/src/main/java/org/apache/pdfbox/pdmodel/font/PDType1Font.java

Author: jukka
Date: Thu Oct  9 14:45:54 2008
New Revision: 703271

URL: http://svn.apache.org/viewvc?rev=703271&view=rev
Log:
PDFBOX-379: PDType1Font uses the Java 5 constant Font.TYPE1

Replaced the Java 5 constant with a hardcoded copy.

Modified:
    incubator/pdfbox/trunk/src/main/java/org/apache/pdfbox/pdmodel/font/PDType1Font.java

Modified: incubator/pdfbox/trunk/src/main/java/org/apache/pdfbox/pdmodel/font/PDType1Font.java
URL: http://svn.apache.org/viewvc/incubator/pdfbox/trunk/src/main/java/org/apache/pdfbox/pdmodel/font/PDType1Font.java?rev=703271&r1=703270&r2=703271&view=diff
==============================================================================
--- incubator/pdfbox/trunk/src/main/java/org/apache/pdfbox/pdmodel/font/PDType1Font.java (original)
+++ incubator/pdfbox/trunk/src/main/java/org/apache/pdfbox/pdmodel/font/PDType1Font.java Thu Oct  9 14:45:54 2008
@@ -95,6 +95,15 @@
      */
     public static final PDType1Font ZAPF_DINGBATS = new PDType1Font( "ZapfDingbats" );
 
+    /**
+     * Hardcoded copy of the Font.TYPE1_FONT constant in Java 5. PDFBox should
+     * compile and work also with Java 1.4, so we can't rely on Java 5 features
+     * being always available. The code that uses this constant will fail
+     * gracefully if support for Type 1 fonts are not available.
+     *
+     * @see <a href="https://issues.apache.org/jira/browse/PDFBOX-379">PDFBOX-379</a>
+     */
+    private static final int TYPE1_FONT = 1;
 
     private static final Map STANDARD_14 = new HashMap();
     static
@@ -242,7 +251,7 @@
 			if( ffStream != null )
 			{
 			    try {
-					awtFont = Font.createFont( Font.TYPE1_FONT, ffStream.createInputStream() );
+					awtFont = Font.createFont( TYPE1_FONT, ffStream.createInputStream() );
 				} catch (FontFormatException e) {
 					logger().info("substituting Arial because we couldn't read the embedded Font " + fd.getFontName() );
 					awtFont = new Font( "Arial", Font.PLAIN, 1 );