[GitHub] gianm commented on a change in pull request #6068: Prohibit Lists.newArrayList() with a single argument

[GitBox <gi...@apache.org>]

gianm commented on a change in pull request #6068: Prohibit Lists.newArrayList() with a single argument
URL: https://github.com/apache/incubator-druid/pull/6068#discussion_r206212482
 
 

 ##########
 File path: indexing-service/src/main/java/io/druid/indexing/common/task/Tasks.java
 ##########
 @@ -74,7 +73,8 @@
           toBeAccumulated.add(interval);
         } else {
           compactIntervals.add(JodaUtils.umbrellaInterval(toBeAccumulated));
-          toBeAccumulated = Lists.newArrayList(interval);
+          toBeAccumulated.clear();
 
 Review comment:
   Joda Interval objects are immutable so I think this point is moot. It doesn't matter if `JodaUtils.umbrellaInterval` returns a new Interval instance or not.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org