[GitHub] rabbah opened a new pull request #3669: Stemcells

[GitBox <gi...@apache.org>]

rabbah opened a new pull request #3669: Stemcells
URL: https://github.com/apache/incubator-openwhisk/pull/3669
 
 
   ## Description
   This PR replaces #3232 and makes stem cell containers configurable from the runtime manifest. See the changes to runtimes.json for an example (or the new tests). It is possible to have multiple stem cells per runtime kind. For example:
   
   ```
   { "runtimes": {
       "node": [
         {
           "kind": "nodejs:6",
           "image": {
             "name": "nodejsaction"
           },
           "stemCells": [{
             "count": 1,
             "memory": "128 MB"
           }]
         }, {
           "kind": "nodejs:8",
           "default": true,
           "image": {
             "name": "nodejsaction"
           },
           "stemCells": [{
             "count": 1,
             "memory": "128 MB"
           }, {
             "count": 1,
             "memory": "256 MB"
           }]
         }
       ]...
   ```
   This PR improves #3232 with stricter types on the `StemCell` configuration, filters configrations for runtimes for the ones that exists to make it easier to work with stem cells in the invoker.
   
   Closes #2401.
   
   <!--- Include details of what problem you are solving and how your changes are tested. -->
   
   ## Related issue and scope
   <!--- Please include a link to a related issue if there is one. -->
   - [x] There is an open an issue to propose and discuss this change (#2401)
   
   ## My changes affect the following components
   <!--- Select below all system components are affected by your change. -->
   <!--- Enter an `x` in all applicable boxes. -->
   - [ ] API
   - [x] Controller
   - [ ] Message Bus (e.g., Kafka)
   - [ ] Loadbalancer
   - [x] Invoker
   - [ ] Intrinsic actions (e.g., sequences, conductors)
   - [ ] Data stores (e.g., CouchDB)
   - [x] Tests
   - [x] Deployment
   - [ ] CLI
   - [ ] General tooling
   - [ ] Documentation
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Use `x` in all the boxes that apply: -->
   - [ ] Bug fix (generally a non-breaking change which closes an issue).
   - [x] Enhancement or new feature (adds new functionality).
   - [x] Breaking change (a bug fix or enhancement which changes existing behavior).
   
   Labelled breaking change because it will require downstream changes to enable stem cells.
   
   It's plausible we should warn or fail startup if no stemcells are defined.
   
   ## Checklist:
   <!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. -->
   
   - [x] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md).
   - [x] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :).
   - [x] I added tests to cover my changes.
   - [ ] My changes require further changes to the documentation.
   - [x] I updated the documentation where necessary.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services