You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/08/02 05:33:17 UTC
[GitHub] [netbeans] JaroslavTulach opened a new pull request #3083: Updating the HTML/Java project template to work with Gradle 7.0
JaroslavTulach opened a new pull request #3083:
URL: https://github.com/apache/netbeans/pull/3083
Pull request #2999 had to fix the version of Gradle for HTML/Java project template 6.9 due to incompatibilities in retrolamda plugin. Updating the project template to work on Gradle 7.x by [removing the need of retrolamda](http://wiki.apidesign.org/wiki/RetroLambda).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #3083: Updating the Java Frontend project template to work with Gradle 7.0
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #3083:
URL: https://github.com/apache/netbeans/pull/3083#issuecomment-894665680
Yes, that sounds about right. Needs care.
Delivery -> master sync PRs are usually done immediately after each beta and release - ie. sync delivery to release, check build, sync delivery to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on pull request #3083: Updating the Java Frontend project template to work with Gradle 7.0
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on pull request #3083:
URL: https://github.com/apache/netbeans/pull/3083#issuecomment-894940981
> I would expect this to go cleanly, if the commit is merged (cleanly) with `git cherry-pick`.
Backported the commit as 0728145 and added few commits on top of it. Hopefully the merge of `delivery` to `master` will be smooth.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #3083: Updating the Java Frontend project template to work with Gradle 7.0
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #3083:
URL: https://github.com/apache/netbeans/pull/3083#issuecomment-894661962
I would expect this to go cleanly, if the commit is merged (cleanly) with `git cherry-pick`. As long as there are no conflicting changes in both branches this should be save. If `delivery` is merged shortly (IMHO delivery -> master merges can be done pretty much immediately) this should be handable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on pull request #3083: Updating the Java Frontend project template to work with Gradle 7.0
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on pull request #3083:
URL: https://github.com/apache/netbeans/pull/3083#issuecomment-894604001
Opps, 12.6!? This fix should rather go into 12.5! I guess I prepare one more PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net edited a comment on pull request #3083: Updating the Java Frontend project template to work with Gradle 7.0
Posted by GitBox <gi...@apache.org>.
neilcsmith-net edited a comment on pull request #3083:
URL: https://github.com/apache/netbeans/pull/3083#issuecomment-894665680
Yes, that sounds about right. Just needs a little care.
Delivery -> master sync PRs are usually done immediately after each beta and release - ie. sync delivery to release, check build, sync delivery to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on a change in pull request #3083: Updating the Java Frontend project template to work with Gradle 7.0
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on a change in pull request #3083:
URL: https://github.com/apache/netbeans/pull/3083#discussion_r680686285
##########
File path: java/gradle.htmlui/src/org/netbeans/modules/gradle/htmlui/resources/root_build.gradle.fmk
##########
@@ -18,15 +18,14 @@
under the License.
-->
-<#noparse>
-plugins {
- id "me.tatarka.retrolambda" version "3.7.1"
Review comment:
Just out of curiosity, is retrolambda no longer required?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach merged pull request #3083: Updating the Java Frontend project template to work with Gradle 7.0
Posted by GitBox <gi...@apache.org>.
JaroslavTulach merged pull request #3083:
URL: https://github.com/apache/netbeans/pull/3083
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #3083: Updating the Java Frontend project template to work with Gradle 7.0
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #3083:
URL: https://github.com/apache/netbeans/pull/3083#discussion_r680690351
##########
File path: java/gradle.htmlui/src/org/netbeans/modules/gradle/htmlui/resources/root_build.gradle.fmk
##########
@@ -18,15 +18,14 @@
under the License.
-->
-<#noparse>
-plugins {
- id "me.tatarka.retrolambda" version "3.7.1"
Review comment:
Right, [retrolambda is no longer required](http://wiki.apidesign.org/wiki/Bck2Brwsr#Version_0.50).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #3083: Updating the Java Frontend project template to work with Gradle 7.0
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #3083:
URL: https://github.com/apache/netbeans/pull/3083#issuecomment-894614711
A PR could make syncing delivery to master difficult for @ebarboni If this needs to be in 12.5 then some git-fu may be required?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists