You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@perl.apache.org by Steve Hay <st...@uk.radan.com> on 2004/07/08 10:11:04 UTC
ModPerl-Registry t/basic.t crashes Apache
All is not quite well with the current CVS mp2 tests -- the
ModPerl-Registry tests fail from t/basic.t onwards.
It seems that this test is now crashing Apache.exe. It can be
reproduced in isolation. Here's a stack trace:
Perl_sv_unmagic(interpreter * 0x013b237c, sv * 0x00000000, int 99) line
4822 + 3 bytes
Perl_Gv_AMupdate(interpreter * 0x013b237c, hv * 0x00000000) line 1310
Perl_sv_bless(interpreter * 0x013b237c, sv * 0x0150f450, hv *
0x00000000) line 7871 + 16 bytes
modperl_croak(interpreter * 0x00000000, int 120000, const char *
0x10017f38 `string') line 68 + 34 bytes
modperl_perl_exit(interpreter * 0x013b237c, int 0) line 484 + 16 bytes
XS_ModPerl__Util_exit(interpreter * 0x280407c3, cv * 0x013b237c) line 84
Perl_pp_entersub(interpreter * 0x013b237c) line 2857
Perl_runops_standard(interpreter * 0x013b237c) line 25 + 45 bytes
S_call_body(interpreter * 0x013b237c, op * 0x0296fdb4, int 0) line 2285
+ 7 bytes
Perl_call_sv(interpreter * 0x013b237c, sv * 0x0150f618, long 4) line
2224 + 13 bytes
modperl_callback(interpreter * 0x013b237c, modperl_handler_t *
0x00874118, apr_pool_t * 0x01f48f10, request_rec * 0x01f48f48,
server_rec * 0x0026c6b0, av * 0x01f40920) line 101
modperl_callback_run_handlers(int 6, int 4, request_rec * 0x01f48f48,
conn_rec * 0x00000000, server_rec * 0x0026c6b0, apr_pool_t * 0x00000000,
apr_pool_t * 0x00000000, apr_pool_t * 0x00000000, int 1) line 268 + 21 bytes
modperl_callback_per_dir(int 6, request_rec * 0x01f48f48, int 1) line
358 + 29 bytes
modperl_response_handler_run(request_rec * 0x01f48f48, int 0) line 877 +
10 bytes
modperl_response_handler_cgi(request_rec * 0x01f49b70) line 974
ap_run_handler(request_rec * 0x01f48f48) line 152 + 31 bytes
ap_invoke_handler(request_rec * 0x6ff09416) line 362
ap_process_http_connection(conn_rec * 0x6ff040ff) line 250 + 6 bytes
ap_run_process_connection(conn_rec * 0x01f43000) line 42 + 31 bytes
ap_process_connection(conn_rec * 0x01f43000, void * 0x01f42f30) line 175
+ 6 bytes
worker_main(long 2009300920) line 718
MSVCRT! 77c37fb8()
It crashed right at the start of Perl_sv_unmagic(), on this line:
if (SvTYPE(sv) < SVt_PVMG || !SvMAGIC(sv))
Error was "Access Violation" because sv is actually NULL.
Presumably this is caused by the workaround to the in_error.t test
failure? (stash in modperl_croak() was also NULL.)
- Steve
------------------------------------------------
Radan Computational Ltd.
The information contained in this message and any files transmitted with it are confidential and intended for the addressee(s) only. If you have received this message in error or there are any problems, please notify the sender immediately. The unauthorized use, disclosure, copying or alteration of this message is strictly forbidden. Note that any views or opinions presented in this email are solely those of the author and do not necessarily represent those of Radan Computational Ltd. The recipient(s) of this message should check it and any attached files for viruses: Radan Computational will accept no liability for any damage caused by any virus transmitted by this email.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: ModPerl-Registry t/basic.t crashes Apache
Posted by Stas Bekman <st...@stason.org>.
Philippe M. Chiasson wrote:
[...]
>> Philippe, where are you with this $bb->cleanup issue?
>
>
> Well, things are indeed strange. I've just updated httpd an hour ago and I
> can still reproduce the problem here, on my work machine. At home, on my
> other almost identical linux box (both Fedora Core 2), I can't get it to
> happen. Very strange indeed. The current stacktrace I get is exactly the
> same, and the corrupted memory values are still the same.
>
> (gdb) print *b
> $1 = {p = 0x8512858, list = {next = 0x1, prev = 0x1011007}, bucket_alloc
> = 0x861cd28}
> (gdb) print *(b->bucket_alloc)
> $2 = {pool = 0x0, allocator = 0x0, freelist = 0x0, blocks = 0x0}
> (gdb) print *(b->p)
> $3 = {parent = 0x8681394, child = 0x8, sibling = 0x13, ref = 0xb,
> cleanups = 0x58, allocator = 0xff1,
> subprocesses = 0xc3a5e50, abort_fn = 0xc3a3dd8, user_data = 0x0, tag =
> 0x0, nodes = 0xa84bdb4,
> file_line = 0xc3a4964 <Address 0xc3a4964 out of bounds>,
> creation_flags = 32, stat_alloc = 0,
> stat_total_alloc = 176471476, stat_clear = 205146472, owner = 64,
> mutex = 0x0}
>
> The bucket allocator exists, but seems to be NULLed, and that can't be a
> good sign.
> The pool in the bb also looks somewhat corrupted.
>
> Apart from this, I don't quite have the time to trace thru this at this
> time.
>
> Thoughts ?
It's hard to tell anything w/o being able to reproduce the problem.
For now I've committed the slower implementation, which doesn't call
cleanup().
If you get time later on to trace it please do so, thanks!
--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: ModPerl-Registry t/basic.t crashes Apache
Posted by "Philippe M. Chiasson" <go...@ectoplasm.org>.
Stas Bekman wrote:
> Randy Kobes wrote:
>
>>On Mon, 12 Jul 2004, Stas Bekman wrote:
>>
>>
>>
>>>Randy Kobes wrote:
>>>
>>>
>>>
>>>>I still have it crashing ...
>>>
>>>Please try the following 3 variations (the first one should certainly
>>>work as it doesn't call cleanup).
>>
>>
>>Unfortunately, only the 1st one works for me ... The 2nd one
>>crashes after completing two tests, and the 3rd one after
>>one test.
>
>
> That's what I thought. But I really need to be able to reproduce it to
> be able to find out what the problem is :(
>
> Philippe, where are you with this $bb->cleanup issue?
Well, things are indeed strange. I've just updated httpd an hour ago and I
can still reproduce the problem here, on my work machine. At home, on my
other almost identical linux box (both Fedora Core 2), I can't get it to
happen. Very strange indeed. The current stacktrace I get is exactly the
same, and the corrupted memory values are still the same.
(gdb) print *b
$1 = {p = 0x8512858, list = {next = 0x1, prev = 0x1011007}, bucket_alloc = 0x861cd28}
(gdb) print *(b->bucket_alloc)
$2 = {pool = 0x0, allocator = 0x0, freelist = 0x0, blocks = 0x0}
(gdb) print *(b->p)
$3 = {parent = 0x8681394, child = 0x8, sibling = 0x13, ref = 0xb, cleanups = 0x58, allocator = 0xff1,
subprocesses = 0xc3a5e50, abort_fn = 0xc3a3dd8, user_data = 0x0, tag = 0x0, nodes = 0xa84bdb4,
file_line = 0xc3a4964 <Address 0xc3a4964 out of bounds>, creation_flags = 32, stat_alloc = 0,
stat_total_alloc = 176471476, stat_clear = 205146472, owner = 64, mutex = 0x0}
The bucket allocator exists, but seems to be NULLed, and that can't be a good sign.
The pool in the bb also looks somewhat corrupted.
Apart from this, I don't quite have the time to trace thru this at this time.
Thoughts ?
>
>>>BTW, didn't we also have a problem with ARP::Pool::cleanup on win32? I
>>>remember disabling those tests, as I couldn't reproduce it on my
>>>machine. It seems to be related.
>>
>>
>>Yes, we did - there's a block of tests in TestAPR/pool.pm
>>that are commented out. I just tried these, and now they
>>all pass for me! So I guess we can re-enable them?
>
>
> Can you check your original report and see whether you now have a
> different setup? I don't think I've changed anything around APR::Pool,
> so if it suddenly started to work, it's not a good sign.
>
>
>>Actually,
>>it might be interesting to see if Philippe (who also
>>had difficulty with the echo_bbs2 tests) has any problem
>>with these re-enabled pool tests.
Nope, on this system :
Failed Test Stat Wstat Total Fail Failed List of Failed
-------------------------------------------------------------------------------
t/protocol/echo_bbs2.t 3 2 66.67% 2-3
2 tests skipped.
Failed 1/188 test scripts, 99.47% okay. 2/1261 subtests failed, 99.84% okay.
>
> Yeah, Philippe, can you help us here? Or help me reproduce the segfaults?
>
--
--------------------------------------------------------------------------------
Philippe M. Chiasson m/gozer\@(apache|cpan|ectoplasm)\.org/ GPG KeyID : 88C3A5A5
http://gozer.ectoplasm.org/ F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3A5A5
Re: ModPerl-Registry t/basic.t crashes Apache
Posted by Stas Bekman <st...@stason.org>.
Randy Kobes wrote:
> On Tue, 13 Jul 2004, Stas Bekman wrote:
>
>
>>Randy Kobes wrote:
>
> [ ... ]
>
>>> there's a block of tests in TestAPR/pool.pm
>>>that are commented out. I just tried these, and now they
>>>all pass for me! So I guess we can re-enable them?
>>
>>Can you check your original report and see whether you now
>>have a different setup? I don't think I've changed
>>anything around APR::Pool, so if it suddenly started to
>>work, it's not a good sign.
>
>
> I should have checked the archives first ... This problem
> with the pools arose from a problem around May 24, 2004,
> where compat/send_fd and directive/setupenv were failing
> when ran after apr/pool (all were fine in isolation).
> Commenting out the stuff in apr/pool allowed the other tests
> to pass. This situation hasn't changed with the current cvs
> - apr/pool, compat_send_fd, and directive_setupenv all run
> fine in isolation, with or without that section in pool.pm
> commented out, but if one uncomments those tests in pool.pm,
> then
> perl t/TEST apr/pool compat/send_fd
> perl t/TEST apr/pool directive/setupenv
> fail - the message returned being
> response had protocol HTTP/0.9 (headers not sent?)
Thank's Randy. It's good that it's still broken (consistency :)
could you please add that explanation to that pool.pm test? thanks.
--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: ModPerl-Registry t/basic.t crashes Apache
Posted by Randy Kobes <ra...@theoryx5.uwinnipeg.ca>.
On Tue, 13 Jul 2004, Stas Bekman wrote:
> Randy Kobes wrote:
[ ... ]
> > there's a block of tests in TestAPR/pool.pm
> > that are commented out. I just tried these, and now they
> > all pass for me! So I guess we can re-enable them?
>
> Can you check your original report and see whether you now
> have a different setup? I don't think I've changed
> anything around APR::Pool, so if it suddenly started to
> work, it's not a good sign.
I should have checked the archives first ... This problem
with the pools arose from a problem around May 24, 2004,
where compat/send_fd and directive/setupenv were failing
when ran after apr/pool (all were fine in isolation).
Commenting out the stuff in apr/pool allowed the other tests
to pass. This situation hasn't changed with the current cvs
- apr/pool, compat_send_fd, and directive_setupenv all run
fine in isolation, with or without that section in pool.pm
commented out, but if one uncomments those tests in pool.pm,
then
perl t/TEST apr/pool compat/send_fd
perl t/TEST apr/pool directive/setupenv
fail - the message returned being
response had protocol HTTP/0.9 (headers not sent?)
--
best regards,
randy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: ModPerl-Registry t/basic.t crashes Apache
Posted by Stas Bekman <st...@stason.org>.
Randy Kobes wrote:
> On Mon, 12 Jul 2004, Stas Bekman wrote:
>
>
>>Randy Kobes wrote:
>>
>>
>>>I still have it crashing ...
>>
>>Please try the following 3 variations (the first one should certainly
>>work as it doesn't call cleanup).
>
>
> Unfortunately, only the 1st one works for me ... The 2nd one
> crashes after completing two tests, and the 3rd one after
> one test.
That's what I thought. But I really need to be able to reproduce it to
be able to find out what the problem is :(
Philippe, where are you with this $bb->cleanup issue?
>>BTW, didn't we also have a problem with ARP::Pool::cleanup on win32? I
>>remember disabling those tests, as I couldn't reproduce it on my
>>machine. It seems to be related.
>
>
> Yes, we did - there's a block of tests in TestAPR/pool.pm
> that are commented out. I just tried these, and now they
> all pass for me! So I guess we can re-enable them?
Can you check your original report and see whether you now have a
different setup? I don't think I've changed anything around APR::Pool,
so if it suddenly started to work, it's not a good sign.
> Actually,
> it might be interesting to see if Philippe (who also
> had difficulty with the echo_bbs2 tests) has any problem
> with these re-enabled pool tests.
Yeah, Philippe, can you help us here? Or help me reproduce the segfaults?
--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: ModPerl-Registry t/basic.t crashes Apache
Posted by Randy Kobes <ra...@theoryx5.uwinnipeg.ca>.
On Mon, 12 Jul 2004, Stas Bekman wrote:
> Randy Kobes wrote:
>
> > I still have it crashing ...
>
> Please try the following 3 variations (the first one should certainly
> work as it doesn't call cleanup).
Unfortunately, only the 1st one works for me ... The 2nd one
crashes after completing two tests, and the 3rd one after
one test.
> BTW, didn't we also have a problem with ARP::Pool::cleanup on win32? I
> remember disabling those tests, as I couldn't reproduce it on my
> machine. It seems to be related.
Yes, we did - there's a block of tests in TestAPR/pool.pm
that are commented out. I just tried these, and now they
all pass for me! So I guess we can re-enable them? Actually,
it might be interesting to see if Philippe (who also
had difficulty with the echo_bbs2 tests) has any problem
with these re-enabled pool tests.
--
best regards,
randy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: ModPerl-Registry t/basic.t crashes Apache
Posted by Stas Bekman <st...@stason.org>.
Randy Kobes wrote:
> I still have it crashing ...
Please try the following 3 variations (the first one should certainly
work as it doesn't call cleanup).
BTW, didn't we also have a problem with ARP::Pool::cleanup on win32? I
remember disabling those tests, as I couldn't reproduce it on my
machine. It seems to be related.
package TestProtocol::echo_bbs2;
# similar to TestProtocol::echo_bbs but here re-using one bucket
# brigade for input and output, using flatten to slurp all the data in
# the bucket brigade, and cleanup to get rid of the old buckets
use strict;
use warnings FATAL => 'all';
use Apache::Connection ();
use APR::Socket ();
use APR::Bucket ();
use APR::Brigade ();
use APR::Error ();
use Apache::Const -compile => qw(OK MODE_GETLINE);
use APR::Const -compile => qw(SUCCESS EOF SO_NONBLOCK);
sub handler {
my $c = shift;
# starting from Apache 2.0.49 several platforms require you to set
# the socket to a blocking IO mode
$c->client_socket->opt_set(APR::SO_NONBLOCK, 0);
my $last = 0;
while (1) {
my $bb_in = APR::Brigade->new($c->pool, $c->bucket_alloc);
my $bb_out = APR::Brigade->new($c->pool, $c->bucket_alloc);
my $rc = $c->input_filters->get_brigade($bb_in,
Apache::MODE_GETLINE);
last if $rc == APR::EOF;
die APR::Error::strerror($rc) unless $rc == APR::SUCCESS;
next unless $bb_in->flatten(my $data);
#warn "read: [$data]\n";
last if $data =~ /^[\r\n]+$/;
# transform data here
my $bucket = APR::Bucket->new(uc $data);
$bb_out->insert_tail($bucket);
$c->output_filters->fflush($bb_out);
# XXX: add DESTROY and remove explicit calls
$bb_in->destroy;
$bb_out->destroy;
}
Apache::OK;
}
1;
and a faster one:
package TestProtocol::echo_bbs2;
# similar to TestProtocol::echo_bbs but here re-using one bucket
# brigade for input and output, using flatten to slurp all the data in
# the bucket brigade, and cleanup to get rid of the old buckets
use strict;
use warnings FATAL => 'all';
use Apache::Connection ();
use APR::Socket ();
use APR::Bucket ();
use APR::Brigade ();
use APR::Error ();
use Apache::Const -compile => qw(OK MODE_GETLINE);
use APR::Const -compile => qw(SUCCESS EOF SO_NONBLOCK);
sub handler {
my $c = shift;
# starting from Apache 2.0.49 several platforms require you to set
# the socket to a blocking IO mode
$c->client_socket->opt_set(APR::SO_NONBLOCK, 0);
my $bb_in = APR::Brigade->new($c->pool, $c->bucket_alloc);
my $last = 0;
while (1) {
my $bb_out = APR::Brigade->new($c->pool, $c->bucket_alloc);
my $rc = $c->input_filters->get_brigade($bb_in,
Apache::MODE_GETLINE);
last if $rc == APR::EOF;
die APR::Error::strerror($rc) unless $rc == APR::SUCCESS;
next unless $bb_in->flatten(my $data);
#warn "read: [$data]\n";
last if $data =~ /^[\r\n]+$/;
$bb_in->cleanup;
# transform data here
my $bucket = APR::Bucket->new(uc $data);
$bb_out->insert_tail($bucket);
$c->output_filters->fflush($bb_out);
# XXX: add DESTROY and remove explicit calls
$bb_out->destroy;
}
$bb_in->destroy;
Apache::OK;
}
1;
and one more:
package TestProtocol::echo_bbs2;
# similar to TestProtocol::echo_bbs but here re-using one bucket
# brigade for input and output, using flatten to slurp all the data in
# the bucket brigade, and cleanup to get rid of the old buckets
use strict;
use warnings FATAL => 'all';
use Apache::Connection ();
use APR::Socket ();
use APR::Bucket ();
use APR::Brigade ();
use APR::Error ();
use Apache::Const -compile => qw(OK MODE_GETLINE);
use APR::Const -compile => qw(SUCCESS EOF SO_NONBLOCK);
sub handler {
my $c = shift;
# starting from Apache 2.0.49 several platforms require you to set
# the socket to a blocking IO mode
$c->client_socket->opt_set(APR::SO_NONBLOCK, 0);
my $bb_in = APR::Brigade->new($c->pool, $c->bucket_alloc);
my $bb_out = APR::Brigade->new($c->pool, $c->bucket_alloc);
my $last = 0;
while (1) {
my $rc = $c->input_filters->get_brigade($bb_in,
Apache::MODE_GETLINE);
last if $rc == APR::EOF;
die APR::Error::strerror($rc) unless $rc == APR::SUCCESS;
next unless $bb_in->flatten(my $data);
#warn "read: [$data]\n";
last if $data =~ /^[\r\n]+$/;
# transform data here
my $bucket = APR::Bucket->new(uc $data);
$bb_out->insert_tail($bucket);
$c->output_filters->fflush($bb_out);
$bb_in->cleanup;
$bb_out->cleanup;
}
# XXX: add DESTROY and remove explicit calls
$bb_in->destroy;
$bb_out->destroy;
Apache::OK;
}
1;
--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: ModPerl-Registry t/basic.t crashes Apache
Posted by Randy Kobes <ra...@theoryx5.uwinnipeg.ca>.
On Mon, 12 Jul 2004, Steve Hay wrote:
> Randy Kobes wrote:
[ .. ]
> >I compiled my perl too, although using the sources
> >ActiveState provides (for build 810, based on 5.8.4).
> >
> Are you distributing your Perl build in any way?
>
> If you are, then I think you have to hack around the
> ActivePerl source to remove all mention of ActivePerl and
> ActiveState or else get a redistribution agreement with
> them - you aren't allowed to distribute something calling
> itself ActivePerl otherwise. I had a discussion with Jan
> Dubois about this a while ago. I have the mails somewhere
> if you're interested.
>
> Here at Radan we distribute our Perl build with our software, and went
> through a phase of using the ActivePerl sources, suitably hacked to
> remove the Active* name. (At the time that consisted of deleting
> BuildInfo.h, editing perlexe.rc and perldll.rc, and removing
> BuildNumber() from win32/win32.c.) Now that the standard Perl is coming
> out much more frequently itself (and recently there has only been one
> ActivePerl release per Perl release), we don't bother any more and
> currently just use the standard Perl source.
Thanks, Steve - I would be interested in seeing those emails
with Jan, if they're handy.
I am distributing a Perl/Apache binary through
www.apache.org, with Perl built with the ActivePerl sources.
I didn't go to the extent that you did though in doing this;
I just modified BuildInfo.h to read
"based on sources provided by ActiveState ..."
I had thought, based on
http://aspn.activestate.com/ASPN/docs/ActivePerl/Copyright.html
saying that the source code for the modified Perl
distribution used in ActivePerl is distributed under the
same terms as Perl itself, that this was OK. There are
additional proprietary modules contained in the ActivePerl
binary package that aren't in these sources (doc building
tools, ppm, ...), but I'm not including these in the binary
I make (the ppm package I use is an older one from CPAN).
However, it doesn't sound too difficult to do what you
did - I certainly don't want to risk souring our good
relations with ActiveState (however, I suppose some
notice must appear somewhere that the binary is made
based on modified sources?)
I agree that the need for using the ActivePerl sources is
becoming less as Perl's release cycle is more frequent. Even
so, I'll probably still use the ActivePerl sources, as they
change the defaults in the build to define NO_HASH_SEED, and
related stuff - this is useful for binary compatibility
(within 5.8.x) for ppm packages compatible with ActivePerl
(particularly mod_perl).
--
best regards,
randy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: ModPerl-Registry t/basic.t crashes Apache
Posted by Steve Hay <st...@uk.radan.com>.
Randy Kobes wrote:
>On Mon, 12 Jul 2004, Steve Hay wrote:
>
>
>
>>Randy Kobes wrote:
>>
>>
>[ .. ]
>
>
>>>Steve, is your Perl similar to mine?
>>>
>>>
>>>
>>Certainly is (although I built mine myself, rather than using
>>ActivePerl), so perhaps 2.0.50 is what makes the difference? I'll see
>>if I can find time to try it soon.
>>
>>
>
>I compiled my perl too, although using the sources
>ActiveState provides (for build 810, based on 5.8.4).
>
Are you distributing your Perl build in any way?
If you are, then I think you have to hack around the ActivePerl source
to remove all mention of ActivePerl and ActiveState or else get a
redistribution agreement with them - you aren't allowed to distribute
something calling itself ActivePerl otherwise. I had a discussion with
Jan Dubois about this a while ago. I have the mails somewhere if you're
interested.
Here at Radan we distribute our Perl build with our software, and went
through a phase of using the ActivePerl sources, suitably hacked to
remove the Active* name. (At the time that consisted of deleting
BuildInfo.h, editing perlexe.rc and perldll.rc, and removing
BuildNumber() from win32/win32.c.) Now that the standard Perl is coming
out much more frequently itself (and recently there has only been one
ActivePerl release per Perl release), we don't bother any more and
currently just use the standard Perl source.
- Steve
------------------------------------------------
Radan Computational Ltd.
The information contained in this message and any files transmitted with it are confidential and intended for the addressee(s) only. If you have received this message in error or there are any problems, please notify the sender immediately. The unauthorized use, disclosure, copying or alteration of this message is strictly forbidden. Note that any views or opinions presented in this email are solely those of the author and do not necessarily represent those of Radan Computational Ltd. The recipient(s) of this message should check it and any attached files for viruses: Radan Computational will accept no liability for any damage caused by any virus transmitted by this email.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: ModPerl-Registry t/basic.t crashes Apache
Posted by Randy Kobes <ra...@theoryx5.uwinnipeg.ca>.
On Mon, 12 Jul 2004, Steve Hay wrote:
> Randy Kobes wrote:
[ .. ]
> >Steve, is your Perl similar to mine?
> >
> Certainly is (although I built mine myself, rather than using
> ActivePerl), so perhaps 2.0.50 is what makes the difference? I'll see
> if I can find time to try it soon.
I compiled my perl too, although using the sources
ActiveState provides (for build 810, based on 5.8.4). This
contains (in principle) some additional changes over the
CPAN Perl sources, although these generally have been
"approved", and will appear in the next release of Perl. One
difference the ActiveState sources has is that NO_HASH_SEED
is defined, but that probably isn't relevant for this
problem?
My Apache/2.0.50 I compiled from the released sources.
--
best regards,
randy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: ModPerl-Registry t/basic.t crashes Apache
Posted by Steve Hay <st...@uk.radan.com>.
Randy Kobes wrote:
>On Mon, 12 Jul 2004, Stas Bekman wrote:
>
>
>
>>>No, no change - I still get it crashing (perl-5.8.4,
>>>Apache/2.0.50, Win32).
>>>
>>>
>>Thanks for testing, Randy and Steve. How about this patch:
>>
>>
>I still have it crashing ... This is with Apache/2.0.50 -
>Steve, is your Perl similar to mine?
>
Certainly is (although I built mine myself, rather than using
ActivePerl), so perhaps 2.0.50 is what makes the difference? I'll see
if I can find time to try it soon.
- Steve
Summary of my perl5 (revision 5 version 8 subversion 4) configuration:
Platform:
osname=MSWin32, osvers=4.0, archname=MSWin32-x86-multi-thread
uname=''
config_args='undef'
hint=recommended, useposix=true, d_sigaction=undef
usethreads=undef use5005threads=undef useithreads=define
usemultiplicity=define
useperlio=define d_sfio=undef uselargefiles=define usesocks=undef
use64bitint=undef use64bitall=undef uselongdouble=undef
usemymalloc=n, bincompat5005=undef
Compiler:
cc='cl', ccflags ='-nologo -Gf -W3 -MD -Zi -DNDEBUG -O1 -DWIN32
-D_CONSOLE -DNO_STRICT -DHAVE_DES_FCRYPT -DPERL_IMPLICIT_CONTEXT
-DPERL_IMPLICIT_SYS -DUSE_PERLIO -DPERL_MSVCRT_READFIX',
optimize='-MD -Zi -DNDEBUG -O1',
cppflags='-DWIN32'
ccversion='', gccversion='', gccosandvers=''
intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=1234
d_longlong=undef, longlongsize=8, d_longdbl=define, longdblsize=10
ivtype='long', ivsize=4, nvtype='double', nvsize=8, Off_t='__int64',
lseeksize=8
alignbytes=8, prototype=define
Linker and Libraries:
ld='link', ldflags ='-nologo -nodefaultlib -debug -opt:ref,icf
-libpath:"C:\apache2\perl5\lib\CORE" -machine:x86'
libpth=C:\PROGRA~1\MICROS~2\VC98\lib
libs= oldnames.lib kernel32.lib user32.lib gdi32.lib winspool.lib
comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib
netapi32.lib uuid.lib wsock32.lib mpr.lib winmm.lib version.lib
odbc32.lib odbccp32.lib msvcrt.lib
perllibs= oldnames.lib kernel32.lib user32.lib gdi32.lib
winspool.lib comdlg32.lib advapi32.lib shell32.lib ole32.lib
oleaut32.lib netapi32.lib uuid.lib wsock32.lib mpr.lib winmm.lib
version.lib odbc32.lib odbccp32.lib msvcrt.lib
libc=msvcrt.lib, so=dll, useshrplib=yes, libperl=perl58.lib
gnulibc_version='undef'
Dynamic Linking:
dlsrc=dl_win32.xs, dlext=dll, d_dlsymun=undef, ccdlflags=' '
cccdlflags=' ', lddlflags='-dll -nologo -nodefaultlib -debug
-opt:ref,icf -libpath:"C:\apache2\perl5\lib\CORE" -machine:x86'
Characteristics of this binary (from libperl):
Compile-time options: MULTIPLICITY USE_ITHREADS USE_LARGE_FILES
PERL_IMPLICIT_CONTEXT PERL_IMPLICIT_SYS
Built under MSWin32
Compiled at Apr 28 2004 14:21:31
@INC:
C:/apache2/perl5/lib
C:/apache2/perl5/site/lib
.
------------------------------------------------
Radan Computational Ltd.
The information contained in this message and any files transmitted with it are confidential and intended for the addressee(s) only. If you have received this message in error or there are any problems, please notify the sender immediately. The unauthorized use, disclosure, copying or alteration of this message is strictly forbidden. Note that any views or opinions presented in this email are solely those of the author and do not necessarily represent those of Radan Computational Ltd. The recipient(s) of this message should check it and any attached files for viruses: Radan Computational will accept no liability for any damage caused by any virus transmitted by this email.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: ModPerl-Registry t/basic.t crashes Apache
Posted by Randy Kobes <ra...@theoryx5.uwinnipeg.ca>.
On Mon, 12 Jul 2004, Stas Bekman wrote:
> > No, no change - I still get it crashing (perl-5.8.4,
> > Apache/2.0.50, Win32).
>
> Thanks for testing, Randy and Steve. How about this patch:
>
> Index: t/protocol/TestProtocol/echo_bbs2.pm
> ===================================================================
> RCS file: /home/cvs/modperl-2.0/t/protocol/TestProtocol/echo_bbs2.pm,v
> retrieving revision 1.5
> diff -u -r1.5 echo_bbs2.pm
> --- t/protocol/TestProtocol/echo_bbs2.pm 1 Jul 2004 02:01:21 -0000 1.5
> +++ t/protocol/TestProtocol/echo_bbs2.pm 12 Jul 2004 08:12:14 -0000
> @@ -27,16 +27,14 @@
>
> my $last = 0;
> while (1) {
> - my $bb_in = APR::Brigade->new($c->pool, $c->bucket_alloc);
> - my $rc = $c->input_filters->get_brigade($bb_in,
> + my $rc = $c->input_filters->get_brigade($bb,
> Apache::MODE_GETLINE);
> last if $rc == APR::EOF;
> die APR::Error::strerror($rc) unless $rc == APR::SUCCESS;
>
> - next unless $bb_in->flatten(my $data);
> - $bb->cleanup;
> - #warn "read: [$data]\n";
> + next unless $bb->flatten(my $data);
> last if $data =~ /^[\r\n]+$/;
> + $bb->cleanup;
>
> # transform data here
> my $bucket = APR::Bucket->new(uc $data);
> @@ -45,6 +43,7 @@
> $c->output_filters->fflush($bb);
> }
>
> + # XXX: add DESTROY and remove explicit calls
> $bb->destroy;
>
> Apache::OK;
I still have it crashing ... This is with Apache/2.0.50 -
Steve, is your Perl similar to mine?
Summary of my perl5 (revision 5 version 8 subversion 4) configuration:
Platform:
osname=MSWin32, osvers=4.0, archname=MSWin32-x86-multi-thread
uname=''
config_args='undef'
hint=recommended, useposix=true, d_sigaction=undef
usethreads=undef use5005threads=undef useithreads=define usemultiplicity=define
useperlio=define d_sfio=undef uselargefiles=define usesocks=undef
use64bitint=undef use64bitall=undef uselongdouble=undef
usemymalloc=n, bincompat5005=undef
Compiler:
cc='cl', ccflags ='-nologo -Gf -W3 -MD -DNDEBUG -O1 -DWIN32 -D_CONSOLE -DNO_STRICT -DHAVE_DES_FCRYPT -DNO_HASH_SEED -DPERL_IMPLICIT_CONTEXT -DPERL_IMPLICIT_SYS -DUSE_PERLIO -DPERL_MSVCRT_READFIX',
optimize='-MD -DNDEBUG -O1',
cppflags='-DWIN32'
ccversion='', gccversion='', gccosandvers=''
intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=1234
d_longlong=undef, longlongsize=8, d_longdbl=define, longdblsize=10
ivtype='long', ivsize=4, nvtype='double', nvsize=8, Off_t='__int64', lseeksize=8
alignbytes=8, prototype=define
Linker and Libraries:
ld='link', ldflags ='-nologo -nodefaultlib -release -libpath:"D:\Perl\lib\CORE" -machine:x86'
libpth=\lib
libs= oldnames.lib kernel32.lib user32.lib gdi32.lib winspool.lib comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib netapi32.lib uuid.lib wsock32.lib mpr.lib winmm.lib version.lib odbc32.lib odbccp32.lib msvcrt.lib
perllibs= oldnames.lib kernel32.lib user32.lib gdi32.lib winspool.lib comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib netapi32.lib uuid.lib wsock32.lib mpr.lib winmm.lib version.lib odbc32.lib odbccp32.lib msvcrt.lib
libc=msvcrt.lib, so=dll, useshrplib=yes, libperl=perl58.lib
gnulibc_version='undef'
Dynamic Linking:
dlsrc=dl_win32.xs, dlext=dll, d_dlsymun=undef, ccdlflags=' '
cccdlflags=' ', lddlflags='-dll -nologo -nodefaultlib -release -libpath:"D:\Perl\lib\CORE" -machine:x86'
Characteristics of this binary (from libperl):
Compile-time options: MULTIPLICITY USE_ITHREADS USE_LARGE_FILES PERL_IMPLICIT_CONTEXT PERL_IMPLICIT_SYS
Locally applied patches:
ActivePerl Build 810
22751 Update to Test.pm 1.25
21540 Fix backward-compatibility issues in if.pm
Built under MSWin32
Compiled at Jun 17 2004 21:47:33
@INC:
D:/Perl/lib
D:/Perl/site/lib
.
--
best regards,
randy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: ModPerl-Registry t/basic.t crashes Apache
Posted by Steve Hay <st...@uk.radan.com>.
Stas Bekman wrote:
>>No, no change - I still get it crashing (perl-5.8.4,
>>Apache/2.0.50, Win32).
>>
>>
>
>Thanks for testing, Randy and Steve. How about this patch:
>
Works fine for me -- all tests OK (main testsuite and MP-R testsuite),
but I never saw any failure with this test anyway ;) (I am using
2.0.49, though.)
- Steve
>
>Index: t/protocol/TestProtocol/echo_bbs2.pm
>===================================================================
>RCS file: /home/cvs/modperl-2.0/t/protocol/TestProtocol/echo_bbs2.pm,v
>retrieving revision 1.5
>diff -u -r1.5 echo_bbs2.pm
>--- t/protocol/TestProtocol/echo_bbs2.pm 1 Jul 2004 02:01:21 -0000 1.5
>+++ t/protocol/TestProtocol/echo_bbs2.pm 12 Jul 2004 08:12:14 -0000
>@@ -27,16 +27,14 @@
>
> my $last = 0;
> while (1) {
>- my $bb_in = APR::Brigade->new($c->pool, $c->bucket_alloc);
>- my $rc = $c->input_filters->get_brigade($bb_in,
>+ my $rc = $c->input_filters->get_brigade($bb,
> Apache::MODE_GETLINE);
> last if $rc == APR::EOF;
> die APR::Error::strerror($rc) unless $rc == APR::SUCCESS;
>
>- next unless $bb_in->flatten(my $data);
>- $bb->cleanup;
>- #warn "read: [$data]\n";
>+ next unless $bb->flatten(my $data);
> last if $data =~ /^[\r\n]+$/;
>+ $bb->cleanup;
>
> # transform data here
> my $bucket = APR::Bucket->new(uc $data);
>@@ -45,6 +43,7 @@
> $c->output_filters->fflush($bb);
> }
>
>+ # XXX: add DESTROY and remove explicit calls
> $bb->destroy;
>
> Apache::OK;
>
>
>
>
------------------------------------------------
Radan Computational Ltd.
The information contained in this message and any files transmitted with it are confidential and intended for the addressee(s) only. If you have received this message in error or there are any problems, please notify the sender immediately. The unauthorized use, disclosure, copying or alteration of this message is strictly forbidden. Note that any views or opinions presented in this email are solely those of the author and do not necessarily represent those of Radan Computational Ltd. The recipient(s) of this message should check it and any attached files for viruses: Radan Computational will accept no liability for any damage caused by any virus transmitted by this email.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: ModPerl-Registry t/basic.t crashes Apache
Posted by Stas Bekman <st...@stason.org>.
> No, no change - I still get it crashing (perl-5.8.4,
> Apache/2.0.50, Win32).
Thanks for testing, Randy and Steve. How about this patch:
Index: t/protocol/TestProtocol/echo_bbs2.pm
===================================================================
RCS file: /home/cvs/modperl-2.0/t/protocol/TestProtocol/echo_bbs2.pm,v
retrieving revision 1.5
diff -u -r1.5 echo_bbs2.pm
--- t/protocol/TestProtocol/echo_bbs2.pm 1 Jul 2004 02:01:21 -0000 1.5
+++ t/protocol/TestProtocol/echo_bbs2.pm 12 Jul 2004 08:12:14 -0000
@@ -27,16 +27,14 @@
my $last = 0;
while (1) {
- my $bb_in = APR::Brigade->new($c->pool, $c->bucket_alloc);
- my $rc = $c->input_filters->get_brigade($bb_in,
+ my $rc = $c->input_filters->get_brigade($bb,
Apache::MODE_GETLINE);
last if $rc == APR::EOF;
die APR::Error::strerror($rc) unless $rc == APR::SUCCESS;
- next unless $bb_in->flatten(my $data);
- $bb->cleanup;
- #warn "read: [$data]\n";
+ next unless $bb->flatten(my $data);
last if $data =~ /^[\r\n]+$/;
+ $bb->cleanup;
# transform data here
my $bucket = APR::Bucket->new(uc $data);
@@ -45,6 +43,7 @@
$c->output_filters->fflush($bb);
}
+ # XXX: add DESTROY and remove explicit calls
$bb->destroy;
Apache::OK;
--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: ModPerl-Registry t/basic.t crashes Apache
Posted by Randy Kobes <ra...@theoryx5.uwinnipeg.ca>.
On Thu, 8 Jul 2004, Stas Bekman wrote:
> Randy Kobes wrote:
> > On Thu, 8 Jul 2004, Steve Hay wrote:
> > [ ... ]
> >
> >>I now have all tests successful in the main test suite and
> >>ModPerl-Registry's.
> >
> > Hi Steve,
> > That's great! Does this mean also that the
> > protocol/echo_bbs2 test passes for you? A few days
> > ago it was crashing on me, but I haven't tested that
> > particular test yet with the current cvs.
>
> Nothing has changed so far.
>
> Any improvements with this change?
>
>
> Index: t/protocol/TestProtocol/echo_bbs2.pm
> ===================================================================
> RCS file: /home/cvs/modperl-2.0/t/protocol/TestProtocol/echo_bbs2.pm,v
> retrieving revision 1.5
> diff -u -r1.5 echo_bbs2.pm
> --- t/protocol/TestProtocol/echo_bbs2.pm 1 Jul 2004 02:01:21
> -0000 1.5
> +++ t/protocol/TestProtocol/echo_bbs2.pm 8 Jul 2004 17:53:46 -0000
> @@ -34,7 +34,6 @@
> die APR::Error::strerror($rc) unless $rc == APR::SUCCESS;
>
> next unless $bb_in->flatten(my $data);
> - $bb->cleanup;
> #warn "read: [$data]\n";
> last if $data =~ /^[\r\n]+$/;
>
> @@ -43,6 +42,7 @@
> $bb->insert_tail($bucket);
>
> $c->output_filters->fflush($bb);
> + $bb->cleanup;
> }
>
> $bb->destroy;
No, no change - I still get it crashing (perl-5.8.4,
Apache/2.0.50, Win32).
--
best regards,
randy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: ModPerl-Registry t/basic.t crashes Apache
Posted by Stas Bekman <st...@stason.org>.
Randy Kobes wrote:
> On Thu, 8 Jul 2004, Stas Bekman wrote:
>
>
>>Randy Kobes wrote:
>
> [ ... ]
>
>>> That's great! Does this mean also that the
>>>protocol/echo_bbs2 test passes for you? A few days
>>>ago it was crashing on me, but I haven't tested that
>>>particular test yet with the current cvs.
>>
>>Nothing has changed so far.
>>
>>Any improvements with this change?
>>
>>
>>Index: t/protocol/TestProtocol/echo_bbs2.pm
>>===================================================================
>>RCS file: /home/cvs/modperl-2.0/t/protocol/TestProtocol/echo_bbs2.pm,v
>>retrieving revision 1.5
>>diff -u -r1.5 echo_bbs2.pm
>>--- t/protocol/TestProtocol/echo_bbs2.pm 1 Jul 2004 02:01:21
>>-0000 1.5
>>+++ t/protocol/TestProtocol/echo_bbs2.pm 8 Jul 2004 17:53:46 -0000
>>@@ -34,7 +34,6 @@
>> die APR::Error::strerror($rc) unless $rc == APR::SUCCESS;
>>
>> next unless $bb_in->flatten(my $data);
>>- $bb->cleanup;
>> #warn "read: [$data]\n";
>> last if $data =~ /^[\r\n]+$/;
>>
>>@@ -43,6 +42,7 @@
>> $bb->insert_tail($bucket);
>>
>> $c->output_filters->fflush($bb);
>>+ $bb->cleanup;
>> }
>>
>> $bb->destroy;
>
>
> Unfortunately (or fortunately :), for me with
> perl-5.8.0 and Apache/2.0.50, this test now passes,
> without the above change, with the current cvs.
> So maybe some recent changes fixed this?
Not in modperl. Which apache version did you have the problem with? May
be I can try it. I think Philippe was reporting with the latest
2.0.50-dev at that time and that's what I had. As I suggested before
it's quite possible that I didn't have the problem, if the bb was freed
by some downstream filter, but nothing else has claimed that memory yet,
so the tests worked just fine.
The simplest is probably just to rework the test to create the bb on
each iteration, which is a waste, but what can we do...
> I do have a problem with one of the recent
> modperl/pnotes tests that were added, but I'll
> look into that some more in a separate message.
ok
--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: ModPerl-Registry t/basic.t crashes Apache
Posted by Randy Kobes <ra...@theoryx5.uwinnipeg.ca>.
On Thu, 8 Jul 2004, Stas Bekman wrote:
> Randy Kobes wrote:
[ ... ]
> > That's great! Does this mean also that the
> > protocol/echo_bbs2 test passes for you? A few days
> > ago it was crashing on me, but I haven't tested that
> > particular test yet with the current cvs.
>
> Nothing has changed so far.
>
> Any improvements with this change?
>
>
> Index: t/protocol/TestProtocol/echo_bbs2.pm
> ===================================================================
> RCS file: /home/cvs/modperl-2.0/t/protocol/TestProtocol/echo_bbs2.pm,v
> retrieving revision 1.5
> diff -u -r1.5 echo_bbs2.pm
> --- t/protocol/TestProtocol/echo_bbs2.pm 1 Jul 2004 02:01:21
> -0000 1.5
> +++ t/protocol/TestProtocol/echo_bbs2.pm 8 Jul 2004 17:53:46 -0000
> @@ -34,7 +34,6 @@
> die APR::Error::strerror($rc) unless $rc == APR::SUCCESS;
>
> next unless $bb_in->flatten(my $data);
> - $bb->cleanup;
> #warn "read: [$data]\n";
> last if $data =~ /^[\r\n]+$/;
>
> @@ -43,6 +42,7 @@
> $bb->insert_tail($bucket);
>
> $c->output_filters->fflush($bb);
> + $bb->cleanup;
> }
>
> $bb->destroy;
Unfortunately (or fortunately :), for me with
perl-5.8.0 and Apache/2.0.50, this test now passes,
without the above change, with the current cvs.
So maybe some recent changes fixed this?
I do have a problem with one of the recent
modperl/pnotes tests that were added, but I'll
look into that some more in a separate message.
--
best regards,
randy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: ModPerl-Registry t/basic.t crashes Apache
Posted by Stas Bekman <st...@stason.org>.
Randy Kobes wrote:
> On Thu, 8 Jul 2004, Steve Hay wrote:
> [ ... ]
>
>>I now have all tests successful in the main test suite and
>>ModPerl-Registry's.
>
> Hi Steve,
> That's great! Does this mean also that the
> protocol/echo_bbs2 test passes for you? A few days
> ago it was crashing on me, but I haven't tested that
> particular test yet with the current cvs.
Nothing has changed so far.
Any improvements with this change?
Index: t/protocol/TestProtocol/echo_bbs2.pm
===================================================================
RCS file: /home/cvs/modperl-2.0/t/protocol/TestProtocol/echo_bbs2.pm,v
retrieving revision 1.5
diff -u -r1.5 echo_bbs2.pm
--- t/protocol/TestProtocol/echo_bbs2.pm 1 Jul 2004 02:01:21
-0000 1.5
+++ t/protocol/TestProtocol/echo_bbs2.pm 8 Jul 2004 17:53:46 -0000
@@ -34,7 +34,6 @@
die APR::Error::strerror($rc) unless $rc == APR::SUCCESS;
next unless $bb_in->flatten(my $data);
- $bb->cleanup;
#warn "read: [$data]\n";
last if $data =~ /^[\r\n]+$/;
@@ -43,6 +42,7 @@
$bb->insert_tail($bucket);
$c->output_filters->fflush($bb);
+ $bb->cleanup;
}
$bb->destroy;
--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: ModPerl-Registry t/basic.t crashes Apache
Posted by Steve Hay <st...@uk.radan.com>.
Randy Kobes wrote:
>On Thu, 8 Jul 2004, Steve Hay wrote:
>[ ... ]
>
>
>>I now have all tests successful in the main test suite and
>>ModPerl-Registry's.
>>
>>
>Hi Steve,
> That's great! Does this mean also that the
>protocol/echo_bbs2 test passes for you? A few days
>ago it was crashing on me, but I haven't tested that
>particular test yet with the current cvs.
>
Yes it does indeed work for me.
This is with Perl 5.8.4 and Apache 2.0.49.
- Steve
------------------------------------------------
Radan Computational Ltd.
The information contained in this message and any files transmitted with it are confidential and intended for the addressee(s) only. If you have received this message in error or there are any problems, please notify the sender immediately. The unauthorized use, disclosure, copying or alteration of this message is strictly forbidden. Note that any views or opinions presented in this email are solely those of the author and do not necessarily represent those of Radan Computational Ltd. The recipient(s) of this message should check it and any attached files for viruses: Radan Computational will accept no liability for any damage caused by any virus transmitted by this email.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: ModPerl-Registry t/basic.t crashes Apache
Posted by Randy Kobes <ra...@theoryx5.uwinnipeg.ca>.
On Thu, 8 Jul 2004, Steve Hay wrote:
[ ... ]
> I now have all tests successful in the main test suite and
> ModPerl-Registry's.
Hi Steve,
That's great! Does this mean also that the
protocol/echo_bbs2 test passes for you? A few days
ago it was crashing on me, but I haven't tested that
particular test yet with the current cvs.
--
best regards,
randy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: ModPerl-Registry t/basic.t crashes Apache
Posted by Steve Hay <st...@uk.radan.com>.
Stas Bekman wrote:
>Steve Hay wrote:
>
>
>>All is not quite well with the current CVS mp2 tests -- the
>>ModPerl-Registry tests fail from t/basic.t onwards.
>>
>>It seems that this test is now crashing Apache.exe. It can be
>>reproduced in isolation. Here's a stack trace:
>>
>>
>[...]
>
>
>>It crashed right at the start of Perl_sv_unmagic(), on this line:
>>
>> if (SvTYPE(sv) < SVt_PVMG || !SvMAGIC(sv))
>>
>>Error was "Access Violation" because sv is actually NULL.
>>
>>Presumably this is caused by the workaround to the in_error.t test
>>failure? (stash in modperl_croak() was also NULL.)
>>
>>
>
>Yes, yes, that's correct. You aren't running the up-to-date cvs. I've
>added 'use APR::Error' to M-R test-suite a few minutes later, when I've
>noticed that problem.
>
Yes! It appears that you updated CVS about 3minutes after I checked out
the latest stuff!
I now have all tests successful in the main test suite and
ModPerl-Registry's.
- Steve
------------------------------------------------
Radan Computational Ltd.
The information contained in this message and any files transmitted with it are confidential and intended for the addressee(s) only. If you have received this message in error or there are any problems, please notify the sender immediately. The unauthorized use, disclosure, copying or alteration of this message is strictly forbidden. Note that any views or opinions presented in this email are solely those of the author and do not necessarily represent those of Radan Computational Ltd. The recipient(s) of this message should check it and any attached files for viruses: Radan Computational will accept no liability for any damage caused by any virus transmitted by this email.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: ModPerl-Registry t/basic.t crashes Apache
Posted by Stas Bekman <st...@stason.org>.
Steve Hay wrote:
> All is not quite well with the current CVS mp2 tests -- the
> ModPerl-Registry tests fail from t/basic.t onwards.
>
> It seems that this test is now crashing Apache.exe. It can be
> reproduced in isolation. Here's a stack trace:
[...]
> It crashed right at the start of Perl_sv_unmagic(), on this line:
>
> if (SvTYPE(sv) < SVt_PVMG || !SvMAGIC(sv))
>
> Error was "Access Violation" because sv is actually NULL.
>
> Presumably this is caused by the workaround to the in_error.t test
> failure? (stash in modperl_croak() was also NULL.)
Yes, yes, that's correct. You aren't running the up-to-date cvs. I've
added 'use APR::Error' to M-R test-suite a few minutes later, when I've
noticed that problem.
--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org