You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metron.apache.org by cestella <gi...@git.apache.org> on 2017/10/17 15:38:25 UTC
[GitHub] metron pull request #801: METRON-1254: Conditionals as map keys do not funct...
GitHub user cestella opened a pull request:
https://github.com/apache/metron/pull/801
METRON-1254: Conditionals as map keys do not function in Stellar
## Contributor Comments
We currently cannot represent map literals in stellar where the keys are conditionals. For instance, the expression `{ x < 10 : 'info' }` cannot be parsed currently and it should do. Having this enables a switch-style statement: `MAP_GET(true, { x < 10 : 'info', x >= 10 : 'warn' })`
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.
Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to verify your changes?
- [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cestella/incubator-metron conditionals_as_map_keys
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/801.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #801
----
commit 9a40bde3954958f963683dbfc89bf92fcf97931f
Author: cstella <ce...@gmail.com>
Date: 2017-10-17T15:30:21Z
Conditionals as map keys do not function
----
---
[GitHub] metron pull request #801: METRON-1254: Conditionals as map keys do not funct...
Posted by cestella <gi...@git.apache.org>.
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/801#discussion_r147257082
--- Diff: metron-stellar/stellar-common/src/main/antlr4/org/apache/metron/stellar/common/generated/Stellar.g4 ---
@@ -249,6 +253,7 @@ identifier_operand :
| NULL #NullConst
| EXISTS LPAREN IDENTIFIER RPAREN #ExistsFunc
| LPAREN conditional_expr RPAREN #condExpr_paren
--- End diff --
If you specify one named function, you have to name them all. What would you like to name it? I didn't spend too much time on it since I knew I wasn't implementing it, admittedly.
---
[GitHub] metron pull request #801: METRON-1254: Conditionals as map keys do not funct...
Posted by ottobackwards <gi...@git.apache.org>.
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/801#discussion_r147238667
--- Diff: metron-stellar/stellar-common/src/main/antlr4/org/apache/metron/stellar/common/generated/Stellar.g4 ---
@@ -249,6 +253,7 @@ identifier_operand :
| NULL #NullConst
| EXISTS LPAREN IDENTIFIER RPAREN #ExistsFunc
| LPAREN conditional_expr RPAREN #condExpr_paren
--- End diff --
Why are we specifying the #func function?
* We don't implement it
* The name should be better
---
[GitHub] metron pull request #801: METRON-1254: Conditionals as map keys do not funct...
Posted by cestella <gi...@git.apache.org>.
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/801#discussion_r147258452
--- Diff: metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/BasicStellarTest.java ---
@@ -218,6 +218,25 @@ public void testVariablesUsed() {
}
}
+ @Test
+ public void testConditionalsAsMapKeys() {
+ {
+ String query = "{ ( RET_TRUE() && y < 50 ) : 'info', y >= 50 : 'warn'}";
+ Map<Boolean, String> ret = (Map)run(query, ImmutableMap.of("y", 50));
+ Assert.assertEquals(ret.size(), 2);
+ Assert.assertEquals("warn", ret.get(true));
+ Assert.assertEquals("info", ret.get(false));
+ }
+ }
+
+
+ @Test
+ public void testConditionalsAsFunctionArgs() {
+ {
+ String query = "RET_TRUE(y < 10)";
+ Assert.assertTrue((boolean)run(query, ImmutableMap.of("y", 50)));
+ }
+ }
--- End diff --
I wouldn't be opposed to adding the case, mind you. I'll go ahead and add it to be explicit.
---
[GitHub] metron pull request #801: METRON-1254: Conditionals as map keys do not funct...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/801
---
[GitHub] metron pull request #801: METRON-1254: Conditionals as map keys do not funct...
Posted by ottobackwards <gi...@git.apache.org>.
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/801#discussion_r147259905
--- Diff: metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/BasicStellarTest.java ---
@@ -218,6 +218,25 @@ public void testVariablesUsed() {
}
}
+ @Test
+ public void testConditionalsAsMapKeys() {
+ {
+ String query = "{ ( RET_TRUE() && y < 50 ) : 'info', y >= 50 : 'warn'}";
+ Map<Boolean, String> ret = (Map)run(query, ImmutableMap.of("y", 50));
+ Assert.assertEquals(ret.size(), 2);
+ Assert.assertEquals("warn", ret.get(true));
+ Assert.assertEquals("info", ret.get(false));
+ }
+ }
+
+
+ @Test
+ public void testConditionalsAsFunctionArgs() {
+ {
+ String query = "RET_TRUE(y < 10)";
+ Assert.assertTrue((boolean)run(query, ImmutableMap.of("y", 50)));
+ }
+ }
--- End diff --
I was thinking of something else, but on second thought I don't think it is valid.
---
[GitHub] metron issue #801: METRON-1254: Conditionals as map keys do not function in ...
Posted by ottobackwards <gi...@git.apache.org>.
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/801
+1 by inspection
---
[GitHub] metron pull request #801: METRON-1254: Conditionals as map keys do not funct...
Posted by ottobackwards <gi...@git.apache.org>.
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/801#discussion_r147239180
--- Diff: metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/BasicStellarTest.java ---
@@ -218,6 +218,25 @@ public void testVariablesUsed() {
}
}
+ @Test
+ public void testConditionalsAsMapKeys() {
+ {
+ String query = "{ ( RET_TRUE() && y < 50 ) : 'info', y >= 50 : 'warn'}";
+ Map<Boolean, String> ret = (Map)run(query, ImmutableMap.of("y", 50));
+ Assert.assertEquals(ret.size(), 2);
+ Assert.assertEquals("warn", ret.get(true));
+ Assert.assertEquals("info", ret.get(false));
+ }
+ }
+
+
+ @Test
+ public void testConditionalsAsFunctionArgs() {
+ {
+ String query = "RET_TRUE(y < 10)";
+ Assert.assertTrue((boolean)run(query, ImmutableMap.of("y", 50)));
+ }
+ }
--- End diff --
Do we need lambda with args tests for this as well?
---
[GitHub] metron pull request #801: METRON-1254: Conditionals as map keys do not funct...
Posted by ottobackwards <gi...@git.apache.org>.
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/801#discussion_r147257992
--- Diff: metron-stellar/stellar-common/src/main/antlr4/org/apache/metron/stellar/common/generated/Stellar.g4 ---
@@ -249,6 +253,7 @@ identifier_operand :
| NULL #NullConst
| EXISTS LPAREN IDENTIFIER RPAREN #ExistsFunc
| LPAREN conditional_expr RPAREN #condExpr_paren
--- End diff --
Oh man, sorry, I did know that from the match work.
---
[GitHub] metron pull request #801: METRON-1254: Conditionals as map keys do not funct...
Posted by cestella <gi...@git.apache.org>.
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/801#discussion_r147257285
--- Diff: metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/BasicStellarTest.java ---
@@ -218,6 +218,25 @@ public void testVariablesUsed() {
}
}
+ @Test
+ public void testConditionalsAsMapKeys() {
+ {
+ String query = "{ ( RET_TRUE() && y < 50 ) : 'info', y >= 50 : 'warn'}";
+ Map<Boolean, String> ret = (Map)run(query, ImmutableMap.of("y", 50));
+ Assert.assertEquals(ret.size(), 2);
+ Assert.assertEquals("warn", ret.get(true));
+ Assert.assertEquals("info", ret.get(false));
+ }
+ }
+
+
+ @Test
+ public void testConditionalsAsFunctionArgs() {
+ {
+ String query = "RET_TRUE(y < 10)";
+ Assert.assertTrue((boolean)run(query, ImmutableMap.of("y", 50)));
+ }
+ }
--- End diff --
Well, we know that lambdas can be arguments for functions (because of `MAP` and `REDUCE`)
---