You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Todd Lipcon (Created) (JIRA)" <ji...@apache.org> on 2012/03/23 18:09:28 UTC
[jira] [Created] (HDFS-3132) Findbugs warning on HDFS trunk
Findbugs warning on HDFS trunk
------------------------------
Key: HDFS-3132
URL: https://issues.apache.org/jira/browse/HDFS-3132
Project: Hadoop HDFS
Issue Type: Bug
Components: name-node
Affects Versions: 0.24.0, 0.23.3
Reporter: Todd Lipcon
Assignee: Todd Lipcon
Priority: Minor
"Inconsistent synchronization of org.apache.hadoop.hdfs.server.namenode.NameNode.state; locked 50% of time". I think this was probably one of my recent cross-project HA patches in which the QA bot was unable to run. Will investigate.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3132) Findbugs warning on HDFS trunk
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237538#comment-13237538 ]
Hudson commented on HDFS-3132:
------------------------------
Integrated in Hadoop-Mapreduce-trunk #1029 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1029/])
HDFS-3132. Fix findbugs warning on HDFS trunk. Contributed by Todd Lipcon. (Revision 1304681)
Result = SUCCESS
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304681
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
> Findbugs warning on HDFS trunk
> ------------------------------
>
> Key: HDFS-3132
> URL: https://issues.apache.org/jira/browse/HDFS-3132
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.24.0, 0.23.3
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Fix For: 0.24.0, 0.23.3
>
> Attachments: hdfs-3132.txt
>
>
> "Inconsistent synchronization of org.apache.hadoop.hdfs.server.namenode.NameNode.state; locked 50% of time". I think this was probably one of my recent cross-project HA patches in which the QA bot was unable to run. Will investigate.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3132) Findbugs warning on HDFS trunk
Posted by "Todd Lipcon (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HDFS-3132:
------------------------------
Target Version/s: 0.24.0, 0.23.3 (was: 0.23.3, 0.24.0)
Status: Patch Available (was: Open)
> Findbugs warning on HDFS trunk
> ------------------------------
>
> Key: HDFS-3132
> URL: https://issues.apache.org/jira/browse/HDFS-3132
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.24.0, 0.23.3
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Attachments: hdfs-3132.txt
>
>
> "Inconsistent synchronization of org.apache.hadoop.hdfs.server.namenode.NameNode.state; locked 50% of time". I think this was probably one of my recent cross-project HA patches in which the QA bot was unable to run. Will investigate.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3132) Findbugs warning on HDFS trunk
Posted by "Todd Lipcon (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236858#comment-13236858 ]
Todd Lipcon commented on HDFS-3132:
-----------------------------------
bq. Please avoid cross-project patches and split the patches into sub-projects. Or, you have to run all the checks and tests before committing
There's not currently any easy way to run all the checks. And the problem with splitting into sub-projects is that, often, a patch in Common would actually break the build if it were committed before the associated patch in HDFS. I'd rather chance introducing a few warnings than break the build for everyone.
Regarding these particular patches, I originally put all of the code for HA in HDFS, but others argued we should try to build a generic framework (despite the fact that HDFS is the only implementer of all of these new Common pieces). So now we're left in this situation where any non-trivial changes to failover have to go cross-project.
bq. I guess you don't want to be known for adding findbugs or other warnings to Hadoop.
Somehow I don't think that's what I'm known for... out of the 20+ things I've committed in the last month, a mistake rate of 5% doesn't seem so bad.
Hopefully someone can spend some time working on cross-project test-patch which would ameliorate this issue.
> Findbugs warning on HDFS trunk
> ------------------------------
>
> Key: HDFS-3132
> URL: https://issues.apache.org/jira/browse/HDFS-3132
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.24.0, 0.23.3
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
>
> "Inconsistent synchronization of org.apache.hadoop.hdfs.server.namenode.NameNode.state; locked 50% of time". I think this was probably one of my recent cross-project HA patches in which the QA bot was unable to run. Will investigate.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3132) Findbugs warning on HDFS trunk
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237395#comment-13237395 ]
Hudson commented on HDFS-3132:
------------------------------
Integrated in Hadoop-Mapreduce-0.23-Commit #731 (See [https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/731/])
HDFS-3132. Fix findbugs warning on HDFS trunk. Contributed by Todd Lipcon. (Revision 1304682)
Result = ABORTED
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304682
Files :
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
> Findbugs warning on HDFS trunk
> ------------------------------
>
> Key: HDFS-3132
> URL: https://issues.apache.org/jira/browse/HDFS-3132
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.24.0, 0.23.3
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Fix For: 0.24.0, 0.23.3
>
> Attachments: hdfs-3132.txt
>
>
> "Inconsistent synchronization of org.apache.hadoop.hdfs.server.namenode.NameNode.state; locked 50% of time". I think this was probably one of my recent cross-project HA patches in which the QA bot was unable to run. Will investigate.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3132) Findbugs warning on HDFS trunk
Posted by "Todd Lipcon (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HDFS-3132:
------------------------------
Resolution: Fixed
Fix Version/s: 0.23.3
0.24.0
Target Version/s: 0.24.0, 0.23.3 (was: 0.23.3, 0.24.0)
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Committed to trunk and 23
> Findbugs warning on HDFS trunk
> ------------------------------
>
> Key: HDFS-3132
> URL: https://issues.apache.org/jira/browse/HDFS-3132
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.24.0, 0.23.3
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Fix For: 0.24.0, 0.23.3
>
> Attachments: hdfs-3132.txt
>
>
> "Inconsistent synchronization of org.apache.hadoop.hdfs.server.namenode.NameNode.state; locked 50% of time". I think this was probably one of my recent cross-project HA patches in which the QA bot was unable to run. Will investigate.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3132) Findbugs warning on HDFS trunk
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237516#comment-13237516 ]
Hudson commented on HDFS-3132:
------------------------------
Integrated in Hadoop-Hdfs-0.23-Build #207 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/207/])
HDFS-3132. Fix findbugs warning on HDFS trunk. Contributed by Todd Lipcon. (Revision 1304682)
Result = UNSTABLE
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304682
Files :
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
> Findbugs warning on HDFS trunk
> ------------------------------
>
> Key: HDFS-3132
> URL: https://issues.apache.org/jira/browse/HDFS-3132
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.24.0, 0.23.3
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Fix For: 0.24.0, 0.23.3
>
> Attachments: hdfs-3132.txt
>
>
> "Inconsistent synchronization of org.apache.hadoop.hdfs.server.namenode.NameNode.state; locked 50% of time". I think this was probably one of my recent cross-project HA patches in which the QA bot was unable to run. Will investigate.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3132) Findbugs warning on HDFS trunk
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237350#comment-13237350 ]
Hudson commented on HDFS-3132:
------------------------------
Integrated in Hadoop-Common-trunk-Commit #1923 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1923/])
HDFS-3132. Fix findbugs warning on HDFS trunk. Contributed by Todd Lipcon. (Revision 1304681)
Result = SUCCESS
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304681
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
> Findbugs warning on HDFS trunk
> ------------------------------
>
> Key: HDFS-3132
> URL: https://issues.apache.org/jira/browse/HDFS-3132
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.24.0, 0.23.3
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Fix For: 0.24.0, 0.23.3
>
> Attachments: hdfs-3132.txt
>
>
> "Inconsistent synchronization of org.apache.hadoop.hdfs.server.namenode.NameNode.state; locked 50% of time". I think this was probably one of my recent cross-project HA patches in which the QA bot was unable to run. Will investigate.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3132) Findbugs warning on HDFS trunk
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237521#comment-13237521 ]
Hudson commented on HDFS-3132:
------------------------------
Integrated in Hadoop-Mapreduce-0.23-Build #235 (See [https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/235/])
HDFS-3132. Fix findbugs warning on HDFS trunk. Contributed by Todd Lipcon. (Revision 1304682)
Result = FAILURE
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304682
Files :
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
> Findbugs warning on HDFS trunk
> ------------------------------
>
> Key: HDFS-3132
> URL: https://issues.apache.org/jira/browse/HDFS-3132
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.24.0, 0.23.3
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Fix For: 0.24.0, 0.23.3
>
> Attachments: hdfs-3132.txt
>
>
> "Inconsistent synchronization of org.apache.hadoop.hdfs.server.namenode.NameNode.state; locked 50% of time". I think this was probably one of my recent cross-project HA patches in which the QA bot was unable to run. Will investigate.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3132) Findbugs warning on HDFS trunk
Posted by "Tsz Wo (Nicholas), SZE (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236844#comment-13236844 ]
Tsz Wo (Nicholas), SZE commented on HDFS-3132:
----------------------------------------------
Please avoid cross-project patches and split the patches into sub-projects. Or, you have to run all the checks and tests before committing. I guess you don't want to be known for adding findbugs or other warnings to Hadoop. ;)
> Findbugs warning on HDFS trunk
> ------------------------------
>
> Key: HDFS-3132
> URL: https://issues.apache.org/jira/browse/HDFS-3132
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.24.0, 0.23.3
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
>
> "Inconsistent synchronization of org.apache.hadoop.hdfs.server.namenode.NameNode.state; locked 50% of time". I think this was probably one of my recent cross-project HA patches in which the QA bot was unable to run. Will investigate.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3132) Findbugs warning on HDFS trunk
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237511#comment-13237511 ]
Hudson commented on HDFS-3132:
------------------------------
Integrated in Hadoop-Hdfs-trunk #994 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/994/])
HDFS-3132. Fix findbugs warning on HDFS trunk. Contributed by Todd Lipcon. (Revision 1304681)
Result = FAILURE
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304681
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
> Findbugs warning on HDFS trunk
> ------------------------------
>
> Key: HDFS-3132
> URL: https://issues.apache.org/jira/browse/HDFS-3132
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.24.0, 0.23.3
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Fix For: 0.24.0, 0.23.3
>
> Attachments: hdfs-3132.txt
>
>
> "Inconsistent synchronization of org.apache.hadoop.hdfs.server.namenode.NameNode.state; locked 50% of time". I think this was probably one of my recent cross-project HA patches in which the QA bot was unable to run. Will investigate.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3132) Findbugs warning on HDFS trunk
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237362#comment-13237362 ]
Hudson commented on HDFS-3132:
------------------------------
Integrated in Hadoop-Common-0.23-Commit #722 (See [https://builds.apache.org/job/Hadoop-Common-0.23-Commit/722/])
HDFS-3132. Fix findbugs warning on HDFS trunk. Contributed by Todd Lipcon. (Revision 1304682)
Result = SUCCESS
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304682
Files :
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
> Findbugs warning on HDFS trunk
> ------------------------------
>
> Key: HDFS-3132
> URL: https://issues.apache.org/jira/browse/HDFS-3132
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.24.0, 0.23.3
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Fix For: 0.24.0, 0.23.3
>
> Attachments: hdfs-3132.txt
>
>
> "Inconsistent synchronization of org.apache.hadoop.hdfs.server.namenode.NameNode.state; locked 50% of time". I think this was probably one of my recent cross-project HA patches in which the QA bot was unable to run. Will investigate.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3132) Findbugs warning on HDFS trunk
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237360#comment-13237360 ]
Hudson commented on HDFS-3132:
------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #1997 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1997/])
HDFS-3132. Fix findbugs warning on HDFS trunk. Contributed by Todd Lipcon. (Revision 1304681)
Result = SUCCESS
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304681
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
> Findbugs warning on HDFS trunk
> ------------------------------
>
> Key: HDFS-3132
> URL: https://issues.apache.org/jira/browse/HDFS-3132
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.24.0, 0.23.3
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Fix For: 0.24.0, 0.23.3
>
> Attachments: hdfs-3132.txt
>
>
> "Inconsistent synchronization of org.apache.hadoop.hdfs.server.namenode.NameNode.state; locked 50% of time". I think this was probably one of my recent cross-project HA patches in which the QA bot was unable to run. Will investigate.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3132) Findbugs warning on HDFS trunk
Posted by "Tsz Wo (Nicholas), SZE (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237014#comment-13237014 ]
Tsz Wo (Nicholas), SZE commented on HDFS-3132:
----------------------------------------------
{quote}
There's not currently any easy way to run all the checks. And the problem with splitting into sub-projects is that, often, a patch in Common would actually break the build if it were committed before the associated patch in HDFS. I'd rather chance introducing a few warnings than break the build for everyone.
{quote}
Agree. If splitting would break the build, it is better to commit together.
Buy why it is not easy to run the checks? I think it is easy at least to run findbugs.
> Findbugs warning on HDFS trunk
> ------------------------------
>
> Key: HDFS-3132
> URL: https://issues.apache.org/jira/browse/HDFS-3132
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.24.0, 0.23.3
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Attachments: hdfs-3132.txt
>
>
> "Inconsistent synchronization of org.apache.hadoop.hdfs.server.namenode.NameNode.state; locked 50% of time". I think this was probably one of my recent cross-project HA patches in which the QA bot was unable to run. Will investigate.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3132) Findbugs warning on HDFS trunk
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237004#comment-13237004 ]
Hadoop QA commented on HDFS-3132:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12519684/hdfs-3132.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.cli.TestHDFSCLI
org.apache.hadoop.hdfs.TestGetBlocks
org.apache.hadoop.hdfs.server.namenode.TestValidateConfigurationSettings
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2083//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2083//console
This message is automatically generated.
> Findbugs warning on HDFS trunk
> ------------------------------
>
> Key: HDFS-3132
> URL: https://issues.apache.org/jira/browse/HDFS-3132
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.24.0, 0.23.3
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Attachments: hdfs-3132.txt
>
>
> "Inconsistent synchronization of org.apache.hadoop.hdfs.server.namenode.NameNode.state; locked 50% of time". I think this was probably one of my recent cross-project HA patches in which the QA bot was unable to run. Will investigate.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3132) Findbugs warning on HDFS trunk
Posted by "Todd Lipcon (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HDFS-3132:
------------------------------
Attachment: hdfs-3132.txt
Patch makes NameNode.state volatile to quiet the warning. This should be sufficient since the actual complicated transitions are themselves synchronized.
> Findbugs warning on HDFS trunk
> ------------------------------
>
> Key: HDFS-3132
> URL: https://issues.apache.org/jira/browse/HDFS-3132
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.24.0, 0.23.3
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Attachments: hdfs-3132.txt
>
>
> "Inconsistent synchronization of org.apache.hadoop.hdfs.server.namenode.NameNode.state; locked 50% of time". I think this was probably one of my recent cross-project HA patches in which the QA bot was unable to run. Will investigate.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3132) Findbugs warning on HDFS trunk
Posted by "Tsz Wo (Nicholas), SZE (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237016#comment-13237016 ]
Tsz Wo (Nicholas), SZE commented on HDFS-3132:
----------------------------------------------
BTW, +1 patch looks good.
> Findbugs warning on HDFS trunk
> ------------------------------
>
> Key: HDFS-3132
> URL: https://issues.apache.org/jira/browse/HDFS-3132
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.24.0, 0.23.3
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Attachments: hdfs-3132.txt
>
>
> "Inconsistent synchronization of org.apache.hadoop.hdfs.server.namenode.NameNode.state; locked 50% of time". I think this was probably one of my recent cross-project HA patches in which the QA bot was unable to run. Will investigate.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3132) Findbugs warning on HDFS trunk
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237394#comment-13237394 ]
Hudson commented on HDFS-3132:
------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #1933 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1933/])
HDFS-3132. Fix findbugs warning on HDFS trunk. Contributed by Todd Lipcon. (Revision 1304681)
Result = ABORTED
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304681
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
> Findbugs warning on HDFS trunk
> ------------------------------
>
> Key: HDFS-3132
> URL: https://issues.apache.org/jira/browse/HDFS-3132
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.24.0, 0.23.3
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Fix For: 0.24.0, 0.23.3
>
> Attachments: hdfs-3132.txt
>
>
> "Inconsistent synchronization of org.apache.hadoop.hdfs.server.namenode.NameNode.state; locked 50% of time". I think this was probably one of my recent cross-project HA patches in which the QA bot was unable to run. Will investigate.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3132) Findbugs warning on HDFS trunk
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237353#comment-13237353 ]
Hudson commented on HDFS-3132:
------------------------------
Integrated in Hadoop-Hdfs-0.23-Commit #712 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/712/])
HDFS-3132. Fix findbugs warning on HDFS trunk. Contributed by Todd Lipcon. (Revision 1304682)
Result = SUCCESS
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304682
Files :
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
> Findbugs warning on HDFS trunk
> ------------------------------
>
> Key: HDFS-3132
> URL: https://issues.apache.org/jira/browse/HDFS-3132
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.24.0, 0.23.3
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Fix For: 0.24.0, 0.23.3
>
> Attachments: hdfs-3132.txt
>
>
> "Inconsistent synchronization of org.apache.hadoop.hdfs.server.namenode.NameNode.state; locked 50% of time". I think this was probably one of my recent cross-project HA patches in which the QA bot was unable to run. Will investigate.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira