[GitHub] [orc] pgaref commented on a change in pull request #655: ORC-694: Update docker files for adding Java11 support

[GitBox <gi...@apache.org>]

pgaref commented on a change in pull request #655:
URL: https://github.com/apache/orc/pull/655#discussion_r596314939



##########
File path: docker/README.md
##########
@@ -21,7 +21,7 @@ The scripts are:
 A base image for each OS is built using:
 
     cd docker/$os
-    docker build -t orc-$os .
+    docker build -t "orc-$os-jdk8" --build-arg jdk=8 . OR docker build -t "orc-$os-jdk11" --build-arg jdk=11 .

Review comment:
       Lets make it more explicit.
   For jdk8:  docker build -t "orc-$os-jdk8" --build-arg jdk=8 .
   For jdk11: docker build -t "orc-$os-jdk11" --build-arg jdk=11 .

##########
File path: docker/README.md
##########
@@ -21,7 +21,7 @@ The scripts are:
 A base image for each OS is built using:

Review comment:
       Lets add above that:
   `run-all.sh` and `run-one.sh` tests both on jdk8 and 11 across OSes




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org