You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/08/24 06:18:07 UTC

[GitHub] [kafka] cadonna commented on a diff in pull request #12549: KAFKA-10199: Introduce task registry

cadonna commented on code in PR #12549:
URL: https://github.com/apache/kafka/pull/12549#discussion_r953390083


##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##########
@@ -1575,7 +1576,7 @@ void addTask(final Task task) {
         tasks.addTask(task);
     }
 
-    Tasks tasks() {
+    TasksRegistry tasks() {

Review Comment:
   Yeah, I think that is a good idea for this method. But I also think that this method is not needed anymore and it will be removed once the tests in `TaskManagerTest` are updated. I will leave it as it is in this PR and consider the  change in one of the following PRs. Thank you!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org