You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/30 15:47:54 UTC

[GitHub] [flink] godfreyhe commented on pull request #11862: [FLINK-17251] [table] supports INSERT statement in TableEnvironment#executeSql and Table#executeInsert api

godfreyhe commented on pull request #11862:
URL: https://github.com/apache/flink/pull/11862#issuecomment-621938141


   @twalthr `TableEnvImpl` does not extends from `TableEnvironmentImpl`, so we can't  cast  `TableEnvironment` to `TableEnvironmentImpl` in `TableImpl`. once old planner is removed, `TableEnvironmentInternal` also can be removed.
   
   Ragarding to "internal" package visibility: for `TableEnvironmentInternal` and `TableResultImpl`, we can just remove `public` access modifier. but for other classes, I find them are used by other package's classes. such as, `TableImpl` is used by `TableConversions`, `TableEnvImpl` , `PipelineStageBase`, etc.
   
   Ragarding to "PR description": Thanks for correction. I will pay more attention to this.
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org