You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Attila Király (JIRA)" <ji...@apache.org> on 2011/04/12 13:13:05 UTC
[jira] [Created] (WICKET-3610) ContainerFeedbackMessageFilter
should use Objects.equal for equality checking
ContainerFeedbackMessageFilter should use Objects.equal for equality checking
-----------------------------------------------------------------------------
Key: WICKET-3610
URL: https://issues.apache.org/jira/browse/WICKET-3610
Project: Wicket
Issue Type: Bug
Components: wicket-core
Affects Versions: 1.5-RC3
Reporter: Attila Király
Priority: Trivial
Attachments: WICKET-3610.patch
In its accept() method ContainerFeedbackMessageFilter currenlty uses "container == message.getReporter();" but a sibling class ComponentFeedbackMessageFilter uses "Objects.equal(component, message.getReporter());".
Probably both should behave the same way in this.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-3610) ContainerFeedbackMessageFilter
should use Objects.equal for equality checking
Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13019478#comment-13019478 ]
Peter Ertl commented on WICKET-3610:
------------------------------------
Fixed. Thanks for reporting!
> ContainerFeedbackMessageFilter should use Objects.equal for equality checking
> -----------------------------------------------------------------------------
>
> Key: WICKET-3610
> URL: https://issues.apache.org/jira/browse/WICKET-3610
> Project: Wicket
> Issue Type: Bug
> Components: wicket-core
> Affects Versions: 1.5-RC3
> Reporter: Attila Király
> Priority: Trivial
> Fix For: 1.5-RC4
>
> Attachments: WICKET-3610.patch
>
>
> In its accept() method ContainerFeedbackMessageFilter currenlty uses "container == message.getReporter();" but a sibling class ComponentFeedbackMessageFilter uses "Objects.equal(component, message.getReporter());".
> Probably both should behave the same way in this.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-3610) ContainerFeedbackMessageFilter
should use Objects.equal for equality checking
Posted by "Attila Király (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Attila Király updated WICKET-3610:
----------------------------------
Attachment: WICKET-3610.patch
Attaching patch.
> ContainerFeedbackMessageFilter should use Objects.equal for equality checking
> -----------------------------------------------------------------------------
>
> Key: WICKET-3610
> URL: https://issues.apache.org/jira/browse/WICKET-3610
> Project: Wicket
> Issue Type: Bug
> Components: wicket-core
> Affects Versions: 1.5-RC3
> Reporter: Attila Király
> Priority: Trivial
> Attachments: WICKET-3610.patch
>
>
> In its accept() method ContainerFeedbackMessageFilter currenlty uses "container == message.getReporter();" but a sibling class ComponentFeedbackMessageFilter uses "Objects.equal(component, message.getReporter());".
> Probably both should behave the same way in this.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-3610) ContainerFeedbackMessageFilter
should use Objects.equal for equality checking
Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Peter Ertl resolved WICKET-3610.
--------------------------------
Resolution: Fixed
Fix Version/s: 1.5-RC4
Assignee: Peter Ertl
> ContainerFeedbackMessageFilter should use Objects.equal for equality checking
> -----------------------------------------------------------------------------
>
> Key: WICKET-3610
> URL: https://issues.apache.org/jira/browse/WICKET-3610
> Project: Wicket
> Issue Type: Bug
> Components: wicket-core
> Affects Versions: 1.5-RC3
> Reporter: Attila Király
> Assignee: Peter Ertl
> Priority: Trivial
> Fix For: 1.5-RC4
>
> Attachments: WICKET-3610.patch
>
>
> In its accept() method ContainerFeedbackMessageFilter currenlty uses "container == message.getReporter();" but a sibling class ComponentFeedbackMessageFilter uses "Objects.equal(component, message.getReporter());".
> Probably both should behave the same way in this.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira