[jira] [Issue Comment Deleted] (HBASE-19951) Cleanup the explicit timeout value for test method

["stack (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HBASE-19951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-19951:
--------------------------
    Comment: was deleted

(was: Here is the hackery I made patch with:

Thanks Appy I don't think Inheritance works for these annotations. Will check in a sec....

Meantime parking some hackery:

Put back in place the @Rule
find hbase-/src/test -name *.java |xargs perl -pi -e 's/(HBaseClassTestRule.forClass(([^.])\.class)/$1\n @Rule\n public final TestRule TIMEOUT =\n CategoryBasedTimeout.forClass($2.class);/g'
Add import for CategoryBasedTimeout
find hbase-*/src/test -name *.java |xargs perl -pi -e 's/(import org\.apache\.hadoop\.hbase\.HBaseClassTestRule/import org.apache.hadoop.hbase.CategoryBasedTimeout;\n$1/g'
Add import for TimeRule...
find hbase-*/src/test -name *.java |xargs perl -pi -e 's/(import org\.junit\.experimental\.categories\.Category/$1\nimport org.junit.rules.TestRule;/g'
Add Rule...
find hbase-*/src/test -name *.java |xargs perl -pi -e 's/(import org\.junit\.ClassRule/$1\nimport org.junit.Rule;/g'

Above might violate CheckStyle for import order in a few cases.)

> Cleanup the explicit timeout value for test method
> --------------------------------------------------
>
>                 Key: HBASE-19951
>                 URL: https://issues.apache.org/jira/browse/HBASE-19951
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Duo Zhang
>            Priority: Major
>         Attachments: HBASE-19951.branch-2.001.patch
>
>
> As said in the parent issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)