You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jaimin Jetly <ja...@hortonworks.com> on 2014/10/18 02:34:00 UTC
Review Request 26905: Kafka ganglia metrics integration with Ambari.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26905/
-----------------------------------------------------------
Review request for Ambari, Srimanth Gunturi and Yusaku Sako.
Bugs: AMBARI-7845
https://issues.apache.org/jira/browse/AMBARI-7845
Repository: ambari
Description
-------
This task includes intgrating Ganglia metrics exposed by Kafka with Ambari.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/ganglia/GangliaHostPropertyProvider.java c87cd3a
ambari-server/src/main/java/org/apache/ambari/server/controller/ganglia/GangliaPropertyProvider.java 39a6b61
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_monitor.py ede1a0b
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/params.py f8373ac
ambari-server/src/main/resources/stacks/HDP/2.2/services/KAFKA/configuration/kafka-broker.xml cbedca3
ambari-server/src/main/resources/stacks/HDP/2.2/services/KAFKA/metrics.json PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KAFKA/package/scripts/kafka.py 269b0ae
ambari-server/src/main/resources/stacks/HDP/2.2/services/KAFKA/package/scripts/params.py fa68914
ambari-web/app/data/HDP2/site_properties.js 0b0d769
ambari-web/app/models/service_config.js 89e3adc
ambari-web/test/models/service_config_test.js 50ad222
Diff: https://reviews.apache.org/r/26905/diff/
Testing
-------
tested e2e
Thanks,
Jaimin Jetly
Re: Review Request 26905: Kafka ganglia metrics integration with
Ambari.
Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26905/#review57298
-----------------------------------------------------------
Ship it!
Ship It!
- Yusaku Sako
On Oct. 19, 2014, 10:38 p.m., Jaimin Jetly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26905/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2014, 10:38 p.m.)
>
>
> Review request for Ambari, Srimanth Gunturi and Yusaku Sako.
>
>
> Bugs: AMBARI-7845
> https://issues.apache.org/jira/browse/AMBARI-7845
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This task includes intgrating Ganglia metrics exposed by Kafka with Ambari.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/ganglia/GangliaHostPropertyProvider.java c87cd3a
> ambari-server/src/main/java/org/apache/ambari/server/controller/ganglia/GangliaPropertyProvider.java 39a6b61
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_monitor.py ede1a0b
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/params.py f8373ac
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KAFKA/configuration/kafka-broker.xml cbedca3
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KAFKA/metrics.json PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KAFKA/package/scripts/kafka.py 269b0ae
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KAFKA/package/scripts/params.py fa68914
> ambari-server/src/test/java/org/apache/ambari/server/controller/ganglia/GangliaPropertyProviderTest.java 4dc95a3
> ambari-server/src/test/python/stacks/2.2/configs/default.json 4c2ada9
> ambari-web/app/data/HDP2/site_properties.js 0b0d769
> ambari-web/app/models/service_config.js 89e3adc
> ambari-web/test/models/service_config_test.js 50ad222
>
> Diff: https://reviews.apache.org/r/26905/diff/
>
>
> Testing
> -------
>
> tested e2e
>
>
> Thanks,
>
> Jaimin Jetly
>
>
Re: Review Request 26905: Kafka ganglia metrics integration with
Ambari.
Posted by Srimanth Gunturi <sr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26905/#review57362
-----------------------------------------------------------
Ship it!
Ship It!
- Srimanth Gunturi
On Oct. 19, 2014, 10:38 p.m., Jaimin Jetly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26905/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2014, 10:38 p.m.)
>
>
> Review request for Ambari, Srimanth Gunturi and Yusaku Sako.
>
>
> Bugs: AMBARI-7845
> https://issues.apache.org/jira/browse/AMBARI-7845
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This task includes intgrating Ganglia metrics exposed by Kafka with Ambari.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/ganglia/GangliaHostPropertyProvider.java c87cd3a
> ambari-server/src/main/java/org/apache/ambari/server/controller/ganglia/GangliaPropertyProvider.java 39a6b61
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_monitor.py ede1a0b
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/params.py f8373ac
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KAFKA/configuration/kafka-broker.xml cbedca3
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KAFKA/metrics.json PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KAFKA/package/scripts/kafka.py 269b0ae
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KAFKA/package/scripts/params.py fa68914
> ambari-server/src/test/java/org/apache/ambari/server/controller/ganglia/GangliaPropertyProviderTest.java 4dc95a3
> ambari-server/src/test/python/stacks/2.2/configs/default.json 4c2ada9
> ambari-web/app/data/HDP2/site_properties.js 0b0d769
> ambari-web/app/models/service_config.js 89e3adc
> ambari-web/test/models/service_config_test.js 50ad222
>
> Diff: https://reviews.apache.org/r/26905/diff/
>
>
> Testing
> -------
>
> tested e2e
>
>
> Thanks,
>
> Jaimin Jetly
>
>
Re: Review Request 26905: Kafka ganglia metrics integration with
Ambari.
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26905/
-----------------------------------------------------------
(Updated Oct. 19, 2014, 10:38 p.m.)
Review request for Ambari, Srimanth Gunturi and Yusaku Sako.
Changes
-------
Earlier revision of the patch caused unit test failures for ambari-server and ambari-agent projects.
This patch fixes the broken unit tests
Bugs: AMBARI-7845
https://issues.apache.org/jira/browse/AMBARI-7845
Repository: ambari
Description
-------
This task includes intgrating Ganglia metrics exposed by Kafka with Ambari.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/ganglia/GangliaHostPropertyProvider.java c87cd3a
ambari-server/src/main/java/org/apache/ambari/server/controller/ganglia/GangliaPropertyProvider.java 39a6b61
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_monitor.py ede1a0b
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/params.py f8373ac
ambari-server/src/main/resources/stacks/HDP/2.2/services/KAFKA/configuration/kafka-broker.xml cbedca3
ambari-server/src/main/resources/stacks/HDP/2.2/services/KAFKA/metrics.json PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KAFKA/package/scripts/kafka.py 269b0ae
ambari-server/src/main/resources/stacks/HDP/2.2/services/KAFKA/package/scripts/params.py fa68914
ambari-server/src/test/java/org/apache/ambari/server/controller/ganglia/GangliaPropertyProviderTest.java 4dc95a3
ambari-server/src/test/python/stacks/2.2/configs/default.json 4c2ada9
ambari-web/app/data/HDP2/site_properties.js 0b0d769
ambari-web/app/models/service_config.js 89e3adc
ambari-web/test/models/service_config_test.js 50ad222
Diff: https://reviews.apache.org/r/26905/diff/
Testing
-------
tested e2e
Thanks,
Jaimin Jetly
Re: Review Request 26905: Kafka ganglia metrics integration with
Ambari.
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26905/
-----------------------------------------------------------
(Updated Oct. 19, 2014, 10:37 p.m.)
Review request for Ambari, Srimanth Gunturi and Yusaku Sako.
Changes
-------
Earlier revision of the patch caused unit tests failure for ambari-server and ambari-agent.
This patch addresses those issues.
Bugs: AMBARI-7845
https://issues.apache.org/jira/browse/AMBARI-7845
Repository: ambari
Description
-------
This task includes intgrating Ganglia metrics exposed by Kafka with Ambari.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/ganglia/GangliaHostPropertyProvider.java c87cd3a
ambari-server/src/main/java/org/apache/ambari/server/controller/ganglia/GangliaPropertyProvider.java 39a6b61
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_monitor.py ede1a0b
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/params.py f8373ac
ambari-server/src/main/resources/stacks/HDP/2.2/services/KAFKA/configuration/kafka-broker.xml cbedca3
ambari-server/src/main/resources/stacks/HDP/2.2/services/KAFKA/metrics.json PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KAFKA/package/scripts/kafka.py 269b0ae
ambari-server/src/main/resources/stacks/HDP/2.2/services/KAFKA/package/scripts/params.py fa68914
ambari-server/src/test/java/org/apache/ambari/server/controller/ganglia/GangliaPropertyProviderTest.java 4dc95a3
ambari-server/src/test/python/stacks/2.2/configs/default.json 4c2ada9
ambari-web/app/data/HDP2/site_properties.js 0b0d769
ambari-web/app/models/service_config.js 89e3adc
ambari-web/test/models/service_config_test.js 50ad222
Diff: https://reviews.apache.org/r/26905/diff/
Testing
-------
tested e2e
Thanks,
Jaimin Jetly