You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/07/12 03:52:31 UTC
[GitHub] [dubbo-go] hxmhlt commented on a change in pull request #604: Ftr: Application-level Registry Model
hxmhlt commented on a change in pull request #604:
URL: https://github.com/apache/dubbo-go/pull/604#discussion_r453197539
##########
File path: common/constant/key.go
##########
@@ -155,6 +163,14 @@ const (
NACOS_USERNAME = "username"
)
Review comment:
Remove the constant into nacos's directory.
##########
File path: common/constant/key.go
##########
@@ -155,6 +163,14 @@ const (
NACOS_USERNAME = "username"
)
+const (
+ ZOOKEEPER_KEY = "zookeeper"
+)
+
+const (
+ ETCDV3_KEY = "etcdv3"
+)
Review comment:
Remove the constant into etcd 's directory.
##########
File path: common/constant/key.go
##########
@@ -155,6 +163,14 @@ const (
NACOS_USERNAME = "username"
)
+const (
+ ZOOKEEPER_KEY = "zookeeper"
+)
Review comment:
Remove the constant into zookeeper 's directory.
##########
File path: config/base_config.go
##########
@@ -64,7 +83,7 @@ func (c *BaseConfig) startConfigCenter() error {
if c.prepareEnvironment() != nil {
return perrors.WithMessagef(err, "start config center error!")
}
- //c.fresh()
+ // c.fresh()
return err
Review comment:
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org