You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2023/08/25 07:13:56 UTC
[GitHub] [spark] HyukjinKwon opened a new pull request, #42676: [SPARK-44961][PYTHON][TESTS] Make PySpark (pyspark-connect module) tests passing without any dependency
HyukjinKwon opened a new pull request, #42676:
URL: https://github.com/apache/spark/pull/42676
### What changes were proposed in this pull request?
This PR proposes to fix the tests to properly run or skip when there aren't optional dependencies installed.
### Why are the changes needed?
Currently, it fails as below:
```
./python/run-tests --python-executables=python3 --modules=pyspark-connect
...
2c5289024a/python3__pyspark.sql.connect.window__nvbbzy7q.log)
Finished test(python3): pyspark.sql.connect.session (0s)
Traceback (most recent call last):
File "/Users/hyukjin.kwon/workspace/forked/spark/python/pyspark/sql/pandas/utils.py", line 27, in require_minimum_pandas_version
import pandas
ModuleNotFoundError: No module named 'pandas'
```
PySpark tests should pass without optional dependencies.
### Does this PR introduce _any_ user-facing change?
No, test-only.
### How was this patch tested?
Manually ran as described above.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #42676: [SPARK-44961][PYTHON][TESTS] Make PySpark (pyspark-connect module) tests passing without any dependency
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #42676:
URL: https://github.com/apache/spark/pull/42676#discussion_r1305276723
##########
python/pyspark/sql/connect/streaming/query.py:
##########
@@ -33,8 +36,6 @@
StreamingQueryException as CapturedStreamingQueryException,
)
-__all__ = ["StreamingQuery", "StreamingQueryManager"]
Review Comment:
All `connect` is an internal module. So I we don't need this
##########
python/pyspark/sql/connect/streaming/__init__.py:
##########
@@ -14,9 +14,3 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#
-
-from pyspark.sql.connect.streaming.query import StreamingQuery # noqa: F401
-from pyspark.sql.connect.streaming.readwriter import DataStreamReader # noqa: F401
-from pyspark.sql.connect.streaming.readwriter import DataStreamWriter # noqa: F401
-from pyspark.sql.connect.streaming.query import StreamingQueryManager # noqa: F401
-from pyspark.errors import StreamingQueryException # noqa: F401
Review Comment:
All `connect` is an internal module. So I we don't need this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #42676: [SPARK-44961][PYTHON][CONNECT][TESTS] Make PySpark (pyspark-connect module) tests passing without any dependency
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #42676:
URL: https://github.com/apache/spark/pull/42676#issuecomment-1693768004
I verified manually. Thank you, @HyukjinKwon and @zhengruifeng .
Merged to master according to the affected version of JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #42676: [SPARK-44961][PYTHON][CONNECT][TESTS] Make PySpark (pyspark-connect module) tests passing without any dependency
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #42676: [SPARK-44961][PYTHON][CONNECT][TESTS] Make PySpark (pyspark-connect module) tests passing without any dependency
URL: https://github.com/apache/spark/pull/42676
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org