You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/04/12 02:58:36 UTC

[GitHub] [incubator-kyuubi] Nick-0723 commented on a diff in pull request #2324: [SUB-TASK][KPIP-4] Implement SparkBatchProcessBuilder to submit spark batch job

Nick-0723 commented on code in PR #2324:
URL: https://github.com/apache/incubator-kyuubi/pull/2324#discussion_r847899535


##########
kyuubi-common/src/main/scala/org/apache/kyuubi/util/KyuubiHadoopUtils.scala:
##########
@@ -42,8 +42,16 @@ object KyuubiHadoopUtils {
 
   def newHadoopConf(
       conf: KyuubiConf,
-      loadDefaults: Boolean = true): Configuration = {
+      loadDefaults: Boolean = true,
+      engineEnv: Boolean = false): Configuration = {
     val hadoopConf = new Configuration(loadDefaults)
+    if (engineEnv) {
+      conf.getEnvs.get("HADOOP_CONF_DIR").foreach { hadoopConfDir =>

Review Comment:
   Great, I saw this issue too, waiting for you to merge to master 😄 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org