[GitHub] [pulsar] eolivelli commented on a change in pull request #9091: fix BKIncorrectParameterException

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #9091:
URL: https://github.com/apache/pulsar/pull/9091#discussion_r549954153



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/intercept/ManagedLedgerInterceptorImpl.java
##########
@@ -83,9 +83,9 @@ public void onManagedLedgerPropertiesInitialize(Map<String, String> propertiesMa
     public void onManagedLedgerLastLedgerInitialize(String name, LedgerHandle lh) {
         try {
             for (BrokerEntryMetadataInterceptor interceptor : brokerEntryMetadataInterceptors) {
-                if (interceptor instanceof AppendIndexMetadataInterceptor) {
+                if (interceptor instanceof AppendIndexMetadataInterceptor && lh.getLastAddConfirmed() >= 0) {

Review comment:
       Using instanceof is a bad practice, not Object oriented.
   
   It is not in the scope of this PR but it would be better to have a more OO approach, using polymorphism 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org