You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2015/12/09 20:59:55 UTC

Review Request 41148: Ranger env files are incorrectly sourced on EU

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41148/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.


Bugs: AMBARI-14299
    https://issues.apache.org/jira/browse/AMBARI-14299


Repository: ambari


Description
-------

Unused configs are getting copied over as part of the normal package distribution (making versioned conf directory, and copying all files to it).  As a result, the upgrade for NN containing ranger should remove that file per the Ranger folks.


Diffs
-----

  ambari-common/src/main/python/resource_management/libraries/functions/version.py 1de6bf8 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py 622dcba 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 0c2f046 
  ambari-server/src/test/python/stacks/2.0.6/configs/nn_eu.json PRE-CREATION 

Diff: https://reviews.apache.org/r/41148/diff/


Testing
-------

Manual EU/RU testing.  Automated:

----------------------------------------------------------------------
Total run:849
Total errors:0
Total failures:0
OK


Thanks,

Nate Cole

Re: Review Request 41148: Ranger env files are incorrectly sourced on EU

Posted by Jonathan Hurley <jh...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41148/#review109599
-----------------------------------------------------------

Ship it!



ambari-common/src/main/python/resource_management/libraries/functions/version.py (line 63)
<https://reviews.apache.org/r/41148/#comment169189>

    Nice!


- Jonathan Hurley


On Dec. 9, 2015, 2:59 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41148/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2015, 2:59 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-14299
>     https://issues.apache.org/jira/browse/AMBARI-14299
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Unused configs are getting copied over as part of the normal package distribution (making versioned conf directory, and copying all files to it).  As a result, the upgrade for NN containing ranger should remove that file per the Ranger folks.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/version.py 1de6bf8 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py 622dcba 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 0c2f046 
>   ambari-server/src/test/python/stacks/2.0.6/configs/nn_eu.json PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41148/diff/
> 
> 
> Testing
> -------
> 
> Manual EU/RU testing.  Automated:
> 
> ----------------------------------------------------------------------
> Total run:849
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 41148: Ranger env files are incorrectly sourced on EU

Posted by Nate Cole <nc...@hortonworks.com>.


> On Dec. 9, 2015, 4:37 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py, line 65
> > <https://reviews.apache.org/r/41148/diff/1/?file=1157265#file1157265line65>
> >
> >     Just to make sure, this is 2.3+ and not 2.3.0?

2.3+.  Conceivably there will be a 2.2->2.4 and that would have the same issue.


- Nate


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41148/#review109603
-----------------------------------------------------------


On Dec. 9, 2015, 2:59 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41148/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2015, 2:59 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-14299
>     https://issues.apache.org/jira/browse/AMBARI-14299
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Unused configs are getting copied over as part of the normal package distribution (making versioned conf directory, and copying all files to it).  As a result, the upgrade for NN containing ranger should remove that file per the Ranger folks.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/version.py 1de6bf8 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py 622dcba 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 0c2f046 
>   ambari-server/src/test/python/stacks/2.0.6/configs/nn_eu.json PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41148/diff/
> 
> 
> Testing
> -------
> 
> Manual EU/RU testing.  Automated:
> 
> ----------------------------------------------------------------------
> Total run:849
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 41148: Ranger env files are incorrectly sourced on EU

Posted by Alejandro Fernandez <af...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41148/#review109603
-----------------------------------------------------------

Ship it!



ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py (line 65)
<https://reviews.apache.org/r/41148/#comment169191>

    Just to make sure, this is 2.3+ and not 2.3.0?


- Alejandro Fernandez


On Dec. 9, 2015, 7:59 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41148/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2015, 7:59 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-14299
>     https://issues.apache.org/jira/browse/AMBARI-14299
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Unused configs are getting copied over as part of the normal package distribution (making versioned conf directory, and copying all files to it).  As a result, the upgrade for NN containing ranger should remove that file per the Ranger folks.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/version.py 1de6bf8 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py 622dcba 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 0c2f046 
>   ambari-server/src/test/python/stacks/2.0.6/configs/nn_eu.json PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41148/diff/
> 
> 
> Testing
> -------
> 
> Manual EU/RU testing.  Automated:
> 
> ----------------------------------------------------------------------
> Total run:849
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Nate Cole
> 
>