You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2015/04/09 20:03:58 UTC
Review Request 33026: Revert "Make health check configurable"
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33026/
-----------------------------------------------------------
Review request for Aurora, Brian Brazil and Kevin Sweeney.
Bugs: AURORA-1266
https://issues.apache.org/jira/browse/AURORA-1266
Repository: aurora
Description
-------
This reverts commit 27a602d2c9efdd1cd2591c9c754f086c04ad0eb9.
Diffs
-----
docs/configuration-reference.md fb753ead94fcd1ed76352306391d356652934a4e
src/main/python/apache/aurora/common/http_signaler.py 531f1fecbcbf8015175c7f1cb1e1c4d3e7d1268a
src/main/python/apache/aurora/config/schema/base.py ec9f983564516afe542ab277d987d4d391f87e45
src/main/python/apache/aurora/executor/common/health_checker.py 03fdf0afef120c365c6ffad09e152780eed7e351
src/test/python/apache/aurora/common/test_http_signaler.py c6a21708eb997f213f4cca038891a84f6c5218d4
src/test/python/apache/aurora/executor/common/test_health_checker.py 27c71711d52f757ed1552db4accda671a6bdafdd
Diff: https://reviews.apache.org/r/33026/diff/
Testing
-------
Thanks,
Bill Farner
Re: Review Request 33026: Revert "Make health check configurable"
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33026/#review79542
-----------------------------------------------------------
Master (6384710) is red with this patch.
./build-support/jenkins/build.sh
:check
:build
:api:assemble
:api:compileTestJava UP-TO-DATE
:api:processTestResources UP-TO-DATE
:api:testClasses UP-TO-DATE
:api:test UP-TO-DATE
:api:check UP-TO-DATE
:api:build
:buildSrc:compileJava UP-TO-DATE
:buildSrc:processResources UP-TO-DATE
:buildSrc:classes UP-TO-DATE
:buildSrc:jar
:buildSrc:assemble
:buildSrc:compileTestJava UP-TO-DATE
:buildSrc:processTestResources UP-TO-DATE
:buildSrc:testClasses UP-TO-DATE
:buildSrc:test UP-TO-DATE
:buildSrc:check UP-TO-DATE
:buildSrc:build
BUILD SUCCESSFUL
Total time: 4 mins 2.865 secs
+ export PIP_DEFAULT_TIMEOUT=60
+ PIP_DEFAULT_TIMEOUT=60
+ mkdir -p third_party
+ pip install -d third_party -r /dev/fd/63
++ grep -v mesos.native 3rdparty/python/requirements.txt
Downloading/unpacking bottle==0.11.6 (from -r /dev/fd/63 (line 1))
Saved ./third_party/bottle-0.11.6-py2.py3-none-any.whl
Downloading/unpacking CherryPy==3.6.0 (from -r /dev/fd/63 (line 2))
pip can't proceed with requirement 'CherryPy==3.6.0 (from -r /dev/fd/63 (line 2))' due to a pre-existing build directory.
location: /tmp/user/2395/pip_build_jenkins/CherryPy
This is likely due to a previous installation that failed.
pip is being responsible and not assuming it can delete this.
Please delete it and try again.
Storing debug log for failure in /home/jenkins/.pip/pip.log
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On April 9, 2015, 6:03 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33026/
> -----------------------------------------------------------
>
> (Updated April 9, 2015, 6:03 p.m.)
>
>
> Review request for Aurora, Brian Brazil and Kevin Sweeney.
>
>
> Bugs: AURORA-1266
> https://issues.apache.org/jira/browse/AURORA-1266
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This reverts commit 27a602d2c9efdd1cd2591c9c754f086c04ad0eb9.
>
>
> Diffs
> -----
>
> docs/configuration-reference.md fb753ead94fcd1ed76352306391d356652934a4e
> src/main/python/apache/aurora/common/http_signaler.py 531f1fecbcbf8015175c7f1cb1e1c4d3e7d1268a
> src/main/python/apache/aurora/config/schema/base.py ec9f983564516afe542ab277d987d4d391f87e45
> src/main/python/apache/aurora/executor/common/health_checker.py 03fdf0afef120c365c6ffad09e152780eed7e351
> src/test/python/apache/aurora/common/test_http_signaler.py c6a21708eb997f213f4cca038891a84f6c5218d4
> src/test/python/apache/aurora/executor/common/test_health_checker.py 27c71711d52f757ed1552db4accda671a6bdafdd
>
> Diff: https://reviews.apache.org/r/33026/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 33026: Revert "Make health check configurable"
Posted by Joshua Cohen <jc...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33026/#review79541
-----------------------------------------------------------
Ship it!
Ship It!
- Joshua Cohen
On April 9, 2015, 6:03 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33026/
> -----------------------------------------------------------
>
> (Updated April 9, 2015, 6:03 p.m.)
>
>
> Review request for Aurora, Brian Brazil and Kevin Sweeney.
>
>
> Bugs: AURORA-1266
> https://issues.apache.org/jira/browse/AURORA-1266
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This reverts commit 27a602d2c9efdd1cd2591c9c754f086c04ad0eb9.
>
>
> Diffs
> -----
>
> docs/configuration-reference.md fb753ead94fcd1ed76352306391d356652934a4e
> src/main/python/apache/aurora/common/http_signaler.py 531f1fecbcbf8015175c7f1cb1e1c4d3e7d1268a
> src/main/python/apache/aurora/config/schema/base.py ec9f983564516afe542ab277d987d4d391f87e45
> src/main/python/apache/aurora/executor/common/health_checker.py 03fdf0afef120c365c6ffad09e152780eed7e351
> src/test/python/apache/aurora/common/test_http_signaler.py c6a21708eb997f213f4cca038891a84f6c5218d4
> src/test/python/apache/aurora/executor/common/test_health_checker.py 27c71711d52f757ed1552db4accda671a6bdafdd
>
> Diff: https://reviews.apache.org/r/33026/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 33026: Revert "Make health check configurable"
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33026/#review79540
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Sweeney
On April 9, 2015, 11:03 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33026/
> -----------------------------------------------------------
>
> (Updated April 9, 2015, 11:03 a.m.)
>
>
> Review request for Aurora, Brian Brazil and Kevin Sweeney.
>
>
> Bugs: AURORA-1266
> https://issues.apache.org/jira/browse/AURORA-1266
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This reverts commit 27a602d2c9efdd1cd2591c9c754f086c04ad0eb9.
>
>
> Diffs
> -----
>
> docs/configuration-reference.md fb753ead94fcd1ed76352306391d356652934a4e
> src/main/python/apache/aurora/common/http_signaler.py 531f1fecbcbf8015175c7f1cb1e1c4d3e7d1268a
> src/main/python/apache/aurora/config/schema/base.py ec9f983564516afe542ab277d987d4d391f87e45
> src/main/python/apache/aurora/executor/common/health_checker.py 03fdf0afef120c365c6ffad09e152780eed7e351
> src/test/python/apache/aurora/common/test_http_signaler.py c6a21708eb997f213f4cca038891a84f6c5218d4
> src/test/python/apache/aurora/executor/common/test_health_checker.py 27c71711d52f757ed1552db4accda671a6bdafdd
>
> Diff: https://reviews.apache.org/r/33026/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>