[GitHub] [helix] narendly commented on a change in pull request #543: Change change detector to a regular field in the WAGED rebalancer instead of static threadlocal.

[GitBox <gi...@apache.org>]

narendly commented on a change in pull request #543: Change change detector to a regular field in the WAGED rebalancer instead of static threadlocal.
URL: https://github.com/apache/helix/pull/543#discussion_r339281569
 
 

 ##########
 File path: helix-core/src/test/java/org/apache/helix/controller/rebalancer/waged/TestWagedRebalancer.java
 ##########
 @@ -423,15 +426,16 @@ public void testRebalanceOnChanges() throws IOException, HelixRebalanceException
     // assignment since there is only current state change.
     newIdealStates =
         rebalancer.computeNewIdealStates(clusterData, resourceMap, new CurrentStateOutput());
-    algorithmResult = _algorithm.getRebalanceResult();
+    Map<String, ResourceAssignment> newAlgorithmResult = _algorithm.getRebalanceResult();
 
     // Verify that only the changed resource has been included in the calculation.
-    validateRebalanceResult(Collections.emptyMap(), newIdealStates, algorithmResult);
-    // Both assignment state should be empty.
+    validateRebalanceResult(Collections.emptyMap(), newIdealStates, newAlgorithmResult);
+    // There is nothing changes the baseline since only current state changed.
 
 Review comment:
   "There should be no changes in the baseline since only the currentStates changed"?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org