You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bugs@apr.apache.org by bu...@apache.org on 2023/01/04 02:53:04 UTC
[Bug 66408] New: -Wimplicit-function-declaration, -Wimplicit-int warnings in configure
https://bz.apache.org/bugzilla/show_bug.cgi?id=66408
Bug ID: 66408
Summary: -Wimplicit-function-declaration, -Wimplicit-int
warnings in configure
Product: APR
Version: HEAD
Hardware: PC
OS: All
Status: NEW
Severity: normal
Priority: P2
Component: APR
Assignee: bugs@apr.apache.org
Reporter: sam@gentoo.org
Target Milestone: ---
Created attachment 38457
--> https://bz.apache.org/bugzilla/attachment.cgi?id=38457&action=edit
apr.patch
See also bug 66396.
When compiling with a strict C99 compiler (Clang 16 from git)
(-Werror=implicit-int -Werror=implicit-function-declaration, etc), I got:
```
/bin/sh /var/tmp/portage/dev-libs/apr-1.7.0-r5/work/apr-1.7.0/libtool --silent
--mode=compile clang -O2 -pipe -fdiagnostics-color=always
-frecord-gcc-switches -DHAVE_CONFIG_H -DLINUX -D_REENTRANT -D_GNU_SOURCE
-I./include
-I/var/tmp/portage/dev-libs/apr-1.7.0-r5/work/apr-1.7.0/include/arch/unix
-I./include/arch/unix
-I/var/tmp/portage/dev-libs/apr-1.7.0-r5/work/apr-1.7.0/include/arch/unix
-I/var/tmp/portage/dev-libs/apr-1.7.0-r5/work/apr-1.7.0/include
-I/var/tmp/portage/dev-libs/apr-1.7.0-r5/work/apr-1.7.0/include/private
-I/var/tmp/portage/dev-libs/apr-1.7.0-r5/work/apr-1.7.0/include/private -o
poll/unix/pollcb.lo -c poll/unix/pollcb.c && touch poll/unix/pollcb.lo
misc/unix/errorcodes.c:385:9: error: incompatible integer to pointer conversion
assigning to 'const char *' from 'int' [-Wint-conversion]
msg = strerror_r(statcode, buf, bufsize);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
```
This turned out to be because various configure checks deduced the wrong result
with these settings. I've attached a patch.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org
[Bug 66408] -Wimplicit-function-declaration, -Wimplicit-int warnings in configure
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66408
--- Comment #3 from Sam James <sa...@gentoo.org> ---
Just out of caution - totally fine to skip those, I was just going through and
adding them for my own changes, and accidentally-but-then-kept it for existing
lines :)
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org
[Bug 66408] -Wimplicit-function-declaration, -Wimplicit-int warnings in configure
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66408
--- Comment #1 from Sam James <sa...@gentoo.org> ---
(The change in macro order is because some of the checks in the apr_network.m4
file require things which used to be checked _after_).
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org
[Bug 66408] -Wimplicit-function-declaration, -Wimplicit-int warnings in configure
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66408
Joe Orton <jo...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #4 from Joe Orton <jo...@redhat.com> ---
OK, thanks - did skip those bits. Merged to trunk/1.7 - r1906594 / r1906595.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org
[Bug 66408] -Wimplicit-function-declaration, -Wimplicit-int warnings in configure
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66408
--- Comment #2 from Joe Orton <jo...@redhat.com> ---
Thanks, Sam. Are the new #ifdefs for <stdio.h> and <stdlib.h> necessary or you
added them out of caution?
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org
[Bug 66408] -Wimplicit-function-declaration, -Wimplicit-int warnings in configure
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66408
Florian Weimer <fw...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fweimer@redhat.com
--- Comment #5 from Florian Weimer <fw...@redhat.com> ---
Sorry, I ran into one more issue while finally building 1.7 for Fedora, filed
as bug 66426.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org