You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/12/25 04:09:36 UTC

[GitHub] [calcite] danny0405 commented on a change in pull request #1686: [CALCITE-3630] Improve ReduceExpressionsRule

danny0405 commented on a change in pull request #1686: [CALCITE-3630] Improve ReduceExpressionsRule
URL: https://github.com/apache/calcite/pull/1686#discussion_r361251853
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/rel/rules/ReduceExpressionsRule.java
 ##########
 @@ -270,6 +270,8 @@ private void reduceNotNullableFilter(
           } else {
             call.transformTo(createEmptyRelOrEquivalent(call, filter));
           }
+          // New plan is absolutely better than old plan.
+          call.getPlanner().setImportance(filter, 0.0);
 
 Review comment:
   `setImportance(filter, 0.0)` is not suggested to be used, i kind of remember see https://issues.apache.org/jira/browse/CALCITE-2223

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services