You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "davsclaus (via GitHub)" <gi...@apache.org> on 2026/10/08 07:19:28 UTC

[PR] CAMEL-25438: camel-jbang - monitor tabs do not wait behind data loads of hidden tabs [camel]

davsclaus opened a new pull request, #27544:
URL: https://github.com/apache/camel/pull/27544

   https://issues.apache.org/jira/browse/CAMEL-25438
   
   Tabs of the camel-jbang monitor that ask the selected integration for data (Threads, Beans, Startup, Type Converters, Diagram, JFR) stayed on "Loading…" for 2–5 s after selecting an integration, and longer when switching between them.
   
   **Measured** with 4 apps and 7 infra services, recording the actions the monitor writes:
   - an action takes ~1 s whatever its size: the CLI connector looks for one per 1 s loop;
   - the monitor sends one action at a time per integration;
   - selecting an integration sent 4 actions for tabs that were **not shown**: `jvm` 3 times (Classpath, CVE Audit and Maven Dependencies each loaded the classpath in `onIntegrationChanged`) and `route-structure` (Catalog);
   - the tab the user opened waited behind them. Beans asked for at 0.3 s was answered at 3.6 s; Startup asked for at 4.7 s at 8.6 s.
   
   **Fix:**
   - Classpath, CVE Audit, Maven Dependencies and Catalog no longer load in `onIntegrationChanged`; they load when shown, which `onTabSelected` already did.
   - `TabRegistry.resetIntegrationTabState` calls `onTabSelected` on the More tab on screen, so it still loads for the new integration.
   - `MonitorContext.jvmInfo(pid)` keeps the `jvm` answer per integration for 30 s, shared by Classpath, CVE Audit (which asked twice per scan), Maven Dependencies and Heap Histogram.
   
   **After:** selecting an integration sends no action. Opening the tabs took 0.9–2.2 s in a run with 2 apps; most of what is left is the connector's 1 s loop.
   
   **Tests:** `MonitorTabLazyLoadTest`. Hidden tabs send nothing on an integration change and load when shown; it fails without the fix. The `jvm` answer is shared per integration. To create a real `TuiRunner` there, the `NoopBackend` stand-in moved out of `TuiBackendHelperRecordingTest` into its own test class, and the new test is `@Isolated`, as the other tests with a runner are. All 1790 monitor tests pass.
   
   πŸ€– Generated with [Claude Code](https://claude.com/claude-code)
   
   https://claude.ai/code/session_01STT6whBgK1AqsSsUKrnE8m


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CAMEL-25438: camel-jbang - monitor tabs do not wait behind data loads of hidden tabs [camel]

Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #27544:
URL: https://github.com/apache/camel/pull/27544


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CAMEL-25438: camel-jbang - monitor tabs do not wait behind data loads of hidden tabs [camel]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27544:
URL: https://github.com/apache/camel/pull/27544#issuecomment-6054768345

   :star2: Thank you for your contribution to the Apache Camel project! :star2:
     :robot: CI automation will test this PR automatically.
   
     :camel: Apache Camel Committers, please review the following items:
   
     * First-time contributors **require MANUAL approval** for the GitHub Actions to run
     * You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot although they are normally detected and executed by CI.
     * You can label PRs using `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
     * Build and test logs are available in the summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
     
     :warning: Be careful when sharing logs. Review their contents before sharing them publicly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CAMEL-25438: camel-jbang - monitor tabs do not wait behind data loads of hidden tabs [camel]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27544:
URL: https://github.com/apache/camel/pull/27544#issuecomment-6055025950

   <!-- ci-tested-modules -->
   :test_tube: **CI tested the following changed modules:**
   
   - `dsl/camel-jbang/camel-jbang-plugin-tui`
   
   ---
   
   <details><summary>:microscope: Scalpel shadow comparison β€” Scalpel: 2 of 700 tested, 1 compile-only β€” current: 2 all tested</summary>
   
   [Maveniverse Scalpel](https://github.com/maveniverse/scalpel) detected **2 affected modules** (current approach: 2).
   
   **Skip-tests mode would test 2 modules** (1 direct + 1 downstream), **skip tests for 1** (generated code, meta-modules)
   
   <details><summary>Modules Scalpel would test (2)</summary>
   
   - `camel-jbang-plugin-tui` ← dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/CatalogTab.java, dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/ClasspathTab.java, dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/CveAuditTab.java, dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/HeapHistogramTab.java, dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/MavenDependenciesTab.java, dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/MonitorContext.java, dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/TabRegistry.java, dsl/camel-jbang/camel-jbang-plugin-tui/src/test/java/org/apache/camel/dsl/jbang/core/commands/tui/MonitorTabLazyLoadTest.java, dsl/came
 l-jbang/camel-jbang-plugin-tui/src/test/java/org/apache/camel/dsl/jbang/core/commands/tui/NoopBackend.java, dsl/camel-jbang/camel-jbang-plugin-tui/src/test/java/org/apache/camel/dsl/jbang/core/commands/tui/TuiBackendHelperRecordingTest.java
   - `camel-launcher-container` ← downstream of org.apache.camel:camel-launcher
   
   </details>
   
   <details><summary>Modules with tests skipped (1)</summary>
   
   - `camel-launcher`
   
   </details>
   
   > :information_source: Shadow mode β€” Scalpel observes but does not affect test execution. [Learn more](https://github.com/maveniverse/scalpel)
   
   </details>
   
   <details><summary>All tested modules (3 modules, 1m 27s total)</summary>
   
   **Total reactor time:** 1m 27s
   
   | Module | Duration | Status |
   | --- | --- | --- |
   | Camel :: JBang :: Plugin :: TUI | 49.4s | SUCCESS |
   | Camel :: Launcher | 37.0s | SUCCESS |
   | Camel :: Launcher :: Container | 0.9s | SUCCESS |
   
   **Top 20 slowest modules:**
   - `Camel :: JBang :: Plugin :: TUI` (49.4s)
   - `Camel :: Launcher` (37.0s)
   - `Camel :: Launcher :: Container` (0.9s)
   
   </details>
   
   ---
   :gear: [View full build and test results](https://github.com/apache/camel/actions/runs/37742724657)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org