[jira] [Updated] (LUCENE-6640) Remove dependency of lucene/suggest on oal.search.Filter

["Adrien Grand (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/LUCENE-6640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrien Grand updated LUCENE-6640:
---------------------------------
    Attachment: LUCENE-6640.patch

Here is a proposal: add a new API called {{BitsProducer}} with the following definition:

{code}
/** A producer of {@link Bits} per segment. */
public abstract class BitsProducer {

  /** Return {@link Bits} for the given leaf. The returned instance must
   *  be non-null and have a {@link Bits#length() length} equal to
   *  {@link LeafReader#maxDoc() maxDoc}. */
  public abstract Bits getBits(LeafReaderContext context) throws IOException;

}
{code}

And use it in lieu of Filter. Tests pass and I think it has the benefit of making the API a bit less trappy in the sense that it's now obvious that random-access is required?

> Remove dependency of lucene/suggest on oal.search.Filter
> --------------------------------------------------------
>
>                 Key: LUCENE-6640
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6640
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>         Attachments: LUCENE-6640.patch
>
>
> oal.search.Filter is on the way out, yet the suggest module is still using it in order to filter suggestions and it can't be replaced with queries given that true (out-of-order) random access is required.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org