You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@uniffle.apache.org by GitBox <gi...@apache.org> on 2023/01/09 03:30:05 UTC

[GitHub] [incubator-uniffle] xianjingfeng opened a new issue, #460: [Improvement] Exit on OutOfMemoryError

xianjingfeng opened a new issue, #460:
URL: https://github.com/apache/incubator-uniffle/issues/460

   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   
   
   ### Search before asking
   
   - [X] I have searched in the [issues](https://github.com/apache/incubator-uniffle/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### What would you like to be improved?
   
   At present, if OutOfMemoryError is encountered, server will not exit.
   
   ### How should we improve?
   
   Add `-XX:+ExitOnOutOfMemoryError` and `-XX:+CrashOnOutOfMemoryError` to JVM argments.
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-uniffle] jerqi commented on issue #460: [Improvement] Exit on OutOfMemoryError

Posted by GitBox <gi...@apache.org>.
jerqi commented on issue #460:
URL: https://github.com/apache/incubator-uniffle/issues/460#issuecomment-1375067843

   > PTAL @jerqi @zuston @advancedxy
   
   Do we need dump the memory when OOM occurs。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-uniffle] jerqi commented on issue #460: [Improvement] Exit on OutOfMemoryError

Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on issue #460:
URL: https://github.com/apache/incubator-uniffle/issues/460#issuecomment-1475262296

   > Requesting permission to contribute to this feature. . Can you please advise on how I can get involved? Thanks
   I assign this issue to you.
   
   @AdarshRawat1 You can refer to https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
   If you have any question, you can ask me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-uniffle] jerqi commented on issue #460: [Improvement] Exit on OutOfMemoryError

Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on issue #460:
URL: https://github.com/apache/incubator-uniffle/issues/460#issuecomment-1512946641

   @AdarshRawat1 Do you need any other help from me?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-uniffle] xianjingfeng commented on issue #460: [Improvement] Exit on OutOfMemoryError

Posted by GitBox <gi...@apache.org>.
xianjingfeng commented on issue #460:
URL: https://github.com/apache/incubator-uniffle/issues/460#issuecomment-1375139463

   > > PTAL @jerqi @zuston @advancedxy
   > 
   > Do we need dump the memory when OOM occurs？
   
   The dump file maybe too big and disk space may be not enough to store it. So users should specify the path to store it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-uniffle] AdarshRawat1 commented on issue #460: [Improvement] Exit on OutOfMemoryError

Posted by "AdarshRawat1 (via GitHub)" <gi...@apache.org>.
AdarshRawat1 commented on issue #460:
URL: https://github.com/apache/incubator-uniffle/issues/460#issuecomment-1668091966

   @jerqi I apologize, but I'm unable to work on this issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org

[GitHub] [incubator-uniffle] jerqi commented on issue #460: [Improvement] Exit on OutOfMemoryError

Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on issue #460:
URL: https://github.com/apache/incubator-uniffle/issues/460#issuecomment-1667917093

   > @jerqi I deeply regret the delay and will commence work on it today. I look forward to receiving your guidance throughout the process.
   
   Need help?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org

[GitHub] [incubator-uniffle] zuston commented on issue #460: [Improvement] Exit on OutOfMemoryError

Posted by GitBox <gi...@apache.org>.
zuston commented on issue #460:
URL: https://github.com/apache/incubator-uniffle/issues/460#issuecomment-1375423608

   > The bin/start-shuffle-server.sh may handle that as a cli argument or env variable.
   
   Good idea. This should be supported.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-uniffle] jerqi commented on issue #460: [Improvement] Exit on OutOfMemoryError

Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on issue #460:
URL: https://github.com/apache/incubator-uniffle/issues/460#issuecomment-1666383877

   > > @AdarshRawat1 Do you need any other help from me?
   > 
   > @jerqi I’m currently occupied with my mid-term exams. Once I’m done with them, I’ll address this issue. I would appreciate your valuable guidance at that time. Thank you.
   
   @AdarshRawat1 Do you want to continue this issue?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org

[GitHub] [incubator-uniffle] AdarshRawat1 commented on issue #460: [Improvement] Exit on OutOfMemoryError

Posted by "AdarshRawat1 (via GitHub)" <gi...@apache.org>.
AdarshRawat1 commented on issue #460:
URL: https://github.com/apache/incubator-uniffle/issues/460#issuecomment-1512960137

   > @AdarshRawat1 Do you need any other help from me?
   
    @jerqi  I’m currently occupied with my mid-term exams. Once I’m done with them, I’ll address this issue. I would appreciate your valuable guidance at that time. Thank you. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-uniffle] xianjingfeng commented on issue #460: [Improvement] Exit on OutOfMemoryError

Posted by GitBox <gi...@apache.org>.
xianjingfeng commented on issue #460:
URL: https://github.com/apache/incubator-uniffle/issues/460#issuecomment-1375065814

   PTAL @jerqi @zuston @advancedxy 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-uniffle] AdarshRawat1 commented on issue #460: [Improvement] Exit on OutOfMemoryError

Posted by "AdarshRawat1 (via GitHub)" <gi...@apache.org>.
AdarshRawat1 commented on issue #460:
URL: https://github.com/apache/incubator-uniffle/issues/460#issuecomment-1666405449

   @jerqi I deeply regret the delay and will commence work on it today. I look forward to receiving your guidance throughout the process.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org

[GitHub] [incubator-uniffle] advancedxy commented on issue #460: [Improvement] Exit on OutOfMemoryError

Posted by GitBox <gi...@apache.org>.
advancedxy commented on issue #460:
URL: https://github.com/apache/incubator-uniffle/issues/460#issuecomment-1375149205

   > > > PTAL @jerqi @zuston @advancedxy
   > > 
   > > 
   > > Do we need dump the memory when OOM occurs？
   > 
   > The dump file maybe too big and disk space may be not enough to store it. So users should specify the path to store it.
   
   +1 from my side. oom dump should be an opt-in feature. The bin/start-shuffle-server.sh may handle that as a cli argument or env variable.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Improvement] Exit on OutOfMemoryError [incubator-uniffle]

Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston closed issue #460: [Improvement]  Exit on OutOfMemoryError
URL: https://github.com/apache/incubator-uniffle/issues/460


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org

[GitHub] [incubator-uniffle] jerqi commented on issue #460: [Improvement] Exit on OutOfMemoryError

Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on issue #460:
URL: https://github.com/apache/incubator-uniffle/issues/460#issuecomment-1475500734

   1. files to change
   https://github.com/apache/incubator-uniffle/blob/master/bin/start-coordinator.sh
   https://github.com/apache/incubator-uniffle/blob/master/bin/start-shuffle-server.sh
   2.test to perform
   You build package and unzip it, set environment variable (JAVA_HOME and HADOOP_HOME) and run the cmd
   `sh bin/start-shuffle-server.sh` and `sh bin/start-coordinator.sh`. If the process start successfully, the change is ok.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-uniffle] AdarshRawat1 commented on issue #460: [Improvement] Exit on OutOfMemoryError

Posted by "AdarshRawat1 (via GitHub)" <gi...@apache.org>.
AdarshRawat1 commented on issue #460:
URL: https://github.com/apache/incubator-uniffle/issues/460#issuecomment-1475260332

   ![image](https://user-images.githubusercontent.com/100958893/226178946-c0aa7f3e-b1dd-46c2-8419-5d038ee14f4f.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-uniffle] AdarshRawat1 commented on issue #460: [Improvement] Exit on OutOfMemoryError

Posted by "AdarshRawat1 (via GitHub)" <gi...@apache.org>.
AdarshRawat1 commented on issue #460:
URL: https://github.com/apache/incubator-uniffle/issues/460#issuecomment-1475319107

   Could you kindly provide me with additional resources and guidance [files to change, Tests to perform], please?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org