[jira] [Work logged] (BEAM-1763) TestPipeline should ensure that all assertions succeeded

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-1763?focusedWorklogId=84063&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-84063 ]

ASF GitHub Bot logged work on BEAM-1763:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 24/Mar/18 17:25
            Start Date: 24/Mar/18 17:25
    Worklog Time Spent: 10m 
      Work Description: aviemzur closed pull request #3807: [BEAM-1763] Ensure run waitUntilFinish in TestPipeline.
URL: https://github.com/apache/beam/pull/3807
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/testing/TestPipeline.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/testing/TestPipeline.java
index be2f193ea93..8f3664534c2 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/testing/TestPipeline.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/testing/TestPipeline.java
@@ -354,6 +354,7 @@ public PipelineResult run(PipelineOptions options) {
           .as(TestValueProviderOptions.class)
           .setProviderRuntimeValues(StaticValueProvider.of(providerRuntimeValues));
       pipelineResult = super.run(updatedOptions);
+      pipelineResult.waitUntilFinish();
       verifyPAssertsSucceeded(this, pipelineResult);
     } catch (RuntimeException exc) {
       Throwable cause = exc.getCause();


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 84063)
    Time Spent: 20m  (was: 10m)

> TestPipeline should ensure that all assertions succeeded
> --------------------------------------------------------
>
>                 Key: BEAM-1763
>                 URL: https://issues.apache.org/jira/browse/BEAM-1763
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-java-core
>            Reporter: Thomas Groh
>            Assignee: Aviem Zur
>            Priority: Major
>             Fix For: 2.0.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> This doesn't need to be part of each {{PipelineRunner}} implementation if it goes through the {{PipelineResult}} APIs. The assertion can be of the form that if the Pipeline is finished, then the number of successful assertions is equal to the total number of assertions.
> Suggested solution:
> For runners which support metrics, use the counters for successful/failed assertions and compare them to expected number of assertions.
> Runners which do not support metrics should either implement metrics or override {{PAssert}} in a way that verifies its execution.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)