You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@asterixdb.apache.org by mb...@apache.org on 2026/10/09 13:57:12 UTC

(asterixdb) 06/08: [NO ISSUE][CONF] Expose compiler.externalscanmemory

This is an automated email from the ASF dual-hosted git repository.

asf-gitbox-commits pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/asterixdb.git

commit b5aa4cf8c8d078b61df580247aad71d48b0ca5c2
Author: Michael Blow <mi...@couchbase.com>
AuthorDate: Thu Oct 8 11:46:18 2026 -0400

    [NO ISSUE][CONF] Expose compiler.externalscanmemory
    
    - user model changes: no
    - storage format changes: no
    - interface changes: no
    
    Details: compiler.externalscanmemory has been hidden since it was made
    configurable, so the config and cluster APIs omitted it although it is
    an ordinary per-partition memory budget, settable like the other
    compiler memory options. Stop hiding it.
    
    Ext-ref: MB-74493
    Generated-by: Claude Opus 5.5 <no...@anthropic.com>
    Change-Id: Ic73bbc7ec158c2d2cfb04aa9b4b11cc910c4738c
    Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/22034
    Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
    Reviewed-by: Ali Alsuliman <al...@gmail.com>
---
 .../runtimets/results/api/cluster_state_1/cluster_state_1.1.regexadm    | 1 +
 .../results/api/cluster_state_1_full/cluster_state_1_full.1.regexadm    | 1 +
 .../results/api/cluster_state_1_less/cluster_state_1_less.1.regexadm    | 1 +
 .../main/java/org/apache/asterix/common/config/CompilerProperties.java  | 2 +-
 4 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.regexadm b/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.regexadm
index be8ee4a1a8..566926438b 100644
--- a/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.regexadm
+++ b/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.regexadm
@@ -61,6 +61,7 @@
     "compiler.disjunction.as.join" : false,
     "compiler.disjunction.hash.threshold" : 40,
     "compiler\.external\.field\.pushdown" : true,
+    "compiler.externalscanmemory" : 8192,
     "compiler.extract.common.expression.limit" : 100,
     "compiler.forcejoinorder" : false,
     "compiler\.framesize" : 32768,
diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_full/cluster_state_1_full.1.regexadm b/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_full/cluster_state_1_full.1.regexadm
index 129be13ab7..c52a337af0 100644
--- a/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_full/cluster_state_1_full.1.regexadm
+++ b/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_full/cluster_state_1_full.1.regexadm
@@ -61,6 +61,7 @@
     "compiler.disjunction.as.join" : false,
     "compiler.disjunction.hash.threshold" : 40,
     "compiler.external.field.pushdown" : true,
+    "compiler.externalscanmemory" : 8192,
     "compiler.extract.common.expression.limit" : 100,
     "compiler.forcejoinorder" : false,
     "compiler\.framesize" : 32768,
diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_less/cluster_state_1_less.1.regexadm b/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_less/cluster_state_1_less.1.regexadm
index 32a395c018..8753da8d4a 100644
--- a/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_less/cluster_state_1_less.1.regexadm
+++ b/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_less/cluster_state_1_less.1.regexadm
@@ -61,6 +61,7 @@
     "compiler.disjunction.as.join" : false,
     "compiler.disjunction.hash.threshold" : 40,
     "compiler\.external\.field\.pushdown" : true,
+    "compiler.externalscanmemory" : 8192,
     "compiler.extract.common.expression.limit" : 100,
     "compiler.forcejoinorder" : false,
     "compiler\.framesize" : 32768,
diff --git a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/CompilerProperties.java b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/CompilerProperties.java
index 75741d443b..e828cc8055 100644
--- a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/CompilerProperties.java
+++ b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/CompilerProperties.java
@@ -238,7 +238,7 @@ public class CompilerProperties extends AbstractProperties {
 
         @Override
         public boolean hidden() {
-            return this == COMPILER_EXTERNALSCANMEMORY || this == COMPILER_CBOTEST;
+            return this == COMPILER_CBOTEST;
         }
     }