You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sirona.apache.org by ol...@apache.org on 2014/02/21 05:27:02 UTC
svn commit: r1570443 - in /incubator/sirona/trunk:
agent/javaagent/src/main/java/org/apache/sirona/javaagent/
agent/javaagent/src/main/java/org/apache/sirona/javaagent/listener/
core/src/main/java/org/apache/sirona/tracking/
Author: olamy
Date: Fri Feb 21 04:27:01 2014
New Revision: 1570443
URL: http://svn.apache.org/r1570443
Log:
not a great logging framework but at least small optim :-)
Modified:
incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/SironaAgent.java
incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/SironaTransformer.java
incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/listener/PathTrackingInvocationListener.java
incubator/sirona/trunk/core/src/main/java/org/apache/sirona/tracking/PathTracker.java
Modified: incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/SironaAgent.java
URL: http://svn.apache.org/viewvc/incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/SironaAgent.java?rev=1570443&r1=1570442&r2=1570443&view=diff
==============================================================================
--- incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/SironaAgent.java (original)
+++ incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/SironaAgent.java Fri Feb 21 04:27:01 2014
@@ -111,7 +111,7 @@ public class SironaAgent {
&& instrumentation.isModifiableClass(clazz)) {
try {
- SironaAgentLogging.debug( "reload clazz:" + clazz.getName() );
+ SironaAgentLogging.debug( "reload clazz: {0}", clazz.getName() );
instrumentation.retransformClasses(clazz);
} catch (final Exception e) {
Modified: incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/SironaTransformer.java
URL: http://svn.apache.org/viewvc/incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/SironaTransformer.java?rev=1570443&r1=1570442&r2=1570443&view=diff
==============================================================================
--- incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/SironaTransformer.java (original)
+++ incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/SironaTransformer.java Fri Feb 21 04:27:01 2014
@@ -50,7 +50,7 @@ public class SironaTransformer implement
return classfileBuffer;
} catch (final Exception e) {
if ( SironaAgentLogging.AGENT_DEBUG) {
- SironaAgentLogging.debug( "fail transforming class " + className + ": " + e.getMessage() );
+ SironaAgentLogging.debug( "fail transforming class {0} : {1}", className, e.getMessage() );
e.printStackTrace();
}
throw new RuntimeException( e.getMessage(), e );
Modified: incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/listener/PathTrackingInvocationListener.java
URL: http://svn.apache.org/viewvc/incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/listener/PathTrackingInvocationListener.java?rev=1570443&r1=1570442&r2=1570443&view=diff
==============================================================================
--- incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/listener/PathTrackingInvocationListener.java (original)
+++ incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/listener/PathTrackingInvocationListener.java Fri Feb 21 04:27:01 2014
@@ -40,7 +40,6 @@ public class PathTrackingInvocationListe
@Override
public boolean accept( String key )
{
-
boolean include = super.accept( key );
if ( !include )
{
@@ -48,10 +47,9 @@ public class PathTrackingInvocationListe
}
SironaAgentLogging.debug(
- "PathTrackingInvocationListener#accept, TRACKING_ACTIVATED:" + TRACKING_ACTIVATED + ", key: " + key );
+ "PathTrackingInvocationListener#accept, TRACKING_ACTIVATED: {0}, key: {1}", TRACKING_ACTIVATED, key );
return TRACKING_ACTIVATED;
-
}
/**
@@ -65,7 +63,7 @@ public class PathTrackingInvocationListe
public void before( AgentContext context )
{
- SironaAgentLogging.debug( "PathTrackingInvocationListener#before:" + context.getKey() );
+ SironaAgentLogging.debug( "PathTrackingInvocationListener#before: {0}", context.getKey() );
String key = context.getKey();
@@ -76,6 +74,9 @@ public class PathTrackingInvocationListe
final PathTracker.PathTrackingInformation pathTrackingInformation =
new PathTracker.PathTrackingInformation( className, methodName );
+
+ SironaAgentLogging.debug( "call PathTracker#start with {0}", pathTrackingInformation );
+
context.put( PATH_TRACKER_KEY, PathTracker.start( pathTrackingInformation ) );
}
@@ -90,7 +91,7 @@ public class PathTrackingInvocationListe
public void after( AgentContext context, Object result, Throwable error )
{
- SironaAgentLogging.debug( "PathTrackingInvocationListener#after: " + context.getKey() );
+ SironaAgentLogging.debug( "PathTrackingInvocationListener#after: {0}", context.getKey() );
context.get( PATH_TRACKER_KEY, PathTracker.class ).stop();
}
Modified: incubator/sirona/trunk/core/src/main/java/org/apache/sirona/tracking/PathTracker.java
URL: http://svn.apache.org/viewvc/incubator/sirona/trunk/core/src/main/java/org/apache/sirona/tracking/PathTracker.java?rev=1570443&r1=1570442&r2=1570443&view=diff
==============================================================================
--- incubator/sirona/trunk/core/src/main/java/org/apache/sirona/tracking/PathTracker.java (original)
+++ incubator/sirona/trunk/core/src/main/java/org/apache/sirona/tracking/PathTracker.java Fri Feb 21 04:27:01 2014
@@ -145,6 +145,7 @@ public class PathTracker
public static PathTracker start( PathTrackingInformation pathTrackingInformation )
{
+
final Context context = THREAD_LOCAL.get();
final int level;