You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by an...@apache.org on 2019/04/29 22:37:12 UTC
[beam] branch master updated: [BEAM-7072][SQL][Nexmark] Disable
Query5
This is an automated email from the ASF dual-hosted git repository.
anton pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git
The following commit(s) were added to refs/heads/master by this push:
new 4c654122 [BEAM-7072][SQL][Nexmark] Disable Query5
new ef67378 Merge pull request #8431 from akedin/disable-sqlquery5
4c654122 is described below
commit 4c65412214802e7467cd38ea71b711418a2670fd
Author: akedin <ke...@google.com>
AuthorDate: Mon Apr 29 13:56:39 2019 -0700
[BEAM-7072][SQL][Nexmark] Disable Query5
---
.../org/apache/beam/sdk/nexmark/NexmarkLauncher.java | 17 +++++++++++++----
1 file changed, 13 insertions(+), 4 deletions(-)
diff --git a/sdks/java/testing/nexmark/src/main/java/org/apache/beam/sdk/nexmark/NexmarkLauncher.java b/sdks/java/testing/nexmark/src/main/java/org/apache/beam/sdk/nexmark/NexmarkLauncher.java
index 0b03166..419d151 100644
--- a/sdks/java/testing/nexmark/src/main/java/org/apache/beam/sdk/nexmark/NexmarkLauncher.java
+++ b/sdks/java/testing/nexmark/src/main/java/org/apache/beam/sdk/nexmark/NexmarkLauncher.java
@@ -81,7 +81,6 @@ import org.apache.beam.sdk.nexmark.queries.sql.SqlQuery0;
import org.apache.beam.sdk.nexmark.queries.sql.SqlQuery1;
import org.apache.beam.sdk.nexmark.queries.sql.SqlQuery2;
import org.apache.beam.sdk.nexmark.queries.sql.SqlQuery3;
-import org.apache.beam.sdk.nexmark.queries.sql.SqlQuery5;
import org.apache.beam.sdk.nexmark.queries.sql.SqlQuery7;
import org.apache.beam.sdk.testing.PAssert;
import org.apache.beam.sdk.testutils.metrics.MetricsReader;
@@ -1241,9 +1240,19 @@ public class NexmarkLauncher<OptionT extends NexmarkOptions> {
.put(
NexmarkQueryName.LOCAL_ITEM_SUGGESTION,
new NexmarkQuery(configuration, new SqlQuery3(configuration)))
- .put(
- NexmarkQueryName.HOT_ITEMS,
- new NexmarkQuery(configuration, new SqlQuery5(configuration)))
+
+ // SqlQuery5 is disabled for now, uses non-equi-joins,
+ // never worked right, was giving incorrect results.
+ // Gets rejected after PR/8301, causing failures.
+ //
+ // See:
+ // https://issues.apache.org/jira/browse/BEAM-7072
+ // https://github.com/apache/beam/pull/8301
+ // https://github.com/apache/beam/pull/8422#issuecomment-487676350
+ //
+ // .put(
+ // NexmarkQueryName.HOT_ITEMS,
+ // new NexmarkQuery(configuration, new SqlQuery5(configuration)))
.put(
NexmarkQueryName.HIGHEST_BID,
new NexmarkQuery(configuration, new SqlQuery7(configuration)))