You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "martin-traverse (via GitHub)" <gi...@apache.org> on 2023/05/11 16:02:44 UTC
[GitHub] [arrow] martin-traverse opened a new pull request, #35554: GH-35553: [JAVA] Fix unwrap() in NettyArrowBuf
martin-traverse opened a new pull request, #35554:
URL: https://github.com/apache/arrow/pull/35554
Suggested fix for #35553
No API changes, this just brings the implementation in line with the API as specified by Netty.
CI for Java run successfully here (not sure if this is publically visible):
https://github.com/martin-traverse/arrow/actions/runs/4949700024
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35554: GH-35553: [JAVA] Fix unwrap() in NettyArrowBuf
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35554:
URL: https://github.com/apache/arrow/pull/35554#issuecomment-1544265623
:warning: GitHub issue #35553 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35554: GH-35553: [JAVA] Fix unwrap() in NettyArrowBuf
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35554:
URL: https://github.com/apache/arrow/pull/35554#issuecomment-1544265565
* Closes: #35553
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] martin-traverse commented on pull request #35554: GH-35553: [JAVA] Fix unwrap() in NettyArrowBuf
Posted by "martin-traverse (via GitHub)" <gi...@apache.org>.
martin-traverse commented on PR #35554:
URL: https://github.com/apache/arrow/pull/35554#issuecomment-1544449017
I added a basic test, let me know if you think anything else is needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35554: GH-35553: [JAVA] Fix unwrap() in NettyArrowBuf
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35554:
URL: https://github.com/apache/arrow/pull/35554#issuecomment-1546647683
['Python', 'R'] benchmarks have high level of regressions.
[ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/82dd7c80e610447188d4d706532bd818...bbef6a6dc6b34b709a7c15611f5ac443/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm merged pull request #35554: GH-35553: [JAVA] Fix unwrap() in NettyArrowBuf
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm merged PR #35554:
URL: https://github.com/apache/arrow/pull/35554
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35554: GH-35553: [JAVA] Fix unwrap() in NettyArrowBuf
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35554:
URL: https://github.com/apache/arrow/pull/35554#issuecomment-1546647514
Benchmark runs are scheduled for baseline = 053b5eecb582a93bc92e6793768fc66d2c5d5046 and contender = a26b30ded946c984c0d5c1707e51e6786d041653. a26b30ded946c984c0d5c1707e51e6786d041653 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/0edb5755ca2b4af3ba1ea34e8ebb8d80...bdf715d6903043ddbdd7d49df487a481/)
[Finished :arrow_down:1.68% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/072c32f21d7e466889c6ebfe124c095c...bd7cbea700f54d6cb6e9de5183d43aef/)
[Finished :arrow_down:2.79% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/82dd7c80e610447188d4d706532bd818...bbef6a6dc6b34b709a7c15611f5ac443/)
[Finished :arrow_down:1.42% :arrow_up:0.21%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/bab5e1dc37494a47b82feb8a9cda6835...ff0a94a3b2e148768e947219e48d386d/)
Buildkite builds:
[Finished] [`a26b30de` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2862)
[Finished] [`a26b30de` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2901)
[Finished] [`a26b30de` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2866)
[Finished] [`a26b30de` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2891)
[Finished] [`053b5eec` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2861)
[Finished] [`053b5eec` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2900)
[Finished] [`053b5eec` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2865)
[Finished] [`053b5eec` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2890)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org