[GitHub] [spark] giamo commented on a change in pull request #24405: [SPARK-27506][SQL] Allow deserialization of Avro data using compatible schemas

[GitBox <gi...@apache.org>]

giamo commented on a change in pull request #24405: [SPARK-27506][SQL] Allow deserialization of Avro data using compatible schemas
URL: https://github.com/apache/spark/pull/24405#discussion_r282145261
 
 

 ##########
 File path: external/avro/src/test/java/org/apache/spark/sql/avro/JavaAvroFunctionsSuite.java
 ##########
 @@ -66,8 +66,8 @@ public void testToAvroFromAvro() {
     String avroTypeStr = "{\"type\": \"string\", \"name\": \"str\"}";
 
     Dataset<Row> actual = avroDF.select(
-      from_avro(avroDF.col("a"), avroTypeLong),
-      from_avro(avroDF.col("b"), avroTypeStr));
+      from_avro(avroDF.col("a"), avroTypeLong, scala.Option.apply(null)),
 
 Review comment:
   It doesn't work for me, I tried a bunch of possible ways to pass a None from Java and that's the only way I managed to make it work... I know it's ugly, but it's only a test

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org