You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Marcus Eriksson (JIRA)" <ji...@apache.org> on 2015/08/10 11:00:52 UTC

[jira] [Comment Edited] (CASSANDRA-10015) Create tool to debug why expired sstables are not getting dropped

    [ https://issues.apache.org/jira/browse/CASSANDRA-10015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14679812#comment-14679812 ] 

Marcus Eriksson edited comment on CASSANDRA-10015 at 8/10/15 8:59 AM:
----------------------------------------------------------------------

bq. Do we need a Windows script and why do we have some sstable* scripts in bin and some in tools/bin?
I will add one in 2.1 as that is where we started supporting Windows. And, regarding the bin/ and tools/bin stuff: CASSANDRA-7160
bq. In the documentation at the top of SSTableExpiredBlocker I would reference the ticket number and perhaps explicitly spell out how an sstable can block expired sstables, rather than just limiting it to "cover anything in other sstables". Something like what's mentioned in this ticket description would maybe be a little clearer.
done
bq. I would replace columnfamily with table, at least in the usage and error messages.
fixed, will rename variables in 3.0+

dtest:
https://github.com/krummas/cassandra-dtest/commits/marcuse/10015
which requires this ccm patch:
https://github.com/krummas/ccm/commits/marcuse/10015
and nits fixed here:
https://github.com/krummas/cassandra/commits/marcuse/10015




was (Author: krummas):
bq. Do we need a Windows script and why do we have some sstable* scripts in bin and some in tools/bin?
I will add one in 2.1 as that is where we started supporting Windows
bq. In the documentation at the top of SSTableExpiredBlocker I would reference the ticket number and perhaps explicitly spell out how an sstable can block expired sstables, rather than just limiting it to "cover anything in other sstables". Something like what's mentioned in this ticket description would maybe be a little clearer.
done
bq. I would replace columnfamily with table, at least in the usage and error messages.
fixed, will rename variables in 3.0+

dtest:
https://github.com/krummas/cassandra-dtest/commits/marcuse/10015
which requires this ccm patch:
https://github.com/krummas/ccm/commits/marcuse/10015
and nits fixed here:
https://github.com/krummas/cassandra/commits/marcuse/10015



> Create tool to debug why expired sstables are not getting dropped
> -----------------------------------------------------------------
>
>                 Key: CASSANDRA-10015
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10015
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Marcus Eriksson
>            Assignee: Marcus Eriksson
>             Fix For: 3.x, 2.1.x, 2.0.x, 2.2.x
>
>
> Sometimes fully expired sstables are not getting dropped, and it is a real pain to manually find out why.
> A tool that outputs which sstable blocks (by having older data than the newest tombstone in an expired sstable) expired ones would save a lot of time.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)