[GitHub] [incubator-yunikorn-scheduler-interface] kingamarton commented on a change in pull request #30: YUNIKORN-489: remove unused message definitions

[GitBox <gi...@apache.org>]

kingamarton commented on a change in pull request #30:
URL: https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/30#discussion_r551334640



##########
File path: scheduler-interface-spec.md
##########
@@ -910,27 +775,3 @@ message EventRecord {
 }
 ```
 
-### Auto Scaling Metrics
-
-Auto scaling metrics can be monitored and collected by a 3rd party auto-scaler and used as the
-supplementary metrics while making auto-scaling decisions. These metrics are indicating how many
-outstanding resource requests are there in the cluster, due to the shortage of node resources.
-This has excluded requests could not be satisfied because of other reasons, such as hitting queue
-resource limit, user/app limit, desire on certain placement constraints, etc.
-
-```protobuf
-// auto scaling metrics at a certain point of time
-message AutoScalingMetrics {
-  // a list of outstanding requests that desires for additional resources
-  repeated OutstandingResourceRequest outstandingRequests = 1;
-}

Review comment:
       I am not sure about this part. @yangwwei I see that you merged this change a few months ago from the autoscaling branch. Is this part of the autoscaling feature started a while ago, but not finished? If yes, I think we can remove it and we will add it back when we will really need it.

##########
File path: scheduler-interface-spec.md
##########
@@ -404,16 +404,10 @@ message AllocationAsk {
   int32 maxAllocations = 5;
   // Priority of ask
   Priority priority = 6;
-  // Execution timeout: How long this allocation will be terminated (by scheduler)
-  // once allocated by scheduler, 0 or negative value means never expire.
-  int64 executionTimeoutMilliSeconds = 7;

Review comment:
       Even if we are not using this one, we will use it for sure in the near future with the Gang scheduling. Please skip removing this one




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org