You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2020/03/02 18:34:09 UTC
[kudu-CR] [scripts] Update parse metrics log.py to make it usable in other scripts
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15336
Change subject: [scripts] Update parse_metrics_log.py to make it usable in other scripts
......................................................................
[scripts] Update parse_metrics_log.py to make it usable in other scripts
This wraps the functionality in parse_metrics_log.py in a class
so that it can be used from another python script.
It maintains the old functionality by moving the print statement
to the main function, from the process function.
I will use this so I can wrap this script in some of my performance
analysis work.
Change-Id: Ia107b54a7efc45f9877e7c0b9405cefb550c38f2
---
M src/kudu/scripts/parse_metrics_log.py
1 file changed, 122 insertions(+), 111 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/36/15336/1
--
To view, visit http://gerrit.cloudera.org:8080/15336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia107b54a7efc45f9877e7c0b9405cefb550c38f2
Gerrit-Change-Number: 15336
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [scripts] Update parse metrics log.py to make it usable in other scripts
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15336
to look at the new patch set (#2).
Change subject: [scripts] Update parse_metrics_log.py to make it usable in other scripts
......................................................................
[scripts] Update parse_metrics_log.py to make it usable in other scripts
This wraps the functionality in parse_metrics_log.py in a class
so that it can be used from another python script.
It maintains the old functionality by moving the print statement
to the main function, from the process function.
I will use this so I can wrap this script in some of my performance
analysis work.
Change-Id: Ia107b54a7efc45f9877e7c0b9405cefb550c38f2
---
M src/kudu/scripts/parse_metrics_log.py
1 file changed, 121 insertions(+), 111 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/36/15336/2
--
To view, visit http://gerrit.cloudera.org:8080/15336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia107b54a7efc45f9877e7c0b9405cefb550c38f2
Gerrit-Change-Number: 15336
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [scripts] Update parse metrics log.py to make it usable in other scripts
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15336 )
Change subject: [scripts] Update parse_metrics_log.py to make it usable in other scripts
......................................................................
[scripts] Update parse_metrics_log.py to make it usable in other scripts
This wraps the functionality in parse_metrics_log.py in a class
so that it can be used from another python script.
It maintains the old functionality by moving the print statement
to the main function, from the process function.
I will use this so I can wrap this script in some of my performance
analysis work.
Change-Id: Ia107b54a7efc45f9877e7c0b9405cefb550c38f2
Reviewed-on: http://gerrit.cloudera.org:8080/15336
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/scripts/parse_metrics_log.py
1 file changed, 121 insertions(+), 111 deletions(-)
Approvals:
Andrew Wong: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/15336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia107b54a7efc45f9877e7c0b9405cefb550c38f2
Gerrit-Change-Number: 15336
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [scripts] Update parse metrics log.py to make it usable in other scripts
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15336 )
Change subject: [scripts] Update parse_metrics_log.py to make it usable in other scripts
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15336/1/src/kudu/scripts/parse_metrics_log.py
File src/kudu/scripts/parse_metrics_log.py:
http://gerrit.cloudera.org:8080/#/c/15336/1/src/kudu/scripts/parse_metrics_log.py@71
PS1, Line 71: ("server.op_apply_run_time", "apply_run_time"),
Dupe?
--
To view, visit http://gerrit.cloudera.org:8080/15336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia107b54a7efc45f9877e7c0b9405cefb550c38f2
Gerrit-Change-Number: 15336
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 02 Mar 2020 18:58:32 +0000
Gerrit-HasComments: Yes
[kudu-CR] [scripts] Update parse metrics log.py to make it usable in other scripts
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15336 )
Change subject: [scripts] Update parse_metrics_log.py to make it usable in other scripts
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia107b54a7efc45f9877e7c0b9405cefb550c38f2
Gerrit-Change-Number: 15336
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 02 Mar 2020 19:11:12 +0000
Gerrit-HasComments: No
[kudu-CR] [scripts] Update parse metrics log.py to make it usable in other scripts
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15336 )
Change subject: [scripts] Update parse_metrics_log.py to make it usable in other scripts
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15336/1/src/kudu/scripts/parse_metrics_log.py
File src/kudu/scripts/parse_metrics_log.py:
http://gerrit.cloudera.org:8080/#/c/15336/1/src/kudu/scripts/parse_metrics_log.py@71
PS1, Line 71: ("server.op_apply_run_time", "apply_run_time"),
> Dupe?
Done
--
To view, visit http://gerrit.cloudera.org:8080/15336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia107b54a7efc45f9877e7c0b9405cefb550c38f2
Gerrit-Change-Number: 15336
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 02 Mar 2020 19:07:56 +0000
Gerrit-HasComments: Yes