You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "the-other-tim-brown (via GitHub)" <gi...@apache.org> on 2025/04/19 21:27:57 UTC
[PR] [DRAFT] Address issues for closeable iterators [hudi]
the-other-tim-brown opened a new pull request, #13178:
URL: https://github.com/apache/hudi/pull/13178
…ook for HoodieData
### Change Logs
_Describe context and summary for this change. Highlight if any code was copied._
### Impact
_Describe any public API or user-facing feature change or any performance impact._
### Risk level (write none, low medium or high below)
_If medium or high, explain what verification was done to mitigate the risks._
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none"._
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9219] Add callbacks for CloseableIterators and eager close data readers [hudi]
Posted by "the-other-tim-brown (via GitHub)" <gi...@apache.org>.
the-other-tim-brown commented on code in PR #13178:
URL: https://github.com/apache/hudi/pull/13178#discussion_r2058725603
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/io/hadoop/HoodieHBaseAvroHFileReader.java:
##########
@@ -628,6 +628,8 @@ public boolean hasNext() {
try {
// NOTE: This is required for idempotency
if (eof) {
+ // eagerly close
+ close();
Review Comment:
This helps proactively free up resources if all elements are read, especially in places that try with resources was missed or if the close is in a later callback. If the iterator is closed without going through all of the elements, it will hit the `close` method to ensure that the input stream is still closed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DRAFT] Address issues for closeable iterators [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13178:
URL: https://github.com/apache/hudi/pull/13178#issuecomment-2817192336
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4970",
"triggerID" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"triggerType" : "PUSH"
}, {
"hash" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4971",
"triggerID" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"triggerType" : "PUSH"
}, {
"hash" : "26676bc85fbd4255a2c6a813a750e493d85e158e",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4980",
"triggerID" : "26676bc85fbd4255a2c6a813a750e493d85e158e",
"triggerType" : "PUSH"
}, {
"hash" : "0c50f6b7edce83be7bc21affd9eea47b94055767",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0c50f6b7edce83be7bc21affd9eea47b94055767",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 26676bc85fbd4255a2c6a813a750e493d85e158e Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4980)
* 0c50f6b7edce83be7bc21affd9eea47b94055767 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DRAFT] Address issues for closeable iterators [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13178:
URL: https://github.com/apache/hudi/pull/13178#issuecomment-2817332530
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4970",
"triggerID" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"triggerType" : "PUSH"
}, {
"hash" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4971",
"triggerID" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"triggerType" : "PUSH"
}, {
"hash" : "26676bc85fbd4255a2c6a813a750e493d85e158e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4980",
"triggerID" : "26676bc85fbd4255a2c6a813a750e493d85e158e",
"triggerType" : "PUSH"
}, {
"hash" : "0c50f6b7edce83be7bc21affd9eea47b94055767",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4983",
"triggerID" : "0c50f6b7edce83be7bc21affd9eea47b94055767",
"triggerType" : "PUSH"
}, {
"hash" : "3c3c2add5afeb79bef4b9a9a5cd5b5e50ed80433",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4986",
"triggerID" : "3c3c2add5afeb79bef4b9a9a5cd5b5e50ed80433",
"triggerType" : "PUSH"
}, {
"hash" : "981d33eeac57d30748795d56c0b7776466b336e7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "981d33eeac57d30748795d56c0b7776466b336e7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3c3c2add5afeb79bef4b9a9a5cd5b5e50ed80433 Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4986)
* 981d33eeac57d30748795d56c0b7776466b336e7 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DRAFT] Address issues for closeable iterators [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13178:
URL: https://github.com/apache/hudi/pull/13178#issuecomment-2817330741
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4970",
"triggerID" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"triggerType" : "PUSH"
}, {
"hash" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4971",
"triggerID" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"triggerType" : "PUSH"
}, {
"hash" : "26676bc85fbd4255a2c6a813a750e493d85e158e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4980",
"triggerID" : "26676bc85fbd4255a2c6a813a750e493d85e158e",
"triggerType" : "PUSH"
}, {
"hash" : "0c50f6b7edce83be7bc21affd9eea47b94055767",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4983",
"triggerID" : "0c50f6b7edce83be7bc21affd9eea47b94055767",
"triggerType" : "PUSH"
}, {
"hash" : "3c3c2add5afeb79bef4b9a9a5cd5b5e50ed80433",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3c3c2add5afeb79bef4b9a9a5cd5b5e50ed80433",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0c50f6b7edce83be7bc21affd9eea47b94055767 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4983)
* 3c3c2add5afeb79bef4b9a9a5cd5b5e50ed80433 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9219] Add callbacks for CloseableIterators and eager close data readers [hudi]
Posted by "the-other-tim-brown (via GitHub)" <gi...@apache.org>.
the-other-tim-brown commented on code in PR #13178:
URL: https://github.com/apache/hudi/pull/13178#discussion_r2056619452
##########
hudi-common/src/test/java/org/apache/hudi/common/data/WrappedIterator.java:
##########
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.hudi.common.data;
+
+import org.apache.hudi.common.util.collection.ClosableIterator;
+
+import java.util.Iterator;
+
+/**
+ * Implementation of a {@link ClosableIterator} to help validate that the close method is properly called.
+ * @param <T> type of record within the iterator
+ */
+class WrappedIterator<T> implements ClosableIterator<T> {
+ private final Iterator<T> inner;
+ private boolean isClosed = false;
+
+ public WrappedIterator(Iterator<T> inner) {
Review Comment:
udpated
##########
hudi-common/src/test/java/org/apache/hudi/common/data/WrappedIterator.java:
##########
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.hudi.common.data;
+
+import org.apache.hudi.common.util.collection.ClosableIterator;
+
+import java.util.Iterator;
+
+/**
+ * Implementation of a {@link ClosableIterator} to help validate that the close method is properly called.
+ * @param <T> type of record within the iterator
+ */
+class WrappedIterator<T> implements ClosableIterator<T> {
+ private final Iterator<T> inner;
+ private boolean isClosed = false;
+
+ public WrappedIterator(Iterator<T> inner) {
Review Comment:
updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9219] Add callbacks for CloseableIterators and eager close data readers [hudi]
Posted by "the-other-tim-brown (via GitHub)" <gi...@apache.org>.
the-other-tim-brown commented on code in PR #13178:
URL: https://github.com/apache/hudi/pull/13178#discussion_r2060306847
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/io/hadoop/HoodieHBaseAvroHFileReader.java:
##########
@@ -628,6 +628,8 @@ public boolean hasNext() {
try {
// NOTE: This is required for idempotency
if (eof) {
+ // eagerly close
+ close();
Review Comment:
I don't see any issue in doing both of these things. What is the main concern for this added level of safety?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DRAFT] Address issues for closeable iterators [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13178:
URL: https://github.com/apache/hudi/pull/13178#issuecomment-2816905956
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4970",
"triggerID" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"triggerType" : "PUSH"
}, {
"hash" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4971",
"triggerID" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b80162401cb728401120f126918cf0cc1d1e6de2 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4971)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DRAFT] Address issues for closeable iterators [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13178:
URL: https://github.com/apache/hudi/pull/13178#issuecomment-2817334081
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4970",
"triggerID" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"triggerType" : "PUSH"
}, {
"hash" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4971",
"triggerID" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"triggerType" : "PUSH"
}, {
"hash" : "26676bc85fbd4255a2c6a813a750e493d85e158e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4980",
"triggerID" : "26676bc85fbd4255a2c6a813a750e493d85e158e",
"triggerType" : "PUSH"
}, {
"hash" : "0c50f6b7edce83be7bc21affd9eea47b94055767",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4983",
"triggerID" : "0c50f6b7edce83be7bc21affd9eea47b94055767",
"triggerType" : "PUSH"
}, {
"hash" : "3c3c2add5afeb79bef4b9a9a5cd5b5e50ed80433",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4986",
"triggerID" : "3c3c2add5afeb79bef4b9a9a5cd5b5e50ed80433",
"triggerType" : "PUSH"
}, {
"hash" : "981d33eeac57d30748795d56c0b7776466b336e7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "981d33eeac57d30748795d56c0b7776466b336e7",
"triggerType" : "PUSH"
}, {
"hash" : "0a0055e5594d49ade0bca3fc9501ace4bcce648c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0a0055e5594d49ade0bca3fc9501ace4bcce648c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3c3c2add5afeb79bef4b9a9a5cd5b5e50ed80433 Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4986)
* 981d33eeac57d30748795d56c0b7776466b336e7 UNKNOWN
* 0a0055e5594d49ade0bca3fc9501ace4bcce648c UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9219] Add callbacks for CloseableIterators and eager close data readers [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #13178:
URL: https://github.com/apache/hudi/pull/13178#discussion_r2061014318
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/io/hadoop/HoodieHBaseAvroHFileReader.java:
##########
@@ -628,6 +628,8 @@ public boolean hasNext() {
try {
// NOTE: This is required for idempotency
if (eof) {
+ // eagerly close
+ close();
Review Comment:
The iterator is designed to be no side effect actually, we breaks it already for introducing `ClosableIterator`, and not we breaks the rule silently during the iteration which I think is not a very good convention to follow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9219] Add callbacks for CloseableIterators and eager close data readers [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #13178:
URL: https://github.com/apache/hudi/pull/13178#discussion_r2062943727
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/io/hadoop/HoodieHBaseAvroHFileReader.java:
##########
@@ -628,6 +628,8 @@ public boolean hasNext() {
try {
// NOTE: This is required for idempotency
if (eof) {
+ // eagerly close
+ close();
Review Comment:
still have one: `HoodieNativeAvroHFileReader`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9219] Add callbacks for CloseableIterators and eager close data readers [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13178:
URL: https://github.com/apache/hudi/pull/13178#issuecomment-2817340261
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4970",
"triggerID" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"triggerType" : "PUSH"
}, {
"hash" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4971",
"triggerID" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"triggerType" : "PUSH"
}, {
"hash" : "26676bc85fbd4255a2c6a813a750e493d85e158e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4980",
"triggerID" : "26676bc85fbd4255a2c6a813a750e493d85e158e",
"triggerType" : "PUSH"
}, {
"hash" : "0c50f6b7edce83be7bc21affd9eea47b94055767",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4983",
"triggerID" : "0c50f6b7edce83be7bc21affd9eea47b94055767",
"triggerType" : "PUSH"
}, {
"hash" : "3c3c2add5afeb79bef4b9a9a5cd5b5e50ed80433",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4986",
"triggerID" : "3c3c2add5afeb79bef4b9a9a5cd5b5e50ed80433",
"triggerType" : "PUSH"
}, {
"hash" : "981d33eeac57d30748795d56c0b7776466b336e7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "981d33eeac57d30748795d56c0b7776466b336e7",
"triggerType" : "PUSH"
}, {
"hash" : "0a0055e5594d49ade0bca3fc9501ace4bcce648c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0a0055e5594d49ade0bca3fc9501ace4bcce648c",
"triggerType" : "PUSH"
}, {
"hash" : "f63a531d8fe2c0431214ff3db03cdf92aea4e954",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f63a531d8fe2c0431214ff3db03cdf92aea4e954",
"triggerType" : "PUSH"
}, {
"hash" : "8971ac82290132f42b946c5654b108f77f18ada9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8971ac82290132f42b946c5654b108f77f18ada9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3c3c2add5afeb79bef4b9a9a5cd5b5e50ed80433 Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4986)
* 981d33eeac57d30748795d56c0b7776466b336e7 UNKNOWN
* 0a0055e5594d49ade0bca3fc9501ace4bcce648c UNKNOWN
* f63a531d8fe2c0431214ff3db03cdf92aea4e954 UNKNOWN
* 8971ac82290132f42b946c5654b108f77f18ada9 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9219] Add callbacks for CloseableIterators and eager close data readers [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13178:
URL: https://github.com/apache/hudi/pull/13178#issuecomment-2817371605
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4970",
"triggerID" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"triggerType" : "PUSH"
}, {
"hash" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4971",
"triggerID" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"triggerType" : "PUSH"
}, {
"hash" : "26676bc85fbd4255a2c6a813a750e493d85e158e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4980",
"triggerID" : "26676bc85fbd4255a2c6a813a750e493d85e158e",
"triggerType" : "PUSH"
}, {
"hash" : "0c50f6b7edce83be7bc21affd9eea47b94055767",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4983",
"triggerID" : "0c50f6b7edce83be7bc21affd9eea47b94055767",
"triggerType" : "PUSH"
}, {
"hash" : "3c3c2add5afeb79bef4b9a9a5cd5b5e50ed80433",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4986",
"triggerID" : "3c3c2add5afeb79bef4b9a9a5cd5b5e50ed80433",
"triggerType" : "PUSH"
}, {
"hash" : "981d33eeac57d30748795d56c0b7776466b336e7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "981d33eeac57d30748795d56c0b7776466b336e7",
"triggerType" : "PUSH"
}, {
"hash" : "0a0055e5594d49ade0bca3fc9501ace4bcce648c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0a0055e5594d49ade0bca3fc9501ace4bcce648c",
"triggerType" : "PUSH"
}, {
"hash" : "f63a531d8fe2c0431214ff3db03cdf92aea4e954",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f63a531d8fe2c0431214ff3db03cdf92aea4e954",
"triggerType" : "PUSH"
}, {
"hash" : "8971ac82290132f42b946c5654b108f77f18ada9",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4987",
"triggerID" : "8971ac82290132f42b946c5654b108f77f18ada9",
"triggerType" : "PUSH"
}, {
"hash" : "3d55d1056c8ce32f48b1e8b114cd0d6f0ce30c2e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3d55d1056c8ce32f48b1e8b114cd0d6f0ce30c2e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 981d33eeac57d30748795d56c0b7776466b336e7 UNKNOWN
* 0a0055e5594d49ade0bca3fc9501ace4bcce648c UNKNOWN
* f63a531d8fe2c0431214ff3db03cdf92aea4e954 UNKNOWN
* 8971ac82290132f42b946c5654b108f77f18ada9 Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4987)
* 3d55d1056c8ce32f48b1e8b114cd0d6f0ce30c2e UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DRAFT] Address issues for closeable iterators [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13178:
URL: https://github.com/apache/hudi/pull/13178#issuecomment-2817336835
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4970",
"triggerID" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"triggerType" : "PUSH"
}, {
"hash" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4971",
"triggerID" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"triggerType" : "PUSH"
}, {
"hash" : "26676bc85fbd4255a2c6a813a750e493d85e158e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4980",
"triggerID" : "26676bc85fbd4255a2c6a813a750e493d85e158e",
"triggerType" : "PUSH"
}, {
"hash" : "0c50f6b7edce83be7bc21affd9eea47b94055767",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4983",
"triggerID" : "0c50f6b7edce83be7bc21affd9eea47b94055767",
"triggerType" : "PUSH"
}, {
"hash" : "3c3c2add5afeb79bef4b9a9a5cd5b5e50ed80433",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4986",
"triggerID" : "3c3c2add5afeb79bef4b9a9a5cd5b5e50ed80433",
"triggerType" : "PUSH"
}, {
"hash" : "981d33eeac57d30748795d56c0b7776466b336e7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "981d33eeac57d30748795d56c0b7776466b336e7",
"triggerType" : "PUSH"
}, {
"hash" : "0a0055e5594d49ade0bca3fc9501ace4bcce648c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0a0055e5594d49ade0bca3fc9501ace4bcce648c",
"triggerType" : "PUSH"
}, {
"hash" : "f63a531d8fe2c0431214ff3db03cdf92aea4e954",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f63a531d8fe2c0431214ff3db03cdf92aea4e954",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3c3c2add5afeb79bef4b9a9a5cd5b5e50ed80433 Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4986)
* 981d33eeac57d30748795d56c0b7776466b336e7 UNKNOWN
* 0a0055e5594d49ade0bca3fc9501ace4bcce648c UNKNOWN
* f63a531d8fe2c0431214ff3db03cdf92aea4e954 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9219] Add callbacks for CloseableIterators and eager close data readers [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13178:
URL: https://github.com/apache/hudi/pull/13178#issuecomment-2817381648
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4970",
"triggerID" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"triggerType" : "PUSH"
}, {
"hash" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4971",
"triggerID" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"triggerType" : "PUSH"
}, {
"hash" : "26676bc85fbd4255a2c6a813a750e493d85e158e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4980",
"triggerID" : "26676bc85fbd4255a2c6a813a750e493d85e158e",
"triggerType" : "PUSH"
}, {
"hash" : "0c50f6b7edce83be7bc21affd9eea47b94055767",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4983",
"triggerID" : "0c50f6b7edce83be7bc21affd9eea47b94055767",
"triggerType" : "PUSH"
}, {
"hash" : "3c3c2add5afeb79bef4b9a9a5cd5b5e50ed80433",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4986",
"triggerID" : "3c3c2add5afeb79bef4b9a9a5cd5b5e50ed80433",
"triggerType" : "PUSH"
}, {
"hash" : "981d33eeac57d30748795d56c0b7776466b336e7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "981d33eeac57d30748795d56c0b7776466b336e7",
"triggerType" : "PUSH"
}, {
"hash" : "0a0055e5594d49ade0bca3fc9501ace4bcce648c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0a0055e5594d49ade0bca3fc9501ace4bcce648c",
"triggerType" : "PUSH"
}, {
"hash" : "f63a531d8fe2c0431214ff3db03cdf92aea4e954",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f63a531d8fe2c0431214ff3db03cdf92aea4e954",
"triggerType" : "PUSH"
}, {
"hash" : "8971ac82290132f42b946c5654b108f77f18ada9",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4987",
"triggerID" : "8971ac82290132f42b946c5654b108f77f18ada9",
"triggerType" : "PUSH"
}, {
"hash" : "3d55d1056c8ce32f48b1e8b114cd0d6f0ce30c2e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4989",
"triggerID" : "3d55d1056c8ce32f48b1e8b114cd0d6f0ce30c2e",
"triggerType" : "PUSH"
}, {
"hash" : "c847a7880f771fc0586cc3ef24a4805553f5f2c7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c847a7880f771fc0586cc3ef24a4805553f5f2c7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 981d33eeac57d30748795d56c0b7776466b336e7 UNKNOWN
* 0a0055e5594d49ade0bca3fc9501ace4bcce648c UNKNOWN
* f63a531d8fe2c0431214ff3db03cdf92aea4e954 UNKNOWN
* 8971ac82290132f42b946c5654b108f77f18ada9 Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4987)
* 3d55d1056c8ce32f48b1e8b114cd0d6f0ce30c2e Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4989)
* c847a7880f771fc0586cc3ef24a4805553f5f2c7 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9219] Add callbacks for CloseableIterators and eager close data readers [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13178:
URL: https://github.com/apache/hudi/pull/13178#issuecomment-2817371132
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4970",
"triggerID" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"triggerType" : "PUSH"
}, {
"hash" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4971",
"triggerID" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"triggerType" : "PUSH"
}, {
"hash" : "26676bc85fbd4255a2c6a813a750e493d85e158e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4980",
"triggerID" : "26676bc85fbd4255a2c6a813a750e493d85e158e",
"triggerType" : "PUSH"
}, {
"hash" : "0c50f6b7edce83be7bc21affd9eea47b94055767",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4983",
"triggerID" : "0c50f6b7edce83be7bc21affd9eea47b94055767",
"triggerType" : "PUSH"
}, {
"hash" : "3c3c2add5afeb79bef4b9a9a5cd5b5e50ed80433",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4986",
"triggerID" : "3c3c2add5afeb79bef4b9a9a5cd5b5e50ed80433",
"triggerType" : "PUSH"
}, {
"hash" : "981d33eeac57d30748795d56c0b7776466b336e7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "981d33eeac57d30748795d56c0b7776466b336e7",
"triggerType" : "PUSH"
}, {
"hash" : "0a0055e5594d49ade0bca3fc9501ace4bcce648c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0a0055e5594d49ade0bca3fc9501ace4bcce648c",
"triggerType" : "PUSH"
}, {
"hash" : "f63a531d8fe2c0431214ff3db03cdf92aea4e954",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f63a531d8fe2c0431214ff3db03cdf92aea4e954",
"triggerType" : "PUSH"
}, {
"hash" : "8971ac82290132f42b946c5654b108f77f18ada9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4987",
"triggerID" : "8971ac82290132f42b946c5654b108f77f18ada9",
"triggerType" : "PUSH"
}, {
"hash" : "3d55d1056c8ce32f48b1e8b114cd0d6f0ce30c2e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3d55d1056c8ce32f48b1e8b114cd0d6f0ce30c2e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3c3c2add5afeb79bef4b9a9a5cd5b5e50ed80433 Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4986)
* 981d33eeac57d30748795d56c0b7776466b336e7 UNKNOWN
* 0a0055e5594d49ade0bca3fc9501ace4bcce648c UNKNOWN
* f63a531d8fe2c0431214ff3db03cdf92aea4e954 UNKNOWN
* 8971ac82290132f42b946c5654b108f77f18ada9 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4987)
* 3d55d1056c8ce32f48b1e8b114cd0d6f0ce30c2e UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9219] Add callbacks for CloseableIterators and eager close data readers [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13178:
URL: https://github.com/apache/hudi/pull/13178#issuecomment-2835804547
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4970",
"triggerID" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"triggerType" : "PUSH"
}, {
"hash" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4971",
"triggerID" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"triggerType" : "PUSH"
}, {
"hash" : "26676bc85fbd4255a2c6a813a750e493d85e158e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4980",
"triggerID" : "26676bc85fbd4255a2c6a813a750e493d85e158e",
"triggerType" : "PUSH"
}, {
"hash" : "0c50f6b7edce83be7bc21affd9eea47b94055767",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4983",
"triggerID" : "0c50f6b7edce83be7bc21affd9eea47b94055767",
"triggerType" : "PUSH"
}, {
"hash" : "3c3c2add5afeb79bef4b9a9a5cd5b5e50ed80433",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4986",
"triggerID" : "3c3c2add5afeb79bef4b9a9a5cd5b5e50ed80433",
"triggerType" : "PUSH"
}, {
"hash" : "981d33eeac57d30748795d56c0b7776466b336e7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "981d33eeac57d30748795d56c0b7776466b336e7",
"triggerType" : "PUSH"
}, {
"hash" : "0a0055e5594d49ade0bca3fc9501ace4bcce648c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0a0055e5594d49ade0bca3fc9501ace4bcce648c",
"triggerType" : "PUSH"
}, {
"hash" : "f63a531d8fe2c0431214ff3db03cdf92aea4e954",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f63a531d8fe2c0431214ff3db03cdf92aea4e954",
"triggerType" : "PUSH"
}, {
"hash" : "8971ac82290132f42b946c5654b108f77f18ada9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4987",
"triggerID" : "8971ac82290132f42b946c5654b108f77f18ada9",
"triggerType" : "PUSH"
}, {
"hash" : "3d55d1056c8ce32f48b1e8b114cd0d6f0ce30c2e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4989",
"triggerID" : "3d55d1056c8ce32f48b1e8b114cd0d6f0ce30c2e",
"triggerType" : "PUSH"
}, {
"hash" : "c847a7880f771fc0586cc3ef24a4805553f5f2c7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4992",
"triggerID" : "c847a7880f771fc0586cc3ef24a4805553f5f2c7",
"triggerType" : "PUSH"
}, {
"hash" : "d0c019c72df970c138647715a84e5d5df9740b31",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=5109",
"triggerID" : "d0c019c72df970c138647715a84e5d5df9740b31",
"triggerType" : "PUSH"
}, {
"hash" : "d36a5efe3bbeb47117831f916e286096985aa07b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=5175",
"triggerID" : "d36a5efe3bbeb47117831f916e286096985aa07b",
"triggerType" : "PUSH"
}, {
"hash" : "d8a534839b7f77d9dd1370c695f27ab8ca68f0fe",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=5184",
"triggerID" : "d8a534839b7f77d9dd1370c695f27ab8ca68f0fe",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 981d33eeac57d30748795d56c0b7776466b336e7 UNKNOWN
* 0a0055e5594d49ade0bca3fc9501ace4bcce648c UNKNOWN
* f63a531d8fe2c0431214ff3db03cdf92aea4e954 UNKNOWN
* d36a5efe3bbeb47117831f916e286096985aa07b Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=5175)
* d8a534839b7f77d9dd1370c695f27ab8ca68f0fe Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=5184)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9219] Add callbacks for CloseableIterators and eager close data readers [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13178:
URL: https://github.com/apache/hudi/pull/13178#issuecomment-2836102542
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4970",
"triggerID" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"triggerType" : "PUSH"
}, {
"hash" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4971",
"triggerID" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"triggerType" : "PUSH"
}, {
"hash" : "26676bc85fbd4255a2c6a813a750e493d85e158e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4980",
"triggerID" : "26676bc85fbd4255a2c6a813a750e493d85e158e",
"triggerType" : "PUSH"
}, {
"hash" : "0c50f6b7edce83be7bc21affd9eea47b94055767",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4983",
"triggerID" : "0c50f6b7edce83be7bc21affd9eea47b94055767",
"triggerType" : "PUSH"
}, {
"hash" : "3c3c2add5afeb79bef4b9a9a5cd5b5e50ed80433",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4986",
"triggerID" : "3c3c2add5afeb79bef4b9a9a5cd5b5e50ed80433",
"triggerType" : "PUSH"
}, {
"hash" : "981d33eeac57d30748795d56c0b7776466b336e7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "981d33eeac57d30748795d56c0b7776466b336e7",
"triggerType" : "PUSH"
}, {
"hash" : "0a0055e5594d49ade0bca3fc9501ace4bcce648c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0a0055e5594d49ade0bca3fc9501ace4bcce648c",
"triggerType" : "PUSH"
}, {
"hash" : "f63a531d8fe2c0431214ff3db03cdf92aea4e954",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f63a531d8fe2c0431214ff3db03cdf92aea4e954",
"triggerType" : "PUSH"
}, {
"hash" : "8971ac82290132f42b946c5654b108f77f18ada9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4987",
"triggerID" : "8971ac82290132f42b946c5654b108f77f18ada9",
"triggerType" : "PUSH"
}, {
"hash" : "3d55d1056c8ce32f48b1e8b114cd0d6f0ce30c2e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4989",
"triggerID" : "3d55d1056c8ce32f48b1e8b114cd0d6f0ce30c2e",
"triggerType" : "PUSH"
}, {
"hash" : "c847a7880f771fc0586cc3ef24a4805553f5f2c7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4992",
"triggerID" : "c847a7880f771fc0586cc3ef24a4805553f5f2c7",
"triggerType" : "PUSH"
}, {
"hash" : "d0c019c72df970c138647715a84e5d5df9740b31",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=5109",
"triggerID" : "d0c019c72df970c138647715a84e5d5df9740b31",
"triggerType" : "PUSH"
}, {
"hash" : "d36a5efe3bbeb47117831f916e286096985aa07b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=5175",
"triggerID" : "d36a5efe3bbeb47117831f916e286096985aa07b",
"triggerType" : "PUSH"
}, {
"hash" : "d8a534839b7f77d9dd1370c695f27ab8ca68f0fe",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=5184",
"triggerID" : "d8a534839b7f77d9dd1370c695f27ab8ca68f0fe",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 981d33eeac57d30748795d56c0b7776466b336e7 UNKNOWN
* 0a0055e5594d49ade0bca3fc9501ace4bcce648c UNKNOWN
* f63a531d8fe2c0431214ff3db03cdf92aea4e954 UNKNOWN
* d8a534839b7f77d9dd1370c695f27ab8ca68f0fe Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=5184)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DRAFT] Address issues for closeable iterators [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13178:
URL: https://github.com/apache/hudi/pull/13178#issuecomment-2817191690
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4970",
"triggerID" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"triggerType" : "PUSH"
}, {
"hash" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4971",
"triggerID" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"triggerType" : "PUSH"
}, {
"hash" : "26676bc85fbd4255a2c6a813a750e493d85e158e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4980",
"triggerID" : "26676bc85fbd4255a2c6a813a750e493d85e158e",
"triggerType" : "PUSH"
}, {
"hash" : "0c50f6b7edce83be7bc21affd9eea47b94055767",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0c50f6b7edce83be7bc21affd9eea47b94055767",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b80162401cb728401120f126918cf0cc1d1e6de2 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4971)
* 26676bc85fbd4255a2c6a813a750e493d85e158e Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4980)
* 0c50f6b7edce83be7bc21affd9eea47b94055767 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DRAFT] Address issues for closeable iterators [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13178:
URL: https://github.com/apache/hudi/pull/13178#issuecomment-2817331896
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4970",
"triggerID" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"triggerType" : "PUSH"
}, {
"hash" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4971",
"triggerID" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"triggerType" : "PUSH"
}, {
"hash" : "26676bc85fbd4255a2c6a813a750e493d85e158e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4980",
"triggerID" : "26676bc85fbd4255a2c6a813a750e493d85e158e",
"triggerType" : "PUSH"
}, {
"hash" : "0c50f6b7edce83be7bc21affd9eea47b94055767",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4983",
"triggerID" : "0c50f6b7edce83be7bc21affd9eea47b94055767",
"triggerType" : "PUSH"
}, {
"hash" : "3c3c2add5afeb79bef4b9a9a5cd5b5e50ed80433",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4986",
"triggerID" : "3c3c2add5afeb79bef4b9a9a5cd5b5e50ed80433",
"triggerType" : "PUSH"
}, {
"hash" : "981d33eeac57d30748795d56c0b7776466b336e7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "981d33eeac57d30748795d56c0b7776466b336e7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0c50f6b7edce83be7bc21affd9eea47b94055767 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4983)
* 3c3c2add5afeb79bef4b9a9a5cd5b5e50ed80433 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4986)
* 981d33eeac57d30748795d56c0b7776466b336e7 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DRAFT] Address issues for closeable iterators [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13178:
URL: https://github.com/apache/hudi/pull/13178#issuecomment-2816873215
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* defb5303cb59dd25feb12c72a4a9420d8c979237 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9219] Add callbacks for CloseableIterators and eager close data readers [hudi]
Posted by "nsivabalan (via GitHub)" <gi...@apache.org>.
nsivabalan commented on code in PR #13178:
URL: https://github.com/apache/hudi/pull/13178#discussion_r2056314814
##########
hudi-common/src/test/java/org/apache/hudi/common/data/WrappedIterator.java:
##########
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.hudi.common.data;
+
+import org.apache.hudi.common.util.collection.ClosableIterator;
+
+import java.util.Iterator;
+
+/**
+ * Implementation of a {@link ClosableIterator} to help validate that the close method is properly called.
+ * @param <T> type of record within the iterator
+ */
+class WrappedIterator<T> implements ClosableIterator<T> {
+ private final Iterator<T> inner;
+ private boolean isClosed = false;
+
+ public WrappedIterator(Iterator<T> inner) {
Review Comment:
hwo about CloseValidationIterator
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9219] Add callbacks for CloseableIterators and eager close data readers [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13178:
URL: https://github.com/apache/hudi/pull/13178#issuecomment-2825088982
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4970",
"triggerID" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"triggerType" : "PUSH"
}, {
"hash" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4971",
"triggerID" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"triggerType" : "PUSH"
}, {
"hash" : "26676bc85fbd4255a2c6a813a750e493d85e158e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4980",
"triggerID" : "26676bc85fbd4255a2c6a813a750e493d85e158e",
"triggerType" : "PUSH"
}, {
"hash" : "0c50f6b7edce83be7bc21affd9eea47b94055767",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4983",
"triggerID" : "0c50f6b7edce83be7bc21affd9eea47b94055767",
"triggerType" : "PUSH"
}, {
"hash" : "3c3c2add5afeb79bef4b9a9a5cd5b5e50ed80433",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4986",
"triggerID" : "3c3c2add5afeb79bef4b9a9a5cd5b5e50ed80433",
"triggerType" : "PUSH"
}, {
"hash" : "981d33eeac57d30748795d56c0b7776466b336e7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "981d33eeac57d30748795d56c0b7776466b336e7",
"triggerType" : "PUSH"
}, {
"hash" : "0a0055e5594d49ade0bca3fc9501ace4bcce648c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0a0055e5594d49ade0bca3fc9501ace4bcce648c",
"triggerType" : "PUSH"
}, {
"hash" : "f63a531d8fe2c0431214ff3db03cdf92aea4e954",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f63a531d8fe2c0431214ff3db03cdf92aea4e954",
"triggerType" : "PUSH"
}, {
"hash" : "8971ac82290132f42b946c5654b108f77f18ada9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4987",
"triggerID" : "8971ac82290132f42b946c5654b108f77f18ada9",
"triggerType" : "PUSH"
}, {
"hash" : "3d55d1056c8ce32f48b1e8b114cd0d6f0ce30c2e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4989",
"triggerID" : "3d55d1056c8ce32f48b1e8b114cd0d6f0ce30c2e",
"triggerType" : "PUSH"
}, {
"hash" : "c847a7880f771fc0586cc3ef24a4805553f5f2c7",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4992",
"triggerID" : "c847a7880f771fc0586cc3ef24a4805553f5f2c7",
"triggerType" : "PUSH"
}, {
"hash" : "d0c019c72df970c138647715a84e5d5df9740b31",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d0c019c72df970c138647715a84e5d5df9740b31",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 981d33eeac57d30748795d56c0b7776466b336e7 UNKNOWN
* 0a0055e5594d49ade0bca3fc9501ace4bcce648c UNKNOWN
* f63a531d8fe2c0431214ff3db03cdf92aea4e954 UNKNOWN
* c847a7880f771fc0586cc3ef24a4805553f5f2c7 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4992)
* d0c019c72df970c138647715a84e5d5df9740b31 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9219] Add callbacks for CloseableIterators and eager close data readers [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13178:
URL: https://github.com/apache/hudi/pull/13178#issuecomment-2825884101
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4970",
"triggerID" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"triggerType" : "PUSH"
}, {
"hash" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4971",
"triggerID" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"triggerType" : "PUSH"
}, {
"hash" : "26676bc85fbd4255a2c6a813a750e493d85e158e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4980",
"triggerID" : "26676bc85fbd4255a2c6a813a750e493d85e158e",
"triggerType" : "PUSH"
}, {
"hash" : "0c50f6b7edce83be7bc21affd9eea47b94055767",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4983",
"triggerID" : "0c50f6b7edce83be7bc21affd9eea47b94055767",
"triggerType" : "PUSH"
}, {
"hash" : "3c3c2add5afeb79bef4b9a9a5cd5b5e50ed80433",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4986",
"triggerID" : "3c3c2add5afeb79bef4b9a9a5cd5b5e50ed80433",
"triggerType" : "PUSH"
}, {
"hash" : "981d33eeac57d30748795d56c0b7776466b336e7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "981d33eeac57d30748795d56c0b7776466b336e7",
"triggerType" : "PUSH"
}, {
"hash" : "0a0055e5594d49ade0bca3fc9501ace4bcce648c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0a0055e5594d49ade0bca3fc9501ace4bcce648c",
"triggerType" : "PUSH"
}, {
"hash" : "f63a531d8fe2c0431214ff3db03cdf92aea4e954",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f63a531d8fe2c0431214ff3db03cdf92aea4e954",
"triggerType" : "PUSH"
}, {
"hash" : "8971ac82290132f42b946c5654b108f77f18ada9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4987",
"triggerID" : "8971ac82290132f42b946c5654b108f77f18ada9",
"triggerType" : "PUSH"
}, {
"hash" : "3d55d1056c8ce32f48b1e8b114cd0d6f0ce30c2e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4989",
"triggerID" : "3d55d1056c8ce32f48b1e8b114cd0d6f0ce30c2e",
"triggerType" : "PUSH"
}, {
"hash" : "c847a7880f771fc0586cc3ef24a4805553f5f2c7",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4992",
"triggerID" : "c847a7880f771fc0586cc3ef24a4805553f5f2c7",
"triggerType" : "PUSH"
}, {
"hash" : "d0c019c72df970c138647715a84e5d5df9740b31",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=5109",
"triggerID" : "d0c019c72df970c138647715a84e5d5df9740b31",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 981d33eeac57d30748795d56c0b7776466b336e7 UNKNOWN
* 0a0055e5594d49ade0bca3fc9501ace4bcce648c UNKNOWN
* f63a531d8fe2c0431214ff3db03cdf92aea4e954 UNKNOWN
* c847a7880f771fc0586cc3ef24a4805553f5f2c7 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4992)
* d0c019c72df970c138647715a84e5d5df9740b31 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=5109)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DRAFT] Address issues for closeable iterators [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13178:
URL: https://github.com/apache/hudi/pull/13178#issuecomment-2816890446
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4970",
"triggerID" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"triggerType" : "PUSH"
}, {
"hash" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4971",
"triggerID" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* defb5303cb59dd25feb12c72a4a9420d8c979237 Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4970)
* b80162401cb728401120f126918cf0cc1d1e6de2 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4971)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DRAFT] Address issues for closeable iterators [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13178:
URL: https://github.com/apache/hudi/pull/13178#issuecomment-2816890115
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4970",
"triggerID" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"triggerType" : "PUSH"
}, {
"hash" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* defb5303cb59dd25feb12c72a4a9420d8c979237 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4970)
* b80162401cb728401120f126918cf0cc1d1e6de2 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9219] Add callbacks for CloseableIterators and eager close data readers [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13178:
URL: https://github.com/apache/hudi/pull/13178#issuecomment-2817391335
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4970",
"triggerID" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"triggerType" : "PUSH"
}, {
"hash" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4971",
"triggerID" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"triggerType" : "PUSH"
}, {
"hash" : "26676bc85fbd4255a2c6a813a750e493d85e158e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4980",
"triggerID" : "26676bc85fbd4255a2c6a813a750e493d85e158e",
"triggerType" : "PUSH"
}, {
"hash" : "0c50f6b7edce83be7bc21affd9eea47b94055767",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4983",
"triggerID" : "0c50f6b7edce83be7bc21affd9eea47b94055767",
"triggerType" : "PUSH"
}, {
"hash" : "3c3c2add5afeb79bef4b9a9a5cd5b5e50ed80433",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4986",
"triggerID" : "3c3c2add5afeb79bef4b9a9a5cd5b5e50ed80433",
"triggerType" : "PUSH"
}, {
"hash" : "981d33eeac57d30748795d56c0b7776466b336e7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "981d33eeac57d30748795d56c0b7776466b336e7",
"triggerType" : "PUSH"
}, {
"hash" : "0a0055e5594d49ade0bca3fc9501ace4bcce648c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0a0055e5594d49ade0bca3fc9501ace4bcce648c",
"triggerType" : "PUSH"
}, {
"hash" : "f63a531d8fe2c0431214ff3db03cdf92aea4e954",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f63a531d8fe2c0431214ff3db03cdf92aea4e954",
"triggerType" : "PUSH"
}, {
"hash" : "8971ac82290132f42b946c5654b108f77f18ada9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4987",
"triggerID" : "8971ac82290132f42b946c5654b108f77f18ada9",
"triggerType" : "PUSH"
}, {
"hash" : "3d55d1056c8ce32f48b1e8b114cd0d6f0ce30c2e",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4989",
"triggerID" : "3d55d1056c8ce32f48b1e8b114cd0d6f0ce30c2e",
"triggerType" : "PUSH"
}, {
"hash" : "c847a7880f771fc0586cc3ef24a4805553f5f2c7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4992",
"triggerID" : "c847a7880f771fc0586cc3ef24a4805553f5f2c7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 981d33eeac57d30748795d56c0b7776466b336e7 UNKNOWN
* 0a0055e5594d49ade0bca3fc9501ace4bcce648c UNKNOWN
* f63a531d8fe2c0431214ff3db03cdf92aea4e954 UNKNOWN
* 3d55d1056c8ce32f48b1e8b114cd0d6f0ce30c2e Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4989)
* c847a7880f771fc0586cc3ef24a4805553f5f2c7 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4992)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DRAFT] Address issues for closeable iterators [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13178:
URL: https://github.com/apache/hudi/pull/13178#issuecomment-2817182490
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4970",
"triggerID" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"triggerType" : "PUSH"
}, {
"hash" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4971",
"triggerID" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"triggerType" : "PUSH"
}, {
"hash" : "26676bc85fbd4255a2c6a813a750e493d85e158e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "26676bc85fbd4255a2c6a813a750e493d85e158e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b80162401cb728401120f126918cf0cc1d1e6de2 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4971)
* 26676bc85fbd4255a2c6a813a750e493d85e158e UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DRAFT] Address issues for closeable iterators [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13178:
URL: https://github.com/apache/hudi/pull/13178#issuecomment-2817207027
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4970",
"triggerID" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"triggerType" : "PUSH"
}, {
"hash" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4971",
"triggerID" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"triggerType" : "PUSH"
}, {
"hash" : "26676bc85fbd4255a2c6a813a750e493d85e158e",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4980",
"triggerID" : "26676bc85fbd4255a2c6a813a750e493d85e158e",
"triggerType" : "PUSH"
}, {
"hash" : "0c50f6b7edce83be7bc21affd9eea47b94055767",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4983",
"triggerID" : "0c50f6b7edce83be7bc21affd9eea47b94055767",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 26676bc85fbd4255a2c6a813a750e493d85e158e Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4980)
* 0c50f6b7edce83be7bc21affd9eea47b94055767 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4983)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DRAFT] Address issues for closeable iterators [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13178:
URL: https://github.com/apache/hudi/pull/13178#issuecomment-2816873693
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4970",
"triggerID" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* defb5303cb59dd25feb12c72a4a9420d8c979237 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4970)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9219] Add callbacks for CloseableIterators and eager close data readers [hudi]
Posted by "the-other-tim-brown (via GitHub)" <gi...@apache.org>.
the-other-tim-brown commented on code in PR #13178:
URL: https://github.com/apache/hudi/pull/13178#discussion_r2062857868
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/io/hadoop/HoodieHBaseAvroHFileReader.java:
##########
@@ -628,6 +628,8 @@ public boolean hasNext() {
try {
// NOTE: This is required for idempotency
if (eof) {
+ // eagerly close
+ close();
Review Comment:
Updated the PR to remove all changes to the file reader classes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9219] Add callbacks for CloseableIterators and eager close data readers [hudi]
Posted by "the-other-tim-brown (via GitHub)" <gi...@apache.org>.
the-other-tim-brown commented on code in PR #13178:
URL: https://github.com/apache/hudi/pull/13178#discussion_r2061529121
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/io/hadoop/HoodieHBaseAvroHFileReader.java:
##########
@@ -628,6 +628,8 @@ public boolean hasNext() {
try {
// NOTE: This is required for idempotency
if (eof) {
+ // eagerly close
+ close();
Review Comment:
The rule you are referring to is that the hasNext does not have a side-effect like advancing the position in the collection. That is not broken by this change. If this is a hard line and we cannot do both here, then I can revert these changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9219] Add callbacks for CloseableIterators and eager close data readers [hudi]
Posted by "the-other-tim-brown (via GitHub)" <gi...@apache.org>.
the-other-tim-brown commented on code in PR #13178:
URL: https://github.com/apache/hudi/pull/13178#discussion_r2063972886
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/io/hadoop/HoodieHBaseAvroHFileReader.java:
##########
@@ -628,6 +628,8 @@ public boolean hasNext() {
try {
// NOTE: This is required for idempotency
if (eof) {
+ // eagerly close
+ close();
Review Comment:
updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DRAFT] Address issues for closeable iterators [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13178:
URL: https://github.com/apache/hudi/pull/13178#issuecomment-2817183294
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4970",
"triggerID" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"triggerType" : "PUSH"
}, {
"hash" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4971",
"triggerID" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"triggerType" : "PUSH"
}, {
"hash" : "26676bc85fbd4255a2c6a813a750e493d85e158e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4980",
"triggerID" : "26676bc85fbd4255a2c6a813a750e493d85e158e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b80162401cb728401120f126918cf0cc1d1e6de2 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4971)
* 26676bc85fbd4255a2c6a813a750e493d85e158e Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4980)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DRAFT] Address issues for closeable iterators [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13178:
URL: https://github.com/apache/hudi/pull/13178#issuecomment-2817248261
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4970",
"triggerID" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"triggerType" : "PUSH"
}, {
"hash" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4971",
"triggerID" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"triggerType" : "PUSH"
}, {
"hash" : "26676bc85fbd4255a2c6a813a750e493d85e158e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4980",
"triggerID" : "26676bc85fbd4255a2c6a813a750e493d85e158e",
"triggerType" : "PUSH"
}, {
"hash" : "0c50f6b7edce83be7bc21affd9eea47b94055767",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4983",
"triggerID" : "0c50f6b7edce83be7bc21affd9eea47b94055767",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0c50f6b7edce83be7bc21affd9eea47b94055767 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4983)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DRAFT] Address issues for closeable iterators [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13178:
URL: https://github.com/apache/hudi/pull/13178#issuecomment-2817331377
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4970",
"triggerID" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"triggerType" : "PUSH"
}, {
"hash" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4971",
"triggerID" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"triggerType" : "PUSH"
}, {
"hash" : "26676bc85fbd4255a2c6a813a750e493d85e158e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4980",
"triggerID" : "26676bc85fbd4255a2c6a813a750e493d85e158e",
"triggerType" : "PUSH"
}, {
"hash" : "0c50f6b7edce83be7bc21affd9eea47b94055767",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4983",
"triggerID" : "0c50f6b7edce83be7bc21affd9eea47b94055767",
"triggerType" : "PUSH"
}, {
"hash" : "3c3c2add5afeb79bef4b9a9a5cd5b5e50ed80433",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4986",
"triggerID" : "3c3c2add5afeb79bef4b9a9a5cd5b5e50ed80433",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0c50f6b7edce83be7bc21affd9eea47b94055767 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4983)
* 3c3c2add5afeb79bef4b9a9a5cd5b5e50ed80433 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4986)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9219] Add callbacks for CloseableIterators and eager close data readers [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13178:
URL: https://github.com/apache/hudi/pull/13178#issuecomment-2817382157
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4970",
"triggerID" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"triggerType" : "PUSH"
}, {
"hash" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4971",
"triggerID" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"triggerType" : "PUSH"
}, {
"hash" : "26676bc85fbd4255a2c6a813a750e493d85e158e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4980",
"triggerID" : "26676bc85fbd4255a2c6a813a750e493d85e158e",
"triggerType" : "PUSH"
}, {
"hash" : "0c50f6b7edce83be7bc21affd9eea47b94055767",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4983",
"triggerID" : "0c50f6b7edce83be7bc21affd9eea47b94055767",
"triggerType" : "PUSH"
}, {
"hash" : "3c3c2add5afeb79bef4b9a9a5cd5b5e50ed80433",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4986",
"triggerID" : "3c3c2add5afeb79bef4b9a9a5cd5b5e50ed80433",
"triggerType" : "PUSH"
}, {
"hash" : "981d33eeac57d30748795d56c0b7776466b336e7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "981d33eeac57d30748795d56c0b7776466b336e7",
"triggerType" : "PUSH"
}, {
"hash" : "0a0055e5594d49ade0bca3fc9501ace4bcce648c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0a0055e5594d49ade0bca3fc9501ace4bcce648c",
"triggerType" : "PUSH"
}, {
"hash" : "f63a531d8fe2c0431214ff3db03cdf92aea4e954",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f63a531d8fe2c0431214ff3db03cdf92aea4e954",
"triggerType" : "PUSH"
}, {
"hash" : "8971ac82290132f42b946c5654b108f77f18ada9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4987",
"triggerID" : "8971ac82290132f42b946c5654b108f77f18ada9",
"triggerType" : "PUSH"
}, {
"hash" : "3d55d1056c8ce32f48b1e8b114cd0d6f0ce30c2e",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4989",
"triggerID" : "3d55d1056c8ce32f48b1e8b114cd0d6f0ce30c2e",
"triggerType" : "PUSH"
}, {
"hash" : "c847a7880f771fc0586cc3ef24a4805553f5f2c7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c847a7880f771fc0586cc3ef24a4805553f5f2c7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 981d33eeac57d30748795d56c0b7776466b336e7 UNKNOWN
* 0a0055e5594d49ade0bca3fc9501ace4bcce648c UNKNOWN
* f63a531d8fe2c0431214ff3db03cdf92aea4e954 UNKNOWN
* 3d55d1056c8ce32f48b1e8b114cd0d6f0ce30c2e Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4989)
* c847a7880f771fc0586cc3ef24a4805553f5f2c7 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9219] Add callbacks for CloseableIterators and eager close data readers [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #13178:
URL: https://github.com/apache/hudi/pull/13178#discussion_r2062811883
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/io/hadoop/HoodieHBaseAvroHFileReader.java:
##########
@@ -628,6 +628,8 @@ public boolean hasNext() {
try {
// NOTE: This is required for idempotency
if (eof) {
+ // eagerly close
+ close();
Review Comment:
let's revert the eager close.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9219] Add callbacks for CloseableIterators and eager close data readers [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #13178:
URL: https://github.com/apache/hudi/pull/13178#discussion_r2059406934
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/io/hadoop/HoodieHBaseAvroHFileReader.java:
##########
@@ -628,6 +628,8 @@ public boolean hasNext() {
try {
// NOTE: This is required for idempotency
if (eof) {
+ // eagerly close
+ close();
Review Comment:
yeah, understand, but eager close is not often used in code, I suggest we remove it and unify the code to `AutoClosable` and `try-resource` for resource releasing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9219] Add callbacks for CloseableIterators and eager close data readers [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13178:
URL: https://github.com/apache/hudi/pull/13178#issuecomment-2834023026
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4970",
"triggerID" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"triggerType" : "PUSH"
}, {
"hash" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4971",
"triggerID" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"triggerType" : "PUSH"
}, {
"hash" : "26676bc85fbd4255a2c6a813a750e493d85e158e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4980",
"triggerID" : "26676bc85fbd4255a2c6a813a750e493d85e158e",
"triggerType" : "PUSH"
}, {
"hash" : "0c50f6b7edce83be7bc21affd9eea47b94055767",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4983",
"triggerID" : "0c50f6b7edce83be7bc21affd9eea47b94055767",
"triggerType" : "PUSH"
}, {
"hash" : "3c3c2add5afeb79bef4b9a9a5cd5b5e50ed80433",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4986",
"triggerID" : "3c3c2add5afeb79bef4b9a9a5cd5b5e50ed80433",
"triggerType" : "PUSH"
}, {
"hash" : "981d33eeac57d30748795d56c0b7776466b336e7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "981d33eeac57d30748795d56c0b7776466b336e7",
"triggerType" : "PUSH"
}, {
"hash" : "0a0055e5594d49ade0bca3fc9501ace4bcce648c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0a0055e5594d49ade0bca3fc9501ace4bcce648c",
"triggerType" : "PUSH"
}, {
"hash" : "f63a531d8fe2c0431214ff3db03cdf92aea4e954",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f63a531d8fe2c0431214ff3db03cdf92aea4e954",
"triggerType" : "PUSH"
}, {
"hash" : "8971ac82290132f42b946c5654b108f77f18ada9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4987",
"triggerID" : "8971ac82290132f42b946c5654b108f77f18ada9",
"triggerType" : "PUSH"
}, {
"hash" : "3d55d1056c8ce32f48b1e8b114cd0d6f0ce30c2e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4989",
"triggerID" : "3d55d1056c8ce32f48b1e8b114cd0d6f0ce30c2e",
"triggerType" : "PUSH"
}, {
"hash" : "c847a7880f771fc0586cc3ef24a4805553f5f2c7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4992",
"triggerID" : "c847a7880f771fc0586cc3ef24a4805553f5f2c7",
"triggerType" : "PUSH"
}, {
"hash" : "d0c019c72df970c138647715a84e5d5df9740b31",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=5109",
"triggerID" : "d0c019c72df970c138647715a84e5d5df9740b31",
"triggerType" : "PUSH"
}, {
"hash" : "d36a5efe3bbeb47117831f916e286096985aa07b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=5175",
"triggerID" : "d36a5efe3bbeb47117831f916e286096985aa07b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 981d33eeac57d30748795d56c0b7776466b336e7 UNKNOWN
* 0a0055e5594d49ade0bca3fc9501ace4bcce648c UNKNOWN
* f63a531d8fe2c0431214ff3db03cdf92aea4e954 UNKNOWN
* d36a5efe3bbeb47117831f916e286096985aa07b Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=5175)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9219] Add callbacks for CloseableIterators and eager close data readers [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #13178:
URL: https://github.com/apache/hudi/pull/13178#discussion_r2061014318
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/io/hadoop/HoodieHBaseAvroHFileReader.java:
##########
@@ -628,6 +628,8 @@ public boolean hasNext() {
try {
// NOTE: This is required for idempotency
if (eof) {
+ // eagerly close
+ close();
Review Comment:
The iterator is designed to be no side effect actually, we breaks it already for introducing `ClosableIterator`, and now we breaks the rule silently during the iteration which I think is not a very good convention to follow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9219] Add callbacks for CloseableIterators and eager close data readers [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #13178:
URL: https://github.com/apache/hudi/pull/13178#discussion_r2057527407
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/io/hadoop/HoodieHBaseAvroHFileReader.java:
##########
@@ -628,6 +628,8 @@ public boolean hasNext() {
try {
// NOTE: This is required for idempotency
if (eof) {
+ // eagerly close
+ close();
Review Comment:
we have these eagerly close, do we still need to invoke the `Iterator.close` outside? Looks the logic is redundant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9219] Add callbacks for CloseableIterators and eager close data readers [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #13178:
URL: https://github.com/apache/hudi/pull/13178#discussion_r2057527407
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/io/hadoop/HoodieHBaseAvroHFileReader.java:
##########
@@ -628,6 +628,8 @@ public boolean hasNext() {
try {
// NOTE: This is required for idempotency
if (eof) {
+ // eagerly close
+ close();
Review Comment:
we have these eagerly close, do we still need to invoke the `Iterator.close` outside?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9219] Add callbacks for CloseableIterators and eager close data readers [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13178:
URL: https://github.com/apache/hudi/pull/13178#issuecomment-2817350693
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4970",
"triggerID" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"triggerType" : "PUSH"
}, {
"hash" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4971",
"triggerID" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"triggerType" : "PUSH"
}, {
"hash" : "26676bc85fbd4255a2c6a813a750e493d85e158e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4980",
"triggerID" : "26676bc85fbd4255a2c6a813a750e493d85e158e",
"triggerType" : "PUSH"
}, {
"hash" : "0c50f6b7edce83be7bc21affd9eea47b94055767",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4983",
"triggerID" : "0c50f6b7edce83be7bc21affd9eea47b94055767",
"triggerType" : "PUSH"
}, {
"hash" : "3c3c2add5afeb79bef4b9a9a5cd5b5e50ed80433",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4986",
"triggerID" : "3c3c2add5afeb79bef4b9a9a5cd5b5e50ed80433",
"triggerType" : "PUSH"
}, {
"hash" : "981d33eeac57d30748795d56c0b7776466b336e7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "981d33eeac57d30748795d56c0b7776466b336e7",
"triggerType" : "PUSH"
}, {
"hash" : "0a0055e5594d49ade0bca3fc9501ace4bcce648c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0a0055e5594d49ade0bca3fc9501ace4bcce648c",
"triggerType" : "PUSH"
}, {
"hash" : "f63a531d8fe2c0431214ff3db03cdf92aea4e954",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f63a531d8fe2c0431214ff3db03cdf92aea4e954",
"triggerType" : "PUSH"
}, {
"hash" : "8971ac82290132f42b946c5654b108f77f18ada9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4987",
"triggerID" : "8971ac82290132f42b946c5654b108f77f18ada9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3c3c2add5afeb79bef4b9a9a5cd5b5e50ed80433 Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4986)
* 981d33eeac57d30748795d56c0b7776466b336e7 UNKNOWN
* 0a0055e5594d49ade0bca3fc9501ace4bcce648c UNKNOWN
* f63a531d8fe2c0431214ff3db03cdf92aea4e954 UNKNOWN
* 8971ac82290132f42b946c5654b108f77f18ada9 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4987)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9219] Add callbacks for CloseableIterators and eager close data readers [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13178:
URL: https://github.com/apache/hudi/pull/13178#issuecomment-2835700575
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4970",
"triggerID" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"triggerType" : "PUSH"
}, {
"hash" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4971",
"triggerID" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"triggerType" : "PUSH"
}, {
"hash" : "26676bc85fbd4255a2c6a813a750e493d85e158e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4980",
"triggerID" : "26676bc85fbd4255a2c6a813a750e493d85e158e",
"triggerType" : "PUSH"
}, {
"hash" : "0c50f6b7edce83be7bc21affd9eea47b94055767",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4983",
"triggerID" : "0c50f6b7edce83be7bc21affd9eea47b94055767",
"triggerType" : "PUSH"
}, {
"hash" : "3c3c2add5afeb79bef4b9a9a5cd5b5e50ed80433",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4986",
"triggerID" : "3c3c2add5afeb79bef4b9a9a5cd5b5e50ed80433",
"triggerType" : "PUSH"
}, {
"hash" : "981d33eeac57d30748795d56c0b7776466b336e7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "981d33eeac57d30748795d56c0b7776466b336e7",
"triggerType" : "PUSH"
}, {
"hash" : "0a0055e5594d49ade0bca3fc9501ace4bcce648c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0a0055e5594d49ade0bca3fc9501ace4bcce648c",
"triggerType" : "PUSH"
}, {
"hash" : "f63a531d8fe2c0431214ff3db03cdf92aea4e954",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f63a531d8fe2c0431214ff3db03cdf92aea4e954",
"triggerType" : "PUSH"
}, {
"hash" : "8971ac82290132f42b946c5654b108f77f18ada9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4987",
"triggerID" : "8971ac82290132f42b946c5654b108f77f18ada9",
"triggerType" : "PUSH"
}, {
"hash" : "3d55d1056c8ce32f48b1e8b114cd0d6f0ce30c2e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4989",
"triggerID" : "3d55d1056c8ce32f48b1e8b114cd0d6f0ce30c2e",
"triggerType" : "PUSH"
}, {
"hash" : "c847a7880f771fc0586cc3ef24a4805553f5f2c7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4992",
"triggerID" : "c847a7880f771fc0586cc3ef24a4805553f5f2c7",
"triggerType" : "PUSH"
}, {
"hash" : "d0c019c72df970c138647715a84e5d5df9740b31",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=5109",
"triggerID" : "d0c019c72df970c138647715a84e5d5df9740b31",
"triggerType" : "PUSH"
}, {
"hash" : "d36a5efe3bbeb47117831f916e286096985aa07b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=5175",
"triggerID" : "d36a5efe3bbeb47117831f916e286096985aa07b",
"triggerType" : "PUSH"
}, {
"hash" : "d8a534839b7f77d9dd1370c695f27ab8ca68f0fe",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d8a534839b7f77d9dd1370c695f27ab8ca68f0fe",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 981d33eeac57d30748795d56c0b7776466b336e7 UNKNOWN
* 0a0055e5594d49ade0bca3fc9501ace4bcce648c UNKNOWN
* f63a531d8fe2c0431214ff3db03cdf92aea4e954 UNKNOWN
* d36a5efe3bbeb47117831f916e286096985aa07b Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=5175)
* d8a534839b7f77d9dd1370c695f27ab8ca68f0fe UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9219] Add callbacks for CloseableIterators and eager close data readers [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 merged PR #13178:
URL: https://github.com/apache/hudi/pull/13178
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9219] Add callbacks for CloseableIterators and eager close data readers [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13178:
URL: https://github.com/apache/hudi/pull/13178#issuecomment-2833935403
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4970",
"triggerID" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"triggerType" : "PUSH"
}, {
"hash" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4971",
"triggerID" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"triggerType" : "PUSH"
}, {
"hash" : "26676bc85fbd4255a2c6a813a750e493d85e158e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4980",
"triggerID" : "26676bc85fbd4255a2c6a813a750e493d85e158e",
"triggerType" : "PUSH"
}, {
"hash" : "0c50f6b7edce83be7bc21affd9eea47b94055767",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4983",
"triggerID" : "0c50f6b7edce83be7bc21affd9eea47b94055767",
"triggerType" : "PUSH"
}, {
"hash" : "3c3c2add5afeb79bef4b9a9a5cd5b5e50ed80433",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4986",
"triggerID" : "3c3c2add5afeb79bef4b9a9a5cd5b5e50ed80433",
"triggerType" : "PUSH"
}, {
"hash" : "981d33eeac57d30748795d56c0b7776466b336e7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "981d33eeac57d30748795d56c0b7776466b336e7",
"triggerType" : "PUSH"
}, {
"hash" : "0a0055e5594d49ade0bca3fc9501ace4bcce648c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0a0055e5594d49ade0bca3fc9501ace4bcce648c",
"triggerType" : "PUSH"
}, {
"hash" : "f63a531d8fe2c0431214ff3db03cdf92aea4e954",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f63a531d8fe2c0431214ff3db03cdf92aea4e954",
"triggerType" : "PUSH"
}, {
"hash" : "8971ac82290132f42b946c5654b108f77f18ada9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4987",
"triggerID" : "8971ac82290132f42b946c5654b108f77f18ada9",
"triggerType" : "PUSH"
}, {
"hash" : "3d55d1056c8ce32f48b1e8b114cd0d6f0ce30c2e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4989",
"triggerID" : "3d55d1056c8ce32f48b1e8b114cd0d6f0ce30c2e",
"triggerType" : "PUSH"
}, {
"hash" : "c847a7880f771fc0586cc3ef24a4805553f5f2c7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4992",
"triggerID" : "c847a7880f771fc0586cc3ef24a4805553f5f2c7",
"triggerType" : "PUSH"
}, {
"hash" : "d0c019c72df970c138647715a84e5d5df9740b31",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=5109",
"triggerID" : "d0c019c72df970c138647715a84e5d5df9740b31",
"triggerType" : "PUSH"
}, {
"hash" : "d36a5efe3bbeb47117831f916e286096985aa07b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=5175",
"triggerID" : "d36a5efe3bbeb47117831f916e286096985aa07b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 981d33eeac57d30748795d56c0b7776466b336e7 UNKNOWN
* 0a0055e5594d49ade0bca3fc9501ace4bcce648c UNKNOWN
* f63a531d8fe2c0431214ff3db03cdf92aea4e954 UNKNOWN
* d0c019c72df970c138647715a84e5d5df9740b31 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=5109)
* d36a5efe3bbeb47117831f916e286096985aa07b Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=5175)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9219] Add callbacks for CloseableIterators and eager close data readers [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13178:
URL: https://github.com/apache/hudi/pull/13178#issuecomment-2833926999
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4970",
"triggerID" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"triggerType" : "PUSH"
}, {
"hash" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4971",
"triggerID" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"triggerType" : "PUSH"
}, {
"hash" : "26676bc85fbd4255a2c6a813a750e493d85e158e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4980",
"triggerID" : "26676bc85fbd4255a2c6a813a750e493d85e158e",
"triggerType" : "PUSH"
}, {
"hash" : "0c50f6b7edce83be7bc21affd9eea47b94055767",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4983",
"triggerID" : "0c50f6b7edce83be7bc21affd9eea47b94055767",
"triggerType" : "PUSH"
}, {
"hash" : "3c3c2add5afeb79bef4b9a9a5cd5b5e50ed80433",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4986",
"triggerID" : "3c3c2add5afeb79bef4b9a9a5cd5b5e50ed80433",
"triggerType" : "PUSH"
}, {
"hash" : "981d33eeac57d30748795d56c0b7776466b336e7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "981d33eeac57d30748795d56c0b7776466b336e7",
"triggerType" : "PUSH"
}, {
"hash" : "0a0055e5594d49ade0bca3fc9501ace4bcce648c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0a0055e5594d49ade0bca3fc9501ace4bcce648c",
"triggerType" : "PUSH"
}, {
"hash" : "f63a531d8fe2c0431214ff3db03cdf92aea4e954",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f63a531d8fe2c0431214ff3db03cdf92aea4e954",
"triggerType" : "PUSH"
}, {
"hash" : "8971ac82290132f42b946c5654b108f77f18ada9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4987",
"triggerID" : "8971ac82290132f42b946c5654b108f77f18ada9",
"triggerType" : "PUSH"
}, {
"hash" : "3d55d1056c8ce32f48b1e8b114cd0d6f0ce30c2e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4989",
"triggerID" : "3d55d1056c8ce32f48b1e8b114cd0d6f0ce30c2e",
"triggerType" : "PUSH"
}, {
"hash" : "c847a7880f771fc0586cc3ef24a4805553f5f2c7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4992",
"triggerID" : "c847a7880f771fc0586cc3ef24a4805553f5f2c7",
"triggerType" : "PUSH"
}, {
"hash" : "d0c019c72df970c138647715a84e5d5df9740b31",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=5109",
"triggerID" : "d0c019c72df970c138647715a84e5d5df9740b31",
"triggerType" : "PUSH"
}, {
"hash" : "d36a5efe3bbeb47117831f916e286096985aa07b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d36a5efe3bbeb47117831f916e286096985aa07b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 981d33eeac57d30748795d56c0b7776466b336e7 UNKNOWN
* 0a0055e5594d49ade0bca3fc9501ace4bcce648c UNKNOWN
* f63a531d8fe2c0431214ff3db03cdf92aea4e954 UNKNOWN
* d0c019c72df970c138647715a84e5d5df9740b31 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=5109)
* d36a5efe3bbeb47117831f916e286096985aa07b UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9219] Add callbacks for CloseableIterators and eager close data readers [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13178:
URL: https://github.com/apache/hudi/pull/13178#issuecomment-2817372408
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4970",
"triggerID" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"triggerType" : "PUSH"
}, {
"hash" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4971",
"triggerID" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"triggerType" : "PUSH"
}, {
"hash" : "26676bc85fbd4255a2c6a813a750e493d85e158e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4980",
"triggerID" : "26676bc85fbd4255a2c6a813a750e493d85e158e",
"triggerType" : "PUSH"
}, {
"hash" : "0c50f6b7edce83be7bc21affd9eea47b94055767",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4983",
"triggerID" : "0c50f6b7edce83be7bc21affd9eea47b94055767",
"triggerType" : "PUSH"
}, {
"hash" : "3c3c2add5afeb79bef4b9a9a5cd5b5e50ed80433",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4986",
"triggerID" : "3c3c2add5afeb79bef4b9a9a5cd5b5e50ed80433",
"triggerType" : "PUSH"
}, {
"hash" : "981d33eeac57d30748795d56c0b7776466b336e7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "981d33eeac57d30748795d56c0b7776466b336e7",
"triggerType" : "PUSH"
}, {
"hash" : "0a0055e5594d49ade0bca3fc9501ace4bcce648c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0a0055e5594d49ade0bca3fc9501ace4bcce648c",
"triggerType" : "PUSH"
}, {
"hash" : "f63a531d8fe2c0431214ff3db03cdf92aea4e954",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f63a531d8fe2c0431214ff3db03cdf92aea4e954",
"triggerType" : "PUSH"
}, {
"hash" : "8971ac82290132f42b946c5654b108f77f18ada9",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4987",
"triggerID" : "8971ac82290132f42b946c5654b108f77f18ada9",
"triggerType" : "PUSH"
}, {
"hash" : "3d55d1056c8ce32f48b1e8b114cd0d6f0ce30c2e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4989",
"triggerID" : "3d55d1056c8ce32f48b1e8b114cd0d6f0ce30c2e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 981d33eeac57d30748795d56c0b7776466b336e7 UNKNOWN
* 0a0055e5594d49ade0bca3fc9501ace4bcce648c UNKNOWN
* f63a531d8fe2c0431214ff3db03cdf92aea4e954 UNKNOWN
* 8971ac82290132f42b946c5654b108f77f18ada9 Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4987)
* 3d55d1056c8ce32f48b1e8b114cd0d6f0ce30c2e Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4989)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9219] Add callbacks for CloseableIterators and eager close data readers [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13178:
URL: https://github.com/apache/hudi/pull/13178#issuecomment-2817458851
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4970",
"triggerID" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"triggerType" : "PUSH"
}, {
"hash" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4971",
"triggerID" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"triggerType" : "PUSH"
}, {
"hash" : "26676bc85fbd4255a2c6a813a750e493d85e158e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4980",
"triggerID" : "26676bc85fbd4255a2c6a813a750e493d85e158e",
"triggerType" : "PUSH"
}, {
"hash" : "0c50f6b7edce83be7bc21affd9eea47b94055767",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4983",
"triggerID" : "0c50f6b7edce83be7bc21affd9eea47b94055767",
"triggerType" : "PUSH"
}, {
"hash" : "3c3c2add5afeb79bef4b9a9a5cd5b5e50ed80433",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4986",
"triggerID" : "3c3c2add5afeb79bef4b9a9a5cd5b5e50ed80433",
"triggerType" : "PUSH"
}, {
"hash" : "981d33eeac57d30748795d56c0b7776466b336e7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "981d33eeac57d30748795d56c0b7776466b336e7",
"triggerType" : "PUSH"
}, {
"hash" : "0a0055e5594d49ade0bca3fc9501ace4bcce648c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0a0055e5594d49ade0bca3fc9501ace4bcce648c",
"triggerType" : "PUSH"
}, {
"hash" : "f63a531d8fe2c0431214ff3db03cdf92aea4e954",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f63a531d8fe2c0431214ff3db03cdf92aea4e954",
"triggerType" : "PUSH"
}, {
"hash" : "8971ac82290132f42b946c5654b108f77f18ada9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4987",
"triggerID" : "8971ac82290132f42b946c5654b108f77f18ada9",
"triggerType" : "PUSH"
}, {
"hash" : "3d55d1056c8ce32f48b1e8b114cd0d6f0ce30c2e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4989",
"triggerID" : "3d55d1056c8ce32f48b1e8b114cd0d6f0ce30c2e",
"triggerType" : "PUSH"
}, {
"hash" : "c847a7880f771fc0586cc3ef24a4805553f5f2c7",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4992",
"triggerID" : "c847a7880f771fc0586cc3ef24a4805553f5f2c7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 981d33eeac57d30748795d56c0b7776466b336e7 UNKNOWN
* 0a0055e5594d49ade0bca3fc9501ace4bcce648c UNKNOWN
* f63a531d8fe2c0431214ff3db03cdf92aea4e954 UNKNOWN
* c847a7880f771fc0586cc3ef24a4805553f5f2c7 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4992)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9219] Add callbacks for CloseableIterators and eager close data readers [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13178:
URL: https://github.com/apache/hudi/pull/13178#issuecomment-2817458711
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4970",
"triggerID" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"triggerType" : "PUSH"
}, {
"hash" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4971",
"triggerID" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"triggerType" : "PUSH"
}, {
"hash" : "26676bc85fbd4255a2c6a813a750e493d85e158e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4980",
"triggerID" : "26676bc85fbd4255a2c6a813a750e493d85e158e",
"triggerType" : "PUSH"
}, {
"hash" : "0c50f6b7edce83be7bc21affd9eea47b94055767",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4983",
"triggerID" : "0c50f6b7edce83be7bc21affd9eea47b94055767",
"triggerType" : "PUSH"
}, {
"hash" : "3c3c2add5afeb79bef4b9a9a5cd5b5e50ed80433",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4986",
"triggerID" : "3c3c2add5afeb79bef4b9a9a5cd5b5e50ed80433",
"triggerType" : "PUSH"
}, {
"hash" : "981d33eeac57d30748795d56c0b7776466b336e7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "981d33eeac57d30748795d56c0b7776466b336e7",
"triggerType" : "PUSH"
}, {
"hash" : "0a0055e5594d49ade0bca3fc9501ace4bcce648c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0a0055e5594d49ade0bca3fc9501ace4bcce648c",
"triggerType" : "PUSH"
}, {
"hash" : "f63a531d8fe2c0431214ff3db03cdf92aea4e954",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f63a531d8fe2c0431214ff3db03cdf92aea4e954",
"triggerType" : "PUSH"
}, {
"hash" : "8971ac82290132f42b946c5654b108f77f18ada9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4987",
"triggerID" : "8971ac82290132f42b946c5654b108f77f18ada9",
"triggerType" : "PUSH"
}, {
"hash" : "3d55d1056c8ce32f48b1e8b114cd0d6f0ce30c2e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4989",
"triggerID" : "3d55d1056c8ce32f48b1e8b114cd0d6f0ce30c2e",
"triggerType" : "PUSH"
}, {
"hash" : "c847a7880f771fc0586cc3ef24a4805553f5f2c7",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4992",
"triggerID" : "c847a7880f771fc0586cc3ef24a4805553f5f2c7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 981d33eeac57d30748795d56c0b7776466b336e7 UNKNOWN
* 0a0055e5594d49ade0bca3fc9501ace4bcce648c UNKNOWN
* f63a531d8fe2c0431214ff3db03cdf92aea4e954 UNKNOWN
* c847a7880f771fc0586cc3ef24a4805553f5f2c7 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4992)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9219] Add callbacks for CloseableIterators and eager close data readers [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13178:
URL: https://github.com/apache/hudi/pull/13178#issuecomment-2826161042
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4970",
"triggerID" : "defb5303cb59dd25feb12c72a4a9420d8c979237",
"triggerType" : "PUSH"
}, {
"hash" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4971",
"triggerID" : "b80162401cb728401120f126918cf0cc1d1e6de2",
"triggerType" : "PUSH"
}, {
"hash" : "26676bc85fbd4255a2c6a813a750e493d85e158e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4980",
"triggerID" : "26676bc85fbd4255a2c6a813a750e493d85e158e",
"triggerType" : "PUSH"
}, {
"hash" : "0c50f6b7edce83be7bc21affd9eea47b94055767",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4983",
"triggerID" : "0c50f6b7edce83be7bc21affd9eea47b94055767",
"triggerType" : "PUSH"
}, {
"hash" : "3c3c2add5afeb79bef4b9a9a5cd5b5e50ed80433",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4986",
"triggerID" : "3c3c2add5afeb79bef4b9a9a5cd5b5e50ed80433",
"triggerType" : "PUSH"
}, {
"hash" : "981d33eeac57d30748795d56c0b7776466b336e7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "981d33eeac57d30748795d56c0b7776466b336e7",
"triggerType" : "PUSH"
}, {
"hash" : "0a0055e5594d49ade0bca3fc9501ace4bcce648c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0a0055e5594d49ade0bca3fc9501ace4bcce648c",
"triggerType" : "PUSH"
}, {
"hash" : "f63a531d8fe2c0431214ff3db03cdf92aea4e954",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f63a531d8fe2c0431214ff3db03cdf92aea4e954",
"triggerType" : "PUSH"
}, {
"hash" : "8971ac82290132f42b946c5654b108f77f18ada9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4987",
"triggerID" : "8971ac82290132f42b946c5654b108f77f18ada9",
"triggerType" : "PUSH"
}, {
"hash" : "3d55d1056c8ce32f48b1e8b114cd0d6f0ce30c2e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4989",
"triggerID" : "3d55d1056c8ce32f48b1e8b114cd0d6f0ce30c2e",
"triggerType" : "PUSH"
}, {
"hash" : "c847a7880f771fc0586cc3ef24a4805553f5f2c7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4992",
"triggerID" : "c847a7880f771fc0586cc3ef24a4805553f5f2c7",
"triggerType" : "PUSH"
}, {
"hash" : "d0c019c72df970c138647715a84e5d5df9740b31",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=5109",
"triggerID" : "d0c019c72df970c138647715a84e5d5df9740b31",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 981d33eeac57d30748795d56c0b7776466b336e7 UNKNOWN
* 0a0055e5594d49ade0bca3fc9501ace4bcce648c UNKNOWN
* f63a531d8fe2c0431214ff3db03cdf92aea4e954 UNKNOWN
* d0c019c72df970c138647715a84e5d5df9740b31 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=5109)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org