You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by bu...@apache.org on 2005/07/18 06:15:42 UTC
DO NOT REPLY [Bug 35037] -
[PATCH] Some Field methods use Classcast check instead of instanceof which is slow
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=35037>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=35037
------- Additional Comments From rnewson@connected.com 2005-07-18 06:15 -------
As another style comment, the else clause is unnecessary;
if (fieldsData instanceof String) {
return (String)fieldsData;
}
return null;
Eclipse highlights the current patches 'else { return null;}' with a warning.
I was also wondering why Field.java is not indented...
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org