[jira] [Commented] (SPARK-11502) Word2VecSuite needs appropriate checks

["Joseph K. Bradley (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SPARK-11502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15232737#comment-15232737 ] 

Joseph K. Bradley commented on SPARK-11502:
-------------------------------------------

[~yuhaoyan] I just came across this JIRA again.  Were you able to do some investigation?

> Word2VecSuite needs appropriate checks
> --------------------------------------
>
>                 Key: SPARK-11502
>                 URL: https://issues.apache.org/jira/browse/SPARK-11502
>             Project: Spark
>          Issue Type: Test
>          Components: ML
>    Affects Versions: 1.6.0
>            Reporter: Imran Rashid
>            Priority: Minor
>
> When the random number generator was changed slightly in SPARK-10116, {{ml.feature.Word2VecSuite}} started failing.  The tests were updated to have "magic" values, to at least provide minimal characterization tests preventing more behavior changes.  However, the tests really need to be improved to have more sensible checks.
> Note that brute force search over seeds from 0 to 1000 failed to find one that worked -- the input data seems to be careful chosen for the previous random number generator / seed combo.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org