You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by kkewwei <gi...@git.apache.org> on 2017/09/03 16:57:44 UTC
[GitHub] lucene-solr pull request #242: a little error about TopDocs
GitHub user kkewwei opened a pull request:
https://github.com/apache/lucene-solr/pull/242
a little error about TopDocs
as the comment says :"Returns true if first is < second", but the fact is opposited
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kkewwei/lucene-solr master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucene-solr/pull/242.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #242
----
commit 2b3a30aaaa2c67fae7c6f4cc4d48754056f07d80
Author: kewei03 <ke...@.com>
Date: 2017-09-03T16:53:45Z
a little error about TopDocs
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr issue #242: a little error about TopDocs
Posted by jpountz <gi...@git.apache.org>.
Github user jpountz commented on the issue:
https://github.com/apache/lucene-solr/pull/242
I agree the naming might be confusing but the logic is actually correct. This is due to the fact that we want documents with higher scores first, so we need to make them compare "less than" documents that have lower scores.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr issue #242: a little error about TopDocs
Posted by cpoerschke <gi...@git.apache.org>.
Github user cpoerschke commented on the issue:
https://github.com/apache/lucene-solr/pull/242
Thanks @kkewwei for reporting this! I have created https://issues.apache.org/jira/browse/LUCENE-7952 to track the issue and its fixing.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org