You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "weizhouapache (via GitHub)" <gi...@apache.org> on 2023/08/25 07:47:47 UTC
[GitHub] [cloudstack] weizhouapache opened a new pull request, #7913: server: throw new exception when rootdisksize is required but not set
weizhouapache opened a new pull request, #7913:
URL: https://github.com/apache/cloudstack/pull/7913
### Description
This PR fixes #7115
Steps to reproduce the issue
- create a service offering with "Custom Disk", "Disk offering strictness" is also enabled.
- deploy a vm with the new service offering, but not "Override root disk size"
Before this PR:
With this PR:
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7913: server: throw new exception when rootdisksize is required but not set
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7913:
URL: https://github.com/apache/cloudstack/pull/7913#issuecomment-1693104059
@weizhouapache a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7913: server: throw new exception when rootdisksize is required but not set
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7913:
URL: https://github.com/apache/cloudstack/pull/7913#issuecomment-1694879781
<b>[SF] Trillian test result (tid-7579)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 44333 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7913-t7579-vmware-67u3.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_deploy_vm_from_iso | `Error` | 9.42 | test_deploy_vm_iso.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #7913: server: throw new exception when rootdisksize is required but not set
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #7913:
URL: https://github.com/apache/cloudstack/pull/7913#issuecomment-1694589920
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/7913?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#7913](https://app.codecov.io/gh/apache/cloudstack/pull/7913?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (cdebe25) into [4.18](https://app.codecov.io/gh/apache/cloudstack/commit/3c38ed7a6567b95f3c18c094094e0447231c0aa2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (3c38ed7) will **decrease** coverage by `0.01%`.
> Report is 8 commits behind head on 4.18.
> The diff coverage is `17.50%`.
> :exclamation: Current head cdebe25 differs from pull request most recent head 3c60cc2. Consider uploading reports for the commit 3c60cc2 to get more accurate results
```diff
@@ Coverage Diff @@
## 4.18 #7913 +/- ##
============================================
- Coverage 13.06% 13.06% -0.01%
- Complexity 9088 9092 +4
============================================
Files 2720 2720
Lines 257391 257417 +26
Branches 40130 40137 +7
============================================
+ Hits 33621 33623 +2
- Misses 219548 219569 +21
- Partials 4222 4225 +3
```
| [Files Changed](https://app.codecov.io/gh/apache/cloudstack/pull/7913?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...stack/engine/orchestration/VolumeOrchestrator.java](https://app.codecov.io/gh/apache/cloudstack/pull/7913?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZW5naW5lL29yY2hlc3RyYXRpb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svZW5naW5lL29yY2hlc3RyYXRpb24vVm9sdW1lT3JjaGVzdHJhdG9yLmphdmE=) | `1.89% <0.00%> (ø)` | |
| [...visor/vmware/manager/VmwareStorageManagerImpl.java](https://app.codecov.io/gh/apache/cloudstack/pull/7913?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGx1Z2lucy9oeXBlcnZpc29ycy92bXdhcmUvc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci92bXdhcmUvbWFuYWdlci9WbXdhcmVTdG9yYWdlTWFuYWdlckltcGwuamF2YQ==) | `6.20% <0.00%> (-0.03%)` | :arrow_down: |
| [...oud/hypervisor/vmware/resource/VmwareResource.java](https://app.codecov.io/gh/apache/cloudstack/pull/7913?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGx1Z2lucy9oeXBlcnZpc29ycy92bXdhcmUvc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci92bXdhcmUvcmVzb3VyY2UvVm13YXJlUmVzb3VyY2UuamF2YQ==) | `4.48% <0.00%> (-0.01%)` | :arrow_down: |
| [...cloud/storage/resource/VmwareStorageProcessor.java](https://app.codecov.io/gh/apache/cloudstack/pull/7913?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGx1Z2lucy9oeXBlcnZpc29ycy92bXdhcmUvc3JjL21haW4vamF2YS9jb20vY2xvdWQvc3RvcmFnZS9yZXNvdXJjZS9WbXdhcmVTdG9yYWdlUHJvY2Vzc29yLmphdmE=) | `0.32% <0.00%> (-0.01%)` | :arrow_down: |
| [...astore/driver/SolidFirePrimaryDataStoreDriver.java](https://app.codecov.io/gh/apache/cloudstack/pull/7913?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGx1Z2lucy9zdG9yYWdlL3ZvbHVtZS9zb2xpZGZpcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svc3RvcmFnZS9kYXRhc3RvcmUvZHJpdmVyL1NvbGlkRmlyZVByaW1hcnlEYXRhU3RvcmVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ud/hypervisor/vmware/mo/HostDatastoreSystemMO.java](https://app.codecov.io/gh/apache/cloudstack/pull/7913?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dm13YXJlLWJhc2Uvc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci92bXdhcmUvbW8vSG9zdERhdGFzdG9yZVN5c3RlbU1PLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...com/cloud/hypervisor/vmware/util/VmwareHelper.java](https://app.codecov.io/gh/apache/cloudstack/pull/7913?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dm13YXJlLWJhc2Uvc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci92bXdhcmUvdXRpbC9WbXdhcmVIZWxwZXIuamF2YQ==) | `8.65% <ø> (ø)` | |
| [.../src/main/java/com/cloud/vm/UserVmManagerImpl.java](https://app.codecov.io/gh/apache/cloudstack/pull/7913?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL3ZtL1VzZXJWbU1hbmFnZXJJbXBsLmphdmE=) | `7.52% <100.00%> (+0.04%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7913: server: throw new exception when rootdisksize is required but not set
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7913:
URL: https://github.com/apache/cloudstack/pull/7913#issuecomment-1693103655
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7913: server: throw new exception when rootdisksize is required but not set
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7913:
URL: https://github.com/apache/cloudstack/pull/7913#issuecomment-1695136578
latest smoke test looks good
```
# cat /marvin//MarvinLogs/test_deploy_vm_iso_9P5EZ4/results.txt
Test Deploy Virtual Machine from ISO ... === TestName: test_deploy_vm_from_iso | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 1 test in 96.624s
OK
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache merged pull request #7913: server: throw new exception when rootdisksize is required but not set
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache merged PR #7913:
URL: https://github.com/apache/cloudstack/pull/7913
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7913: server: throw new exception when rootdisksize is required but not set
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7913:
URL: https://github.com/apache/cloudstack/pull/7913#issuecomment-1694549395
<b>[SF] Trillian test result (tid-7568)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46123 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7913-t7568-kvm-centos7.zip
Smoke tests completed. 106 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_deploy_vm_from_iso | `Error` | 7.97 | test_deploy_vm_iso.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 366.19 | test_vpc_redundant.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7913: server: throw new exception when rootdisksize is required but not set
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7913:
URL: https://github.com/apache/cloudstack/pull/7913#issuecomment-1695070122
@weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7913: server: throw new exception when rootdisksize is required but not set
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7913:
URL: https://github.com/apache/cloudstack/pull/7913#issuecomment-1695069406
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7913: server: throw new exception when rootdisksize is required but not set
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7913:
URL: https://github.com/apache/cloudstack/pull/7913#issuecomment-1693103466
> @weizhouapache #7115 is this not a UI bug ?
@harikrishna-patnala
yes, we 'd better enforce user to input the rootdisksize (in the scenario) on UI
I think the new error message is more clear than before
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7913: server: throw new exception when rootdisksize is required but not set
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7913:
URL: https://github.com/apache/cloudstack/pull/7913#issuecomment-1694807713
<b>[SF] Trillian test result (tid-7578)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38267 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7913-t7578-xenserver-71.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_deploy_vm_from_iso | `Error` | 7.95 | test_deploy_vm_iso.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7913: server: throw new exception when rootdisksize is required but not set
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on code in PR #7913:
URL: https://github.com/apache/cloudstack/pull/7913#discussion_r1305364634
##########
server/src/main/java/com/cloud/vm/UserVmManagerImpl.java:
##########
@@ -4320,7 +4320,14 @@ public boolean checkIfDynamicScalingCanBeEnabled(VirtualMachine vm, ServiceOffer
*/
protected long configureCustomRootDiskSize(Map<String, String> customParameters, VMTemplateVO template, HypervisorType hypervisorType, DiskOfferingVO rootDiskOffering) {
verifyIfHypervisorSupportsRootdiskSizeOverride(hypervisorType);
- long rootDiskSizeInBytes = verifyAndGetDiskSize(rootDiskOffering, NumbersUtil.parseLong(customParameters.get(VmDetailConstants.ROOT_DISK_SIZE), -1));
+ Long rootDiskSizeCustomParam = null;
+ if (customParameters.containsKey(VmDetailConstants.ROOT_DISK_SIZE)) {
+ rootDiskSizeCustomParam = NumbersUtil.parseLong(customParameters.get(VmDetailConstants.ROOT_DISK_SIZE), -1);
+ if (rootDiskSizeCustomParam <= 0) {
+ throw new InvalidParameterValueException("Root disk size should be a positive number.");
Review Comment:
@DaanHoogland
this error is thrown if root disk size is passed , but invalid.
if root disk size is required but not passed, the error is thrown by code
https://github.com/apache/cloudstack/blob/3b05797344c15a9fbd6bee4ecd38281b677f24a2/server/src/main/java/com/cloud/vm/UserVmManagerImpl.java#L4310-L4316
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7913: server: throw new exception when rootdisksize is required but not set
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7913:
URL: https://github.com/apache/cloudstack/pull/7913#issuecomment-1694589894
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7913: server: throw new exception when rootdisksize is required but not set
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7913:
URL: https://github.com/apache/cloudstack/pull/7913#issuecomment-1694336119
@weizhouapache a [SF] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7913: server: throw new exception when rootdisksize is required but not set
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7913:
URL: https://github.com/apache/cloudstack/pull/7913#issuecomment-1692985007
@weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #7913: server: throw new exception when rootdisksize is required but not set
Posted by "harikrishna-patnala (via GitHub)" <gi...@apache.org>.
harikrishna-patnala commented on PR #7913:
URL: https://github.com/apache/cloudstack/pull/7913#issuecomment-1692999057
@weizhouapache https://github.com/apache/cloudstack/issues/7115 is this not a UI bug ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7913: server: throw new exception when rootdisksize is required but not set
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7913:
URL: https://github.com/apache/cloudstack/pull/7913#issuecomment-1693062193
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6892
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7913: server: throw new exception when rootdisksize is required but not set
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #7913:
URL: https://github.com/apache/cloudstack/pull/7913#discussion_r1305358961
##########
server/src/main/java/com/cloud/vm/UserVmManagerImpl.java:
##########
@@ -4320,7 +4320,14 @@ public boolean checkIfDynamicScalingCanBeEnabled(VirtualMachine vm, ServiceOffer
*/
protected long configureCustomRootDiskSize(Map<String, String> customParameters, VMTemplateVO template, HypervisorType hypervisorType, DiskOfferingVO rootDiskOffering) {
verifyIfHypervisorSupportsRootdiskSizeOverride(hypervisorType);
- long rootDiskSizeInBytes = verifyAndGetDiskSize(rootDiskOffering, NumbersUtil.parseLong(customParameters.get(VmDetailConstants.ROOT_DISK_SIZE), -1));
+ Long rootDiskSizeCustomParam = null;
+ if (customParameters.containsKey(VmDetailConstants.ROOT_DISK_SIZE)) {
+ rootDiskSizeCustomParam = NumbersUtil.parseLong(customParameters.get(VmDetailConstants.ROOT_DISK_SIZE), -1);
+ if (rootDiskSizeCustomParam <= 0) {
+ throw new InvalidParameterValueException("Root disk size should be a positive number.");
Review Comment:
this is not the text I see in the description @weizhouapache . any last minute changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7913: server: throw new exception when rootdisksize is required but not set
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7913:
URL: https://github.com/apache/cloudstack/pull/7913#issuecomment-1694665588
@weizhouapache a [SF] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7913: server: throw new exception when rootdisksize is required but not set
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7913:
URL: https://github.com/apache/cloudstack/pull/7913#issuecomment-1694665314
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7913: server: throw new exception when rootdisksize is required but not set
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7913:
URL: https://github.com/apache/cloudstack/pull/7913#issuecomment-1692982940
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7913: server: throw new exception when rootdisksize is required but not set
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7913:
URL: https://github.com/apache/cloudstack/pull/7913#issuecomment-1694883395
<b>[SF] Trillian test result (tid-7580)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44616 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7913-t7580-kvm-centos7.zip
Smoke tests completed. 106 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_deploy_vm_from_iso | `Error` | 7.86 | test_deploy_vm_iso.py
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 943.78 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7913: server: throw new exception when rootdisksize is required but not set
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7913:
URL: https://github.com/apache/cloudstack/pull/7913#issuecomment-1694335993
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7913: server: throw new exception when rootdisksize is required but not set
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7913:
URL: https://github.com/apache/cloudstack/pull/7913#issuecomment-1695138940
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6908
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7913: server: throw new exception when rootdisksize is required but not set
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7913:
URL: https://github.com/apache/cloudstack/pull/7913#issuecomment-1693978042
<b>[SF] Trillian test result (tid-7558)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41943 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7913-t7558-kvm-centos7.zip
Smoke tests completed. 106 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_deploy_vm_from_iso | `Error` | 7.93 | test_deploy_vm_iso.py
test_02_upgrade_kubernetes_cluster | `Failure` | 566.47 | test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 720.72 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org