You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by "liubao68 (via GitHub)" <gi...@apache.org> on 2023/10/19 06:26:26 UTC

[PR] [SCB-2813]DynamicProperties: when key removed should get default value [servicecomb-java-chassis]

liubao68 opened a new pull request, #3978:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3978

   Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [SCB-2813]DynamicProperties: when key removed should get default value [servicecomb-java-chassis]

Posted by "liubao68 (via GitHub)" <gi...@apache.org>.
liubao68 merged PR #3978:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3978


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [SCB-2813]DynamicProperties: when key removed should get default value [servicecomb-java-chassis]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3978:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3978#issuecomment-1770170062

   ## [Codecov](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/3978?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#3978](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/3978?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (dfd8ebc) into [master](https://app.codecov.io/gh/apache/servicecomb-java-chassis/commit/06b2b5f02f99628c2dcef14e7fda24f604860f83?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (06b2b5f) will **increase** coverage by `0.20%`.
   > The diff coverage is `6.97%`.
   
   > :exclamation: Current head dfd8ebc differs from pull request most recent head aa45d9b. Consider uploading reports for the commit aa45d9b to get more accurate results
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3978      +/-   ##
   ============================================
   + Coverage     43.80%   44.00%   +0.20%     
   - Complexity     5311     5329      +18     
   ============================================
     Files          1391     1392       +1     
     Lines         34023    34041      +18     
     Branches       3336     3331       -5     
   ============================================
   + Hits          14903    14979      +76     
   + Misses        17929    17874      -55     
   + Partials       1191     1188       -3     
   ```
   
   
   | [Files](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/3978?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [.../servicecomb/config/ConfigurationChangedEvent.java](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/3978?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1jb25maWcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2NvbmZpZy9Db25maWd1cmF0aW9uQ2hhbmdlZEV2ZW50LmphdmE=) | `43.75% <ø> (ø)` | |
   | [...config/cc/ConfigCenterDynamicPropertiesSource.java](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/3978?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZHluYW1pYy1jb25maWcvY29uZmlnLWNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9jb25maWcvY2MvQ29uZmlnQ2VudGVyRHluYW1pY1Byb3BlcnRpZXNTb3VyY2UuamF2YQ==) | `61.84% <0.00%> (-2.55%)` | :arrow_down: |
   | [...ervicecomb/config/kie/client/KieConfigManager.java](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/3978?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50cy9jb25maWcta2llLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29uZmlnL2tpZS9jbGllbnQvS2llQ29uZmlnTWFuYWdlci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...icecomb/config/kie/KieDynamicPropertiesSource.java](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/3978?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZHluYW1pYy1jb25maWcvY29uZmlnLWtpZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29uZmlnL2tpZS9LaWVEeW5hbWljUHJvcGVydGllc1NvdXJjZS5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...comb/config/center/client/ConfigCenterManager.java](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/3978?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50cy9jb25maWctY2VudGVyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29uZmlnL2NlbnRlci9jbGllbnQvQ29uZmlnQ2VudGVyTWFuYWdlci5qYXZh) | `62.06% <0.00%> (-4.60%)` | :arrow_down: |
   | [...onfig/kie/client/KieConfigurationChangedEvent.java](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/3978?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50cy9jb25maWcta2llLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29uZmlnL2tpZS9jbGllbnQvS2llQ29uZmlndXJhdGlvbkNoYW5nZWRFdmVudC5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...ache/servicecomb/config/DynamicPropertiesImpl.java](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/3978?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1jb25maWcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2NvbmZpZy9EeW5hbWljUHJvcGVydGllc0ltcGwuamF2YQ==) | `22.38% <20.68%> (+5.34%)` | :arrow_up: |
   | [.../client/ConfigCenterConfigurationChangedEvent.java](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/3978?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50cy9jb25maWctY2VudGVyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29uZmlnL2NlbnRlci9jbGllbnQvQ29uZmlnQ2VudGVyQ29uZmlndXJhdGlvbkNoYW5nZWRFdmVudC5qYXZh) | `0.00% <0.00%> (ø)` | |
   
   ... and [17 files with indirect coverage changes](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/3978/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org