You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Ashutosh Kelkar <as...@clogeny.com> on 2015/02/04 06:56:31 UTC

Re: Review Request 25885: CLOUDSTACK-7594: Adding automation test cases for Stopped VM test path

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25885/#review70927
-----------------------------------------------------------


I have addressed all the review comments, and also verified that patch is still valid against latest master branch. It applies cleanly. Sadhu, can you please look at this?

- Ashutosh Kelkar


On Oct. 1, 2014, 9:18 a.m., Ashutosh Kelkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25885/
> -----------------------------------------------------------
> 
> (Updated Oct. 1, 2014, 9:18 a.m.)
> 
> 
> Review request for cloudstack, suresh sadhu and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-7594
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7594
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Automation test cases for Stopped VM test path.
> 
> 
> Diffs
> -----
> 
>   test/integration/testpaths/testpath_stopped_vm.py PRE-CREATION 
>   tools/marvin/marvin/lib/base.py d623386 
> 
> Diff: https://reviews.apache.org/r/25885/diff/
> 
> 
> Testing
> -------
> 
> Yes.
> 
> Advanced zone:
> Positive test for stopped VM test path - T1 ... === TestName: test_01_pt_deploy_vm_without_startvm | Status : SUCCESS ===
> ok
> Positive test for stopped VM test path - T1 variant ... === TestName: test_02_pt_deploy_vm_with_startvm_true | Status : SUCCESS ===
> ok
> Positive test for stopped VM test path - T2 ... === TestName: test_03_pt_deploy_vm_with_startvm_false | Status : SUCCESS ===
> ok
> Positive test for stopped VM test path - T3 and variant, T9 ... === TestName: test_04_pt_startvm_false_attach_disk | Status : SUCCESS ===
> ok
> Positive test for stopped VM test path - T4 ... === TestName: test_05_pt_startvm_false_attach_disk_change_SO | Status : SUCCESS ===
> ok
> Positive test for stopped VM test path - T5 ... === TestName: test_06_pt_startvm_false_attach_iso | Status : SUCCESS ===
> ok
> Positive test for stopped VM test path - T5 variant ... === TestName: test_07_pt_startvm_false_attach_iso_running_vm | Status : SUCCESS ===
> ok
> Positive test for stopped VM test path - T10 ... === TestName: test_08_pt_startvm_false_password_enabled_template | Status : SUCCESS ===
> ok
> Positive test for stopped VM test path - T11 ... === TestName: test_09_pt_destroy_stopped_vm | Status : SUCCESS ===
> ok
> Positive test for stopped VM test path - T12 ... === TestName: test_10_max_account_limit | Status : SUCCESS ===
> ok
> 
> 
> Basic zone:
> 
> Positive test for stopped VM test path - T1 ... === TestName: test_01_pt_deploy_vm_without_startvm | Status : SUCCESS ===
> ok
> Positive test for stopped VM test path - T1 variant ... === TestName: test_02_pt_deploy_vm_with_startvm_true | Status : SUCCESS ===
> ok
> Positive test for stopped VM test path - T2 ... === TestName: test_03_pt_deploy_vm_with_startvm_false | Status : SUCCESS ===
> ok
> Positive test for stopped VM test path - T3 and variant, T9 ... === TestName: test_04_pt_startvm_false_attach_disk | Status : SUCCESS ===
> ok
> Positive test for stopped VM test path - T4 ... === TestName: test_05_pt_startvm_false_attach_disk_change_SO | Status : SUCCESS ===
> ok
> Positive test for stopped VM test path - T5 ... === TestName: test_06_pt_startvm_false_attach_iso | Status : SUCCESS ===
> ok
> Positive test for stopped VM test path - T5 variant ... === TestName: test_07_pt_startvm_false_attach_iso_running_vm | Status : SUCCESS ===
> ok
> Positive test for stopped VM test path - T10 ... === TestName: test_08_pt_startvm_false_password_enabled_template | Status : SUCCESS ===
> ok
> Positive test for stopped VM test path - T11 ... === TestName: test_09_pt_destroy_stopped_vm | Status : SUCCESS ===
> ok
> Positive test for stopped VM test path - T12 ... === TestName: test_10_max_account_limit | Status : SUCCESS ===
> ok
> 
> ----------------------------------------------------------------------
> Ran 10 tests in 2792.968s
> 
> OK
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>


RE: Review Request 25885: CLOUDSTACK-7594: Adding automation test cases for Stopped VM test path

Posted by Suresh Sadhu <Su...@citrix.com>.
Sure,I will review it and will let you know after checking the details .

Thanks
sadhu
________________________________________
From: Ashutosh Kelkar [noreply@reviews.apache.org] on behalf of Ashutosh Kelkar [ashutosh@clogeny.com]
Sent: Wednesday, February 04, 2015 11:26 AM
To: suresh sadhu; Srikanteswararao Talluri
Cc: Ashutosh Kelkar; cloudstack
Subject: Re: Review Request 25885: CLOUDSTACK-7594: Adding automation test cases for Stopped VM test path

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25885/#review70927
-----------------------------------------------------------


I have addressed all the review comments, and also verified that patch is still valid against latest master branch. It applies cleanly. Sadhu, can you please look at this?

- Ashutosh Kelkar


On Oct. 1, 2014, 9:18 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25885/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2014, 9:18 a.m.)
>
>
> Review request for cloudstack, suresh sadhu and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-7594
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7594
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Automation test cases for Stopped VM test path.
>
>
> Diffs
> -----
>
>   test/integration/testpaths/testpath_stopped_vm.py PRE-CREATION
>   tools/marvin/marvin/lib/base.py d623386
>
> Diff: https://reviews.apache.org/r/25885/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Advanced zone:
> Positive test for stopped VM test path - T1 ... === TestName: test_01_pt_deploy_vm_without_startvm | Status : SUCCESS ===
> ok
> Positive test for stopped VM test path - T1 variant ... === TestName: test_02_pt_deploy_vm_with_startvm_true | Status : SUCCESS ===
> ok
> Positive test for stopped VM test path - T2 ... === TestName: test_03_pt_deploy_vm_with_startvm_false | Status : SUCCESS ===
> ok
> Positive test for stopped VM test path - T3 and variant, T9 ... === TestName: test_04_pt_startvm_false_attach_disk | Status : SUCCESS ===
> ok
> Positive test for stopped VM test path - T4 ... === TestName: test_05_pt_startvm_false_attach_disk_change_SO | Status : SUCCESS ===
> ok
> Positive test for stopped VM test path - T5 ... === TestName: test_06_pt_startvm_false_attach_iso | Status : SUCCESS ===
> ok
> Positive test for stopped VM test path - T5 variant ... === TestName: test_07_pt_startvm_false_attach_iso_running_vm | Status : SUCCESS ===
> ok
> Positive test for stopped VM test path - T10 ... === TestName: test_08_pt_startvm_false_password_enabled_template | Status : SUCCESS ===
> ok
> Positive test for stopped VM test path - T11 ... === TestName: test_09_pt_destroy_stopped_vm | Status : SUCCESS ===
> ok
> Positive test for stopped VM test path - T12 ... === TestName: test_10_max_account_limit | Status : SUCCESS ===
> ok
>
>
> Basic zone:
>
> Positive test for stopped VM test path - T1 ... === TestName: test_01_pt_deploy_vm_without_startvm | Status : SUCCESS ===
> ok
> Positive test for stopped VM test path - T1 variant ... === TestName: test_02_pt_deploy_vm_with_startvm_true | Status : SUCCESS ===
> ok
> Positive test for stopped VM test path - T2 ... === TestName: test_03_pt_deploy_vm_with_startvm_false | Status : SUCCESS ===
> ok
> Positive test for stopped VM test path - T3 and variant, T9 ... === TestName: test_04_pt_startvm_false_attach_disk | Status : SUCCESS ===
> ok
> Positive test for stopped VM test path - T4 ... === TestName: test_05_pt_startvm_false_attach_disk_change_SO | Status : SUCCESS ===
> ok
> Positive test for stopped VM test path - T5 ... === TestName: test_06_pt_startvm_false_attach_iso | Status : SUCCESS ===
> ok
> Positive test for stopped VM test path - T5 variant ... === TestName: test_07_pt_startvm_false_attach_iso_running_vm | Status : SUCCESS ===
> ok
> Positive test for stopped VM test path - T10 ... === TestName: test_08_pt_startvm_false_password_enabled_template | Status : SUCCESS ===
> ok
> Positive test for stopped VM test path - T11 ... === TestName: test_09_pt_destroy_stopped_vm | Status : SUCCESS ===
> ok
> Positive test for stopped VM test path - T12 ... === TestName: test_10_max_account_limit | Status : SUCCESS ===
> ok
>
> ----------------------------------------------------------------------
> Ran 10 tests in 2792.968s
>
> OK
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>