You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "assignUser (via GitHub)" <gi...@apache.org> on 2024/01/16 00:51:23 UTC
[PR] GH-39624: [R][CI] Add CMake to docker file and update envvars [arrow]
assignUser opened a new pull request, #39625:
URL: https://github.com/apache/arrow/pull/39625
### Rationale for this change
CMake is now a sysreq and we don't want to default to using nightly builds in CI
### Are these changes tested?
Crossbos
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39624: [R][CI] Add CMake to docker file and update envvars [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #39625:
URL: https://github.com/apache/arrow/pull/39625#issuecomment-1893739637
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit ac50918a63f13088a5ea9e6c27a9fadbbb19d53f.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/20530702150) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39624: [R][CI] Add CMake to docker file and update envvars [arrow]
Posted by "nealrichardson (via GitHub)" <gi...@apache.org>.
nealrichardson commented on code in PR #39625:
URL: https://github.com/apache/arrow/pull/39625#discussion_r1452829941
##########
ci/scripts/r_docker_configure.sh:
##########
@@ -91,8 +91,9 @@ if [ -f "${ARROW_SOURCE_HOME}/ci/scripts/r_install_system_dependencies.sh" ]; th
"${ARROW_SOURCE_HOME}/ci/scripts/r_install_system_dependencies.sh"
fi
-# Install rsync for bundling cpp source and curl to make sure it is installed on all images
-$PACKAGE_MANAGER install -y rsync curl
+# Install rsync for bundling cpp source and curl to make sure it is installed on all images,
+# cmake is now a listed sys req.
+$PACKAGE_MANAGER install -y rsync cmake curl
Review Comment:
If `cmake` isn't new enough on the `test-r-offline-maximal` job, it will still fail. 🤞 this is fine, otherwise we'll want to use install_cmake.sh
##########
docker-compose.yml:
##########
@@ -1413,7 +1413,7 @@ services:
<<: *common
ARROW_DEPENDENCY_SOURCE: ''
ARROW_SOURCE_HOME: '/arrow'
- FORCE_BUNDLED_BUILD: 'true'
Review Comment:
Unless you're going to do all of the things in #39620, `FORCE_BUNDLED_BUILD` is still how you skip looking for libarrow with pkg-config. This may be fine here, I'm not sure how `extends: ubuntu-r` works in docker-compose, if this overrides the `ubuntu-r` `command:`, then libarrow won't be built on the system already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39624: [R][CI] Add CMake to docker file and update envvars [arrow]
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser merged PR #39625:
URL: https://github.com/apache/arrow/pull/39625
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39624: [R][CI] Add CMake to docker file and update envvars [arrow]
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on code in PR #39625:
URL: https://github.com/apache/arrow/pull/39625#discussion_r1452831609
##########
docker-compose.yml:
##########
@@ -1413,7 +1413,7 @@ services:
<<: *common
ARROW_DEPENDENCY_SOURCE: ''
ARROW_SOURCE_HOME: '/arrow'
- FORCE_BUNDLED_BUILD: 'true'
Review Comment:
Hm right, I'll revert it for now, I just want to get CI going so we can move on with the release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39624: [R][CI] Add CMake to docker file and update envvars [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39625:
URL: https://github.com/apache/arrow/pull/39625#issuecomment-1892919624
:warning: GitHub issue #39624 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39624: [R][CI] Add CMake to docker file and update envvars [arrow]
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on PR #39625:
URL: https://github.com/apache/arrow/pull/39625#issuecomment-1893016064
The depsource build fails because of #39628
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39624: [R][CI] Add CMake to docker file and update envvars [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39625:
URL: https://github.com/apache/arrow/pull/39625#issuecomment-1892931269
Revision: 2c97109cb76d3193a6f67488eb76bdf62f2c9c10
Submitted crossbow builds: [ursacomputing/crossbow @ actions-65d2e156c3](https://github.com/ursacomputing/crossbow/branches/all?query=actions-65d2e156c3)
|Task|Status|
|----|------|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/7535684144/job/20512036806)|
|test-fedora-r-clang-sanitizer|[](https://github.com/ursacomputing/crossbow/runs/20512028437)|
|test-r-arrow-backwards-compatibility|[](https://github.com/ursacomputing/crossbow/actions/runs/7535684478/job/20512028383)|
|test-r-depsource-bundled|[](https://github.com/ursacomputing/crossbow/runs/20512028443)|
|test-r-depsource-system|[](https://github.com/ursacomputing/crossbow/actions/runs/7535684284/job/20512027804)|
|test-r-dev-duckdb|[](https://github.com/ursacomputing/crossbow/actions/runs/7535684377/job/20512028091)|
|test-r-devdocs|[](https://github.com/ursacomputing/crossbow/actions/runs/7535684110/job/20512027472)|
|test-r-gcc-11|[](https://github.com/ursacomputing/crossbow/actions/runs/7535683869/job/20512026887)|
|test-r-gcc-12|[](https://github.com/ursacomputing/crossbow/actions/runs/7535684358/job/20512028007)|
|test-r-install-local|[](https://github.com/ursacomputing/crossbow/actions/runs/7535684461/job/20512028548)|
|test-r-install-local-minsizerel|[](https://github.com/ursacomputing/crossbow/actions/runs/7535683892/job/20512027077)|
|test-r-library-r-base-latest|[](https://github.com/ursacomputing/crossbow/runs/20512029428)|
|test-r-linux-as-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/7535683941/job/20512027622)|
|test-r-linux-rchk|[](https://github.com/ursacomputing/crossbow/actions/runs/7535684286/job/20512027774)|
|test-r-linux-valgrind|[](https://github.com/ursacomputing/crossbow/runs/20512028781)|
|test-r-minimal-build|[](https://github.com/ursacomputing/crossbow/runs/20512028821)|
|test-r-offline-maximal|[](https://github.com/ursacomputing/crossbow/actions/runs/7535684292/job/20512027934)|
|test-r-offline-minimal|[](https://github.com/ursacomputing/crossbow/runs/20512029176)|
|test-r-rhub-debian-gcc-devel-lto-latest|[](https://github.com/ursacomputing/crossbow/runs/20512028770)|
|test-r-rhub-debian-gcc-release-custom-ccache|[](https://github.com/ursacomputing/crossbow/runs/20512029179)|
|test-r-rhub-ubuntu-gcc-release-latest|[](https://github.com/ursacomputing/crossbow/runs/20512028820)|
|test-r-rstudio-r-base-4.1-opensuse153|[](https://github.com/ursacomputing/crossbow/runs/20512028145)|
|test-r-rstudio-r-base-4.2-centos7-devtoolset-8|[](https://github.com/ursacomputing/crossbow/runs/20512027762)|
|test-r-rstudio-r-base-4.2-focal|[](https://github.com/ursacomputing/crossbow/runs/20512028066)|
|test-r-ubuntu-22.04|[](https://github.com/ursacomputing/crossbow/actions/runs/7535684259/job/20512027714)|
|test-r-versions|[](https://github.com/ursacomputing/crossbow/actions/runs/7535684457/job/20512028689)|
|test-ubuntu-r-sanitizer|[](https://github.com/ursacomputing/crossbow/runs/20512028721)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39624: [R][CI] Add CMake to docker file and update envvars [arrow]
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on code in PR #39625:
URL: https://github.com/apache/arrow/pull/39625#discussion_r1452832102
##########
ci/scripts/r_docker_configure.sh:
##########
@@ -91,8 +91,9 @@ if [ -f "${ARROW_SOURCE_HOME}/ci/scripts/r_install_system_dependencies.sh" ]; th
"${ARROW_SOURCE_HOME}/ci/scripts/r_install_system_dependencies.sh"
fi
-# Install rsync for bundling cpp source and curl to make sure it is installed on all images
-$PACKAGE_MANAGER install -y rsync curl
+# Install rsync for bundling cpp source and curl to make sure it is installed on all images,
+# cmake is now a listed sys req.
+$PACKAGE_MANAGER install -y rsync cmake curl
Review Comment:
We should(tm) have new enough cmake the only issue would be centos 7 but as we source devtool set there that should work as well. But we will see^^
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39624: [R][CI] Add CMake to docker file and update envvars [arrow]
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on PR #39625:
URL: https://github.com/apache/arrow/pull/39625#issuecomment-1892919668
@gihub-actions crossbow submit -g r
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org