[GitHub] craigrouse commented on issue #299: CB-11233 - Support installing frameworks into "Embedded Binaries" section of the Xcode project

[GitBox <gi...@apache.org>]

craigrouse commented on issue #299: CB-11233 - Support installing frameworks into "Embedded Binaries" section of the Xcode project
URL: https://github.com/apache/cordova-ios/pull/299#issuecomment-341485984
 
 
   @shazron I have just been testing this (CLI 7.0.1), and found that one of my embedded frameworks was not working at all, even though it appeared in the "Embedded Binaries" section in the Xcode project when opened in Xcode. I noticed that when I removed and re-added the framework using Xcode, the framework started working as expected. I inspected the source for the Xcode project, and found that the difference was that Xcode also added the file to the "PBXFrameworksBuildPhase" section, which seems to map to the "Link Binary With Libraries" build phase in the Xcode GUI. Now in my plugin.xml, if I specify the framework twice; once with embed=true/custom=true and once without, in places the binary in both sections and works as expected. This feels like it is probably a Cordova bug, but perhaps it's expected behaviour? I would have expected it to work the same way as the Xcode UI when you hit "+" in the "Embedded Binaries" section of the project, and it doesn't appear to, so I personally believe this is a bug. Your thoughts and feedback would be most welcome. Craig.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org