[GitHub] [solr] janhoy commented on pull request #1168: SOLR-16532 New OTEL module with OTLP trace exporter

[GitBox <gi...@apache.org>]

janhoy commented on PR #1168:
URL: https://github.com/apache/solr/pull/1168#issuecomment-1368824084

   Happy New Year! 
   
   I updated this PR with an integration test similar to the one in `JaegerTracerConfigurator`, starting the tracer in a cluster.
   
   I then discovered that the OTEL tracer was not being closed correctly, and there was a leaking background thread from the batch span exporter. Turned out that OTEL's [OpenTracing Shim](https://github.com/open-telemetry/opentelemetry-java/tree/main/opentracing-shim) class by design [will not close the actual tracer](https://github.com/open-telemetry/opentelemetry-java/blob/v1.21.0/opentracing-shim/src/main/java/io/opentelemetry/opentracingshim/TracerShim.java#L98), so when `CoreContainer#shutdown()` is called, the tracer is left open.
   
   The workaround I chose is to wrap the `TracerShim` in a thin `ClosableTracerShim` delegate class that will properly close the tracer through the SDK. Seems to work, though I have yet to test this version of the module with a real collector.
   
   I also had to adjust the dependencies, since I started using the SDK directly and not only through ENV auto-config.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org